Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x][Manual Backport] Move TopNavLinks to new Nav Bar Discover (#7326) #7455

Closed

Conversation

LDrago27
Copy link
Collaborator

Backport PR:
#7326

Description

Issues Resolved

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
(cherry picked from commit e46e54a)
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 67.81%. Comparing base (0b7b75f) to head (17093f4).

Files Patch % Lines
.../data_explorer/public/components/app_container.tsx 62.50% 1 Missing and 2 partials ⚠️
...public/ui/query_string_input/query_bar_top_row.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7455      +/-   ##
==========================================
- Coverage   67.81%   67.81%   -0.01%     
==========================================
  Files        3600     3601       +1     
  Lines       72605    72614       +9     
  Branches    11898    11900       +2     
==========================================
+ Hits        49238    49242       +4     
- Misses      20373    20375       +2     
- Partials     2994     2997       +3     
Flag Coverage Δ
Linux_1 32.95% <100.00%> (-0.01%) ⬇️
Linux_2 55.66% <ø> (ø)
Linux_3 43.66% <63.63%> (+<0.01%) ⬆️
Linux_4 34.38% <ø> (ø)
Windows_1 32.97% <100.00%> (+<0.01%) ⬆️
Windows_2 55.61% <ø> (ø)
Windows_3 43.67% <63.63%> (+<0.01%) ⬆️
Windows_4 34.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ananzh
Copy link
Member

ananzh commented Jul 25, 2024

This will be backported in #7477
Close it.

@ananzh ananzh closed this Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants