Move TopNavLinks to new Nav Bar Discover #7326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jul 19, 2024
LDrago27
force-pushed
the
discoverNewNavBar
branch
from
3929995 to
33fc72f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7326 +/- ##
==========================================
- Coverage 67.62% 63.97% -3.65%
==========================================
Files 3584 3598 +14
Lines 72198 78323 +6125
Branches 11815 12353 +538
==========================================
+ Hits 48826 50110 +1284
- Misses 20387 25190 +4803
- Partials 2985 3023 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
LDrago27
force-pushed
the
discoverNewNavBar
branch
from
33fc72f to
1acbbc4
Compare
opensearch-changeset-bot bot
added a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jul 22, 2024
74 tasks
|
When the toggle is off, i can see this bar at the top of discover: |
Screen.Recording.2024-07-22.at.3.36.51.PM.movThe icons also dont have a tooltip indicating what they are right now |
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
LDrago27
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl and
BionIT
as code owners
LDrago27
requested review from
xinruiba,
zhyuanqi,
mengweieric and
virajsanghvi
as code owners
|
@ashwin-pc Thanks for feedback. I have fixed the issues highlighted above and migrated the date Picker to the Nav bar too. |
LDrago27
force-pushed
the
discoverNewNavBar
branch
from
de29db9 to
8485cb2
Compare
kavilla
previously approved these changes
Jul 23, 2024
LDrago27
force-pushed
the
discoverNewNavBar
branch
from
8485cb2 to
6d7d2b9
Compare
Signed-off-by: Suchit Sahoo <suchsah@amazon.com>
LDrago27
force-pushed
the
discoverNewNavBar
branch
from
6d7d2b9 to
70b830f
Compare
ashwin-pc
approved these changes
Jul 23, 2024
There was a problem hiding this comment.
Nit: Can we avoid registering them?
kavilla
approved these changes
Jul 23, 2024
|
The backport to To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7326-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e46e54a85fac05684c4a052325331e4f7331b6ce
# Push it to GitHub
git push --set-upstream origin backport/backport-7326-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.xThen, create a pull request where the |
LDrago27
added a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Suchit Sahoo <suchsah@amazon.com> (cherry picked from commit e46e54a)
7 tasks
LDrago27
added a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Suchit Sahoo <suchsah@amazon.com> (cherry picked from commit e46e54a)
7 tasks
LDrago27
added a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jul 24, 2024
Signed-off-by: Suchit Sahoo <suchsah@amazon.com> (cherry picked from commit e46e54a)
7 tasks
LDrago27
added a commit
to LDrago27/OpenSearch-Dashboards
that referenced
this pull request
Jul 25, 2024
This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on. Signed-off-by: Suchit Sahoo <suchsah@amazon.com> (cherry picked from commit e46e54a)
LDrago27
added a commit
that referenced
this pull request
Jul 25, 2024
* Bump OUI to 1.8.0 (#7363) Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit c1bae75) * [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336) * cherry pick Signed-off-by: Eric <menwe@amazon.com> * SQL keyword suggestion Signed-off-by: Eric <menwe@amazon.com> * column and values suggestions Signed-off-by: Eric <menwe@amazon.com> * adjust values suggestions and ignored token Signed-off-by: Eric <menwe@amazon.com> * suggestion type casting Signed-off-by: Eric <menwe@amazon.com> * ignore functions Signed-off-by: Eric <menwe@amazon.com> * case insensitive Signed-off-by: Eric <menwe@amazon.com> * change to use grammar for insensitive case Signed-off-by: Eric <menwe@amazon.com> * fix multi-line issue Signed-off-by: Eric <menwe@amazon.com> * code cleanup Signed-off-by: Eric <menwe@amazon.com> * move ppl out of scope Signed-off-by: Eric <menwe@amazon.com> * rename folder and add ignoring rules Signed-off-by: Eric <menwe@amazon.com> * resolve type issue Signed-off-by: Eric <menwe@amazon.com> * fix ppl suggestion provider issue Signed-off-by: Eric <menwe@amazon.com> * remove function suggestion Signed-off-by: Eric <menwe@amazon.com> * some code clean up and adding tests Signed-off-by: Eric <menwe@amazon.com> * cursor tests Signed-off-by: Eric <menwe@amazon.com> * remove testing setup Signed-off-by: Eric <menwe@amazon.com> * add changelog Signed-off-by: Eric <menwe@amazon.com> * update yarn file Signed-off-by: Eric <menwe@amazon.com> * add missing testing library Signed-off-by: Eric <menwe@amazon.com> * MDS integration Signed-off-by: Eric <menwe@amazon.com> * minor interface change and disable word based suggestion Signed-off-by: Eric <menwe@amazon.com> * update ID_LITERAL and recompile grammar Signed-off-by: Eric <menwe@amazon.com> * column suggest for agg function Signed-off-by: Eric <menwe@amazon.com> * revert version Signed-off-by: Eric <menwe@amazon.com> * opensearch sql syntax highlighting Signed-off-by: Eric <menwe@amazon.com> * add utility tests Signed-off-by: Eric <menwe@amazon.com> * symbol table test Signed-off-by: Eric <menwe@amazon.com> * error listener test Signed-off-by: Eric <menwe@amazon.com> * parse test Signed-off-by: Eric <menwe@amazon.com> * add suggestion provider to single line query editor Signed-off-by: Eric <menwe@amazon.com> * remove one test Signed-off-by: Eric <menwe@amazon.com> * add connection service type Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com> (cherry picked from commit 9348bd4) * Move TopNavLinks to new Nav Bar Discover (#7326) This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on. Signed-off-by: Suchit Sahoo <suchsah@amazon.com> (cherry picked from commit e46e54a) * [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401) * feat: add scoped breadcrumbs Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7401 created/updated * feat: move data source management register logic up a little bit Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: revert the home related change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: overview error in all use case when workspace is enabled Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7401 created/updated * fix: hide nav groups that should be displayed Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: hide expand icon in left navigation Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit 3f78c94) * [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440) * Move data source manageable feature flag to DSM plugin Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #7440 created/updated --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit dfcd2e1) * [Discover-next] data set picker (#7426) * update using query manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * aggs not working Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * almost there Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * stablish Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * thanks ashwin Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update ref name Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix timefields Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * clean up some console logs Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * go safer route of setting language Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * its working again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix names Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * restore code editor and indices Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * sql df Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix external datasources again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 6a079d3) * Fix add filter for numeric scripted field (#7022) * Fix add filter for scripted field Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add unit test Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change from nested ternary to if else Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add more unit tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change unit tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix typo Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit 7c1f8fc) * [Bug][Workspace] Add permission validation at workspace detail page (#7435) * [Bug][Workspace] Add permission validate at workspace detail page Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #7435 created/updated --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 45d34b5) * Revert "[Discover-next] data set picker (#7426)" (#7479) This reverts commit 6a079d3. --------- Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: yuboluo <yubonluo@amazon.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Sean Li <lnse@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Bump OUI to 1.8.0 (#7363) Signed-off-by: Miki <miki@amazon.com> (cherry picked from commit c1bae75) * [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336) * cherry pick Signed-off-by: Eric <menwe@amazon.com> * SQL keyword suggestion Signed-off-by: Eric <menwe@amazon.com> * column and values suggestions Signed-off-by: Eric <menwe@amazon.com> * adjust values suggestions and ignored token Signed-off-by: Eric <menwe@amazon.com> * suggestion type casting Signed-off-by: Eric <menwe@amazon.com> * ignore functions Signed-off-by: Eric <menwe@amazon.com> * case insensitive Signed-off-by: Eric <menwe@amazon.com> * change to use grammar for insensitive case Signed-off-by: Eric <menwe@amazon.com> * fix multi-line issue Signed-off-by: Eric <menwe@amazon.com> * code cleanup Signed-off-by: Eric <menwe@amazon.com> * move ppl out of scope Signed-off-by: Eric <menwe@amazon.com> * rename folder and add ignoring rules Signed-off-by: Eric <menwe@amazon.com> * resolve type issue Signed-off-by: Eric <menwe@amazon.com> * fix ppl suggestion provider issue Signed-off-by: Eric <menwe@amazon.com> * remove function suggestion Signed-off-by: Eric <menwe@amazon.com> * some code clean up and adding tests Signed-off-by: Eric <menwe@amazon.com> * cursor tests Signed-off-by: Eric <menwe@amazon.com> * remove testing setup Signed-off-by: Eric <menwe@amazon.com> * add changelog Signed-off-by: Eric <menwe@amazon.com> * update yarn file Signed-off-by: Eric <menwe@amazon.com> * add missing testing library Signed-off-by: Eric <menwe@amazon.com> * MDS integration Signed-off-by: Eric <menwe@amazon.com> * minor interface change and disable word based suggestion Signed-off-by: Eric <menwe@amazon.com> * update ID_LITERAL and recompile grammar Signed-off-by: Eric <menwe@amazon.com> * column suggest for agg function Signed-off-by: Eric <menwe@amazon.com> * revert version Signed-off-by: Eric <menwe@amazon.com> * opensearch sql syntax highlighting Signed-off-by: Eric <menwe@amazon.com> * add utility tests Signed-off-by: Eric <menwe@amazon.com> * symbol table test Signed-off-by: Eric <menwe@amazon.com> * error listener test Signed-off-by: Eric <menwe@amazon.com> * parse test Signed-off-by: Eric <menwe@amazon.com> * add suggestion provider to single line query editor Signed-off-by: Eric <menwe@amazon.com> * remove one test Signed-off-by: Eric <menwe@amazon.com> * add connection service type Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com> (cherry picked from commit 9348bd4) * Move TopNavLinks to new Nav Bar Discover (#7326) This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on. Signed-off-by: Suchit Sahoo <suchsah@amazon.com> (cherry picked from commit e46e54a) * [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401) * feat: add scoped breadcrumbs Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7401 created/updated * feat: move data source management register logic up a little bit Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: add unit test Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: revert the home related change Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: overview error in all use case when workspace is enabled Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * fix: update snapshot Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * Changeset file for PR #7401 created/updated * fix: hide nav groups that should be displayed Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: hide expand icon in left navigation Signed-off-by: SuZhou-Joe <suzhou@amazon.com> * feat: update Signed-off-by: SuZhou-Joe <suzhou@amazon.com> --------- Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com> (cherry picked from commit 3f78c94) * [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440) * Move data source manageable feature flag to DSM plugin Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #7440 created/updated --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit dfcd2e1) * [Discover-next] data set picker (#7426) * update using query manager Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * aggs not working Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * almost there Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * stablish Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * thanks ashwin Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update ref name Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix timefields Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * clean up some console logs Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * go safer route of setting language Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * its working again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix names Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * restore code editor and indices Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * sql df Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix external datasources again Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit 6a079d3) * Fix add filter for numeric scripted field (#7022) * Fix add filter for scripted field Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add unit test Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change from nested ternary to if else Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add more unit tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change unit tests Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix typo Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> (cherry picked from commit 7c1f8fc) * [Bug][Workspace] Add permission validation at workspace detail page (#7435) * [Bug][Workspace] Add permission validate at workspace detail page Signed-off-by: yubonluo <yubonluo@amazon.com> * Changeset file for PR #7435 created/updated --------- Signed-off-by: yubonluo <yubonluo@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 45d34b5) * Revert "[Discover-next] data set picker (#7426)" (#7479) This reverts commit 6a079d3. --------- Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: yuboluo <yubonluo@amazon.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Sean Li <lnse@amazon.com> (cherry picked from commit 0515fb2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Bump OUI to 1.8.0 (#7363) (cherry picked from commit c1bae75) * [Auto Suggest] OpenSearch SQL autosuggest with ANTLR (#7336) * cherry pick * SQL keyword suggestion * column and values suggestions * adjust values suggestions and ignored token * suggestion type casting * ignore functions * case insensitive * change to use grammar for insensitive case * fix multi-line issue * code cleanup * move ppl out of scope * rename folder and add ignoring rules * resolve type issue * fix ppl suggestion provider issue * remove function suggestion * some code clean up and adding tests * cursor tests * remove testing setup * add changelog * update yarn file * add missing testing library * MDS integration * minor interface change and disable word based suggestion * update ID_LITERAL and recompile grammar * column suggest for agg function * revert version * opensearch sql syntax highlighting * add utility tests * symbol table test * error listener test * parse test * add suggestion provider to single line query editor * remove one test * add connection service type --------- (cherry picked from commit 9348bd4) * Move TopNavLinks to new Nav Bar Discover (#7326) This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on. (cherry picked from commit e46e54a) * [navigation-next]fix: breadcrumb issue found in data source management and other similar cases. (#7401) * feat: add scoped breadcrumbs * Changeset file for PR #7401 created/updated * feat: move data source management register logic up a little bit * feat: add unit test * feat: revert the home related change * fix: overview error in all use case when workspace is enabled * fix: update snapshot * Changeset file for PR #7401 created/updated * fix: hide nav groups that should be displayed * feat: hide expand icon in left navigation * feat: update --------- (cherry picked from commit 3f78c94) * [Bug][Data Source] Move data source manageable feature flag to DSM plugin (#7440) * Move data source manageable feature flag to DSM plugin * Changeset file for PR #7440 created/updated --------- (cherry picked from commit dfcd2e1) * [Discover-next] data set picker (#7426) * update using query manager * aggs not working * almost there * stablish * thanks ashwin * update ref name * fix timefields * clean up some console logs * go safer route of setting language * its working again * fix names * restore code editor and indices * sql df * fix external datasources again --------- (cherry picked from commit 6a079d3) * Fix add filter for numeric scripted field (#7022) * Fix add filter for scripted field * add unit test * change from nested ternary to if else * add more unit tests * change unit tests * fix typo --------- (cherry picked from commit 7c1f8fc) * [Bug][Workspace] Add permission validation at workspace detail page (#7435) * [Bug][Workspace] Add permission validate at workspace detail page * Changeset file for PR #7435 created/updated --------- (cherry picked from commit 45d34b5) * Revert "[Discover-next] data set picker (#7426)" (#7479) This reverts commit 6a079d3. --------- (cherry picked from commit 0515fb2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: SuZhou-Joe <suzhou@amazon.com> Co-authored-by: yuboluo <yubonluo@amazon.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> Co-authored-by: Sean Li <lnse@amazon.com>
|
Manual backport was done in #7477 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to introduce a new Nav bar in Discover that would contain the Date Picker as well as the Navigation links that are currently part of headers. The Navigation Links have been replaced with the corresponding Icons to provide a modern UX. These setting are currently controlled by query:enhancements:enabled Advanced Setting Flag and would be visible when the above flag is turned on.
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration