[discover-next][bug] add back data set navigator to control state #7492

kavilla · 2024-07-25T20:00:50Z

Description

Re-add the data set navigator upon other changes with passing tests.

Issues Resolved

n/a

Changelog

skip

Check List

All tests pass
- yarn test:jest
- yarn test:jest_integration
New functionality includes testing.
New functionality has been documented.
Update CHANGELOG.md
Commits are signed per the DCO using --signoff

This reverts commit 2208df9.

…#7464) * revert to read datasource id from index pattern Signed-off-by: Joshua Li <joshuali925@gmail.com> * add dataset mock to query mock Signed-off-by: Joshua Li <joshuali925@gmail.com> * update query assist to use dataset manager Signed-off-by: Joshua Li <joshuali925@gmail.com> * use selected dataset state instead of relying on rerender Signed-off-by: Joshua Li <joshuali925@gmail.com> * remove skip 1 in dataset observable Signed-off-by: Joshua Li <joshuali925@gmail.com> * update dataset_manager tests Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com>

* Antlr autocomplete (#7159) * dql grammar with rudamentary testing parser Signed-off-by: Paul Sebastian <paulstn@amazon.com> * show suggestion of fields depending on current index pattern Signed-off-by: Paul Sebastian <paulstn@amazon.com> * basic code completion with fields populated Signed-off-by: Paul Sebastian <paulstn@amazon.com> * updated grammar and generated for better group handling Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add ignored tokens Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove console logs Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * dql Antlr autocomplete (#7160) * re-add provider for sql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added temporary fix for language providor to appear for more than one language Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove EOF in parser to fix suggestions Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use custom version of cursor token index for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implemented value suggestions based on field Signed-off-by: Paul Sebastian <paulstn@amazon.com> * set param type Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update grouping grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix grammar for dots in field and value term search with spaces Signed-off-by: Paul Sebastian <paulstn@amazon.com> * value suggestions match field to avoid failing api call and to find assc keyword field Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update value suggestions from partially formed value Signed-off-by: Paul Sebastian <paulstn@amazon.com> * refactor value suggestions and change fieldval listener to visitor Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implement value suggestions within phrases Signed-off-by: Paul Sebastian <paulstn@amazon.com> * make grammar more readable Signed-off-by: Paul Sebastian <paulstn@amazon.com> * rename grammar parser rules Signed-off-by: Paul Sebastian <paulstn@amazon.com> * bring back minimal autocomplete optimized grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * enable partially complete value suggestion for value groups Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove number as lexer rule Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix cursor import and clean up Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix completion item range to be current word Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update cursor to use monaco position Signed-off-by: Paul Sebastian <paulstn@amazon.com> * cursor index to use position directly Signed-off-by: Paul Sebastian <paulstn@amazon.com> * move language registration into render function to handle new languages Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include auto closing quotes and parenthesis for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * rename generated file Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include single line editor closing pairs Signed-off-by: Paul Sebastian <paulstn@amazon.com> * Changeset file for PR #7391 created/updated * add license and fix linting Signed-off-by: Paul Sebastian <paulstn@amazon.com> * modify grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add tests for fields and keywords Signed-off-by: Paul Sebastian <paulstn@amazon.com> * move dql test constants to separate file Signed-off-by: Paul Sebastian <paulstn@amazon.com> * pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update an import Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use updated dataset for index pattern Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove console log Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

…et navigator (#7489) * [tests][discover-next] update the tests and async nature of the dataset manager Address test failures related to the dataset navigator. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * bad fingers accidentally hit the x button Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

github-actions · 2024-07-25T20:01:22Z

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 7492.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

github-actions · 2024-07-25T20:02:26Z

❌ Changeset File Not Added Yet

Please ensure manual commit for changeset file 7492.yml under folder changelogs/fragments to complete this PR. File still missing.

paulstn · 2024-07-26T22:53:49Z

src/plugins/data/public/antlr/opensearch_sql/code_completion.ts

@@ -86,7 +85,7 @@ export const getSuggestions = async ({
          tableNames,
          suggestions.suggestValuesForColumn as string,
          api,
-          connectionService
+          services


might need to remove these lines from here, since the other autocomplete prs were removed from this branch. this change was added in this commit, would only need to revert the changes done on this file: bf057f2#diff-f67c8b1b68c9ae8eeb8ea7d7dea38e59d32b7738dec7c9db5763cf74b96aa92fR46

sejli

Just some nits, think most of it is good.

sejli · 2024-07-26T22:25:18Z

src/plugins/data/common/search/opensearch_search/types.ts

-  /**
-   * Use this option to enable support for async.
-   */
-  isAsync?: boolean;


Did we put this somewhere else?

sejli · 2024-07-26T22:33:37Z

src/plugins/data/public/ui/query_editor/query_editor.tsx

-      incomplete: false,
-    };
-  };
+  // provideCompletionItems = async (


Could probably remove these comments in this file

sejli · 2024-07-26T23:10:22Z

src/plugins/discover/public/application/view_components/utils/use_index_pattern.ts

+  );
+
+  useEffect(() => {
+    if (isQueryEnhancementEnabled) {


Nit: single if here?

if ( isQueryEnhancementsEnabled && dataset && dataSet.type === SIMPLE_DATA_SET_TYPES.INDEX_PATTERN ) { fetchIndexPatternDetails(dataSet.id).then((ip) => setIndexPattern(ip)); }

sejli · 2024-07-26T23:11:50Z

src/plugins/discover/public/application/view_components/utils/use_index_pattern.ts

+    if (!isQueryEnhancementEnabled) {
+      if (!indexPatternIdFromState) {
+        data.indexPatterns.getCache().then((indexPatternList) => {
+          const newId = getIndexPatternId('', indexPatternList, uiSettings.get('defaultIndex'));


What if there's no defaultIndex?

ashwin-pc · 2024-07-26T22:57:11Z

src/plugins/data/public/ui/types.ts

+  /**
+   * @experimental - Subject to change
+   */


This is in the wrong place

ashwin-pc · 2024-07-26T23:17:53Z

src/plugins/query_enhancements/server/routes/data_source_connection/routes.ts

@@ -18,7 +17,7 @@ export function registerDataSourceConnectionsRoutes(router: IRouter) {
    },
    async (context, request, response) => {
      const fields = ['id', 'title', 'auth.type'];
-      const resp = await context.core.savedObjects.client.find<DataSourceAttributes>({
+      const resp = await context.core.savedObjects.client.find({


Why did we remove this type?

ashwin-pc · 2024-07-26T23:19:10Z

src/plugins/query_enhancements/public/services/connections_service.ts

Do we still need this service? or is this the fast follow that @mengweieric was mentioning that we need to remove?

yea, this is the one I'm talking about, basically we need this PR but got reverted: #7463, can we add it back if no tests or functions are breaking due to this PR

github-actions · 2024-07-26T23:34:01Z

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "feat". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

github-actions · 2024-07-26T23:37:51Z

❌ Changeset File Must Not Exist With Skip Entry

Changeset file 7492.yml under folder changelogs/fragments must not exist if ##Changelog section in PR description includes a "skip" entry option. Please remove the changeset file and try again.

ashwin-pc

Reapproving after adding the changeset

) * Revert "Revert "[Discover-next] data set picker (#7426)" (#7479)" This reverts commit 2208df9. * fix(query assist): update reading data source id from dataset manager (#7464) * revert to read datasource id from index pattern Signed-off-by: Joshua Li <joshuali925@gmail.com> * add dataset mock to query mock Signed-off-by: Joshua Li <joshuali925@gmail.com> * update query assist to use dataset manager Signed-off-by: Joshua Li <joshuali925@gmail.com> * use selected dataset state instead of relying on rerender Signed-off-by: Joshua Li <joshuali925@gmail.com> * remove skip 1 in dataset observable Signed-off-by: Joshua Li <joshuali925@gmail.com> * update dataset_manager tests Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> * [Auto Suggest] DQL autosuggest with ANTLR (#7467) * Antlr autocomplete (#7159) * dql grammar with rudamentary testing parser Signed-off-by: Paul Sebastian <paulstn@amazon.com> * show suggestion of fields depending on current index pattern Signed-off-by: Paul Sebastian <paulstn@amazon.com> * basic code completion with fields populated Signed-off-by: Paul Sebastian <paulstn@amazon.com> * updated grammar and generated for better group handling Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add ignored tokens Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove console logs Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * dql Antlr autocomplete (#7160) * re-add provider for sql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added temporary fix for language providor to appear for more than one language Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove EOF in parser to fix suggestions Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use custom version of cursor token index for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implemented value suggestions based on field Signed-off-by: Paul Sebastian <paulstn@amazon.com> * set param type Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update grouping grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix grammar for dots in field and value term search with spaces Signed-off-by: Paul Sebastian <paulstn@amazon.com> * value suggestions match field to avoid failing api call and to find assc keyword field Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update value suggestions from partially formed value Signed-off-by: Paul Sebastian <paulstn@amazon.com> * refactor value suggestions and change fieldval listener to visitor Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implement value suggestions within phrases Signed-off-by: Paul Sebastian <paulstn@amazon.com> * make grammar more readable Signed-off-by: Paul Sebastian <paulstn@amazon.com> * rename grammar parser rules Signed-off-by: Paul Sebastian <paulstn@amazon.com> * bring back minimal autocomplete optimized grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * enable partially complete value suggestion for value groups Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove number as lexer rule Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix cursor import and clean up Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix completion item range to be current word Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update cursor to use monaco position Signed-off-by: Paul Sebastian <paulstn@amazon.com> * cursor index to use position directly Signed-off-by: Paul Sebastian <paulstn@amazon.com> * move language registration into render function to handle new languages Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include auto closing quotes and parenthesis for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * rename generated file Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include single line editor closing pairs Signed-off-by: Paul Sebastian <paulstn@amazon.com> * Changeset file for PR #7391 created/updated * add license and fix linting Signed-off-by: Paul Sebastian <paulstn@amazon.com> * modify grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add tests for fields and keywords Signed-off-by: Paul Sebastian <paulstn@amazon.com> * move dql test constants to separate file Signed-off-by: Paul Sebastian <paulstn@amazon.com> * pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update an import Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use updated dataset for index pattern Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove console log Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [tests][discover-next] update the tests and async nature of the dataset navigator (#7489) * [tests][discover-next] update the tests and async nature of the dataset manager Address test failures related to the dataset navigator. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * bad fingers accidentally hit the x button Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [DataSet Navigator] Rewire S3 components (#7470) * rewiring databases back into navigator Signed-off-by: Sean Li <lnse@amazon.com> * fixing async query support Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> * Fix UI and detection of external data source in query assist (#7494) * fix(queryEditorExtensions): use dataset manager to determine external datasource Remove datasource and indexpattern since they are no longer the source of truth after dataset manager is added, and they are not used in query enhancement plugin. Signed-off-by: Joshua Li <joshuali925@gmail.com> * fix(queryAssist): enable click to change language in banner Signed-off-by: Joshua Li <joshuali925@gmail.com> * fix(queryAssist): hide query assist bar if editor is collapsed Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> * pass in index patterns Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (#7463) * add tests for sql autocomplete rule processing Signed-off-by: Eric <menwe@amazon.com> * refer to monaco type directly Signed-off-by: Eric <menwe@amazon.com> * remove unnecessary antlr auto generated files Signed-off-by: Eric <menwe@amazon.com> * inital adoption of dataSet manager Signed-off-by: Eric <menwe@amazon.com> * mds support Signed-off-by: Eric <menwe@amazon.com> * remove test that are failed due to adopting dataSet manager Signed-off-by: Eric <menwe@amazon.com> * add changelog Signed-off-by: Eric <menwe@amazon.com> * fix(query assist): update reading data source id from dataset manager (#7464) * revert to read datasource id from index pattern Signed-off-by: Joshua Li <joshuali925@gmail.com> * add dataset mock to query mock Signed-off-by: Joshua Li <joshuali925@gmail.com> * update query assist to use dataset manager Signed-off-by: Joshua Li <joshuali925@gmail.com> * use selected dataset state instead of relying on rerender Signed-off-by: Joshua Li <joshuali925@gmail.com> * remove skip 1 in dataset observable Signed-off-by: Joshua Li <joshuali925@gmail.com> * update dataset_manager tests Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> * update utils Signed-off-by: Eric <menwe@amazon.com> * keep with observable and remove values suggestion Signed-off-by: Eric <menwe@amazon.com> * update unit tests Signed-off-by: Eric <menwe@amazon.com> * [Auto Suggest] DQL autosuggest with ANTLR (#7467) * Antlr autocomplete (#7159) * dql grammar with rudamentary testing parser Signed-off-by: Paul Sebastian <paulstn@amazon.com> * show suggestion of fields depending on current index pattern Signed-off-by: Paul Sebastian <paulstn@amazon.com> * basic code completion with fields populated Signed-off-by: Paul Sebastian <paulstn@amazon.com> * updated grammar and generated for better group handling Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add ignored tokens Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove console logs Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * dql Antlr autocomplete (#7160) * re-add provider for sql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added temporary fix for language providor to appear for more than one language Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove EOF in parser to fix suggestions Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use custom version of cursor token index for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implemented value suggestions based on field Signed-off-by: Paul Sebastian <paulstn@amazon.com> * set param type Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update grouping grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix grammar for dots in field and value term search with spaces Signed-off-by: Paul Sebastian <paulstn@amazon.com> * value suggestions match field to avoid failing api call and to find assc keyword field Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update value suggestions from partially formed value Signed-off-by: Paul Sebastian <paulstn@amazon.com> * refactor value suggestions and change fieldval listener to visitor Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implement value suggestions within phrases Signed-off-by: Paul Sebastian <paulstn@amazon.com> * make grammar more readable Signed-off-by: Paul Sebastian <paulstn@amazon.com> * rename grammar parser rules Signed-off-by: Paul Sebastian <paulstn@amazon.com> * bring back minimal autocomplete optimized grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * enable partially complete value suggestion for value groups Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove number as lexer rule Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix cursor import and clean up Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix completion item range to be current word Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update cursor to use monaco position Signed-off-by: Paul Sebastian <paulstn@amazon.com> * cursor index to use position directly Signed-off-by: Paul Sebastian <paulstn@amazon.com> * move language registration into render function to handle new languages Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include auto closing quotes and parenthesis for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * rename generated file Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include single line editor closing pairs Signed-off-by: Paul Sebastian <paulstn@amazon.com> * Changeset file for PR #7391 created/updated * add license and fix linting Signed-off-by: Paul Sebastian <paulstn@amazon.com> * modify grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add tests for fields and keywords Signed-off-by: Paul Sebastian <paulstn@amazon.com> * move dql test constants to separate file Signed-off-by: Paul Sebastian <paulstn@amazon.com> * pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update an import Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use updated dataset for index pattern Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove console log Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [tests][discover-next] update the tests and async nature of the dataset navigator (#7489) * [tests][discover-next] update the tests and async nature of the dataset manager Address test failures related to the dataset navigator. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * bad fingers accidentally hit the x button Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * resolve conflicts Signed-off-by: Eric <menwe@amazon.com> * fix one minor linting Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Eric Wei <menwe@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> * More styling on query enhancement UI styling (#7496) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Auto Suggest] DQL Updates (#7498) * update code completion to not return for visualize Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update types to match completionitemkind Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix some typing issues Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * delete manual changelogs Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixing sessionId support Signed-off-by: Sean Li <lnse@amazon.com> * remove height Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Revert "[Auto Suggest] DQL Updates (#7498)" This reverts commit 27a74ab. * Revert "[Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (#7463)" This reverts commit 9f68352. * Revert "[Auto Suggest] DQL autosuggest with ANTLR (#7467)" This reverts commit 74b03e9. * fixing typing issue Signed-off-by: Sean Li <lnse@amazon.com> * remove unused export Signed-off-by: Sean Li <lnse@amazon.com> * fix texts and some state mgmt Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix file Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * more clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * default to false Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * only push the set with enhancements Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix two tests Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * render hell Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * test update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * passing in settings Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add changelog Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Sean Li <lnse@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> (cherry picked from commit 3168283) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

) (#7532) * Revert "Revert "[Discover-next] data set picker (#7426)" (#7479)" This reverts commit 2208df9. * fix(query assist): update reading data source id from dataset manager (#7464) * revert to read datasource id from index pattern * add dataset mock to query mock * update query assist to use dataset manager * use selected dataset state instead of relying on rerender * remove skip 1 in dataset observable * update dataset_manager tests --------- * [Auto Suggest] DQL autosuggest with ANTLR (#7467) * Antlr autocomplete (#7159) * dql grammar with rudamentary testing parser * show suggestion of fields depending on current index pattern * basic code completion with fields populated * updated grammar and generated for better group handling * add ignored tokens * remove console logs --------- * dql Antlr autocomplete (#7160) * re-add provider for sql * added temporary fix for language providor to appear for more than one language --------- * remove EOF in parser to fix suggestions * use custom version of cursor token index for dql * implemented value suggestions based on field * set param type * update grouping grammar * fix grammar for dots in field and value term search with spaces * value suggestions match field to avoid failing api call and to find assc keyword field * update value suggestions from partially formed value * refactor value suggestions and change fieldval listener to visitor * implement value suggestions within phrases * make grammar more readable * rename grammar parser rules * bring back minimal autocomplete optimized grammar * enable partially complete value suggestion for value groups * remove number as lexer rule * fix cursor import and clean up * fix completion item range to be current word * update cursor to use monaco position * cursor index to use position directly * move language registration into render function to handle new languages * include auto closing quotes and parenthesis for dql * rename generated file * include single line editor closing pairs * Changeset file for PR #7391 created/updated * add license and fix linting * modify grammar * add tests for fields and keywords * move dql test constants to separate file * pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position * update an import * use updated dataset for index pattern * remove console log --------- * [tests][discover-next] update the tests and async nature of the dataset navigator (#7489) * [tests][discover-next] update the tests and async nature of the dataset manager Address test failures related to the dataset navigator. * bad fingers accidentally hit the x button --------- * update snapshot * [DataSet Navigator] Rewire S3 components (#7470) * rewiring databases back into navigator * fixing async query support --------- * Fix UI and detection of external data source in query assist (#7494) * fix(queryEditorExtensions): use dataset manager to determine external datasource Remove datasource and indexpattern since they are no longer the source of truth after dataset manager is added, and they are not used in query enhancement plugin. * fix(queryAssist): enable click to change language in banner * fix(queryAssist): hide query assist bar if editor is collapsed --------- * pass in index patterns * [Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (#7463) * add tests for sql autocomplete rule processing * refer to monaco type directly * remove unnecessary antlr auto generated files * inital adoption of dataSet manager * mds support * remove test that are failed due to adopting dataSet manager * add changelog * fix(query assist): update reading data source id from dataset manager (#7464) * revert to read datasource id from index pattern * add dataset mock to query mock * update query assist to use dataset manager * use selected dataset state instead of relying on rerender * remove skip 1 in dataset observable * update dataset_manager tests --------- * update utils * keep with observable and remove values suggestion * update unit tests * [Auto Suggest] DQL autosuggest with ANTLR (#7467) * Antlr autocomplete (#7159) * dql grammar with rudamentary testing parser * show suggestion of fields depending on current index pattern * basic code completion with fields populated * updated grammar and generated for better group handling * add ignored tokens * remove console logs --------- * dql Antlr autocomplete (#7160) * re-add provider for sql * added temporary fix for language providor to appear for more than one language --------- * remove EOF in parser to fix suggestions * use custom version of cursor token index for dql * implemented value suggestions based on field * set param type * update grouping grammar * fix grammar for dots in field and value term search with spaces * value suggestions match field to avoid failing api call and to find assc keyword field * update value suggestions from partially formed value * refactor value suggestions and change fieldval listener to visitor * implement value suggestions within phrases * make grammar more readable * rename grammar parser rules * bring back minimal autocomplete optimized grammar * enable partially complete value suggestion for value groups * remove number as lexer rule * fix cursor import and clean up * fix completion item range to be current word * update cursor to use monaco position * cursor index to use position directly * move language registration into render function to handle new languages * include auto closing quotes and parenthesis for dql * rename generated file * include single line editor closing pairs * Changeset file for PR #7391 created/updated * add license and fix linting * modify grammar * add tests for fields and keywords * move dql test constants to separate file * pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position * update an import * use updated dataset for index pattern * remove console log --------- * [tests][discover-next] update the tests and async nature of the dataset navigator (#7489) * [tests][discover-next] update the tests and async nature of the dataset manager Address test failures related to the dataset navigator. * bad fingers accidentally hit the x button --------- * resolve conflicts * fix one minor linting --------- * More styling on query enhancement UI styling (#7496) * [Auto Suggest] DQL Updates (#7498) * update code completion to not return for visualize * update types to match completionitemkind --------- * fix some typing issues * delete manual changelogs * fixing sessionId support * remove height * Revert "[Auto Suggest] DQL Updates (#7498)" This reverts commit 27a74ab. * Revert "[Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (#7463)" This reverts commit 9f68352. * Revert "[Auto Suggest] DQL autosuggest with ANTLR (#7467)" This reverts commit 74b03e9. * fixing typing issue * remove unused export * fix texts and some state mgmt * fix file * update snapshot * more clean up * default to false * only push the set with enhancements * fix two tests * render hell * test update * passing in settings * add changelog --------- (cherry picked from commit 3168283) Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Sean Li <lnse@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>

After the following PRs: #7492, #7546, #7540 this commit added skip(1) back to dataset manager observable: fef6156, we need to revert changes done in fix(query assist): update reading data source id from dataset manager #7464 (comment) revert dataset manager observable usage in query assist to support skip(1) revert dataset manager tests [Discover Next] Fixes Discover styles #7546 removed query editor header div, this PR adds it back to enable query editor extensions Signed-off-by: Joshua Li <joshuali925@gmail.com>

After the following PRs: opensearch-project#7492, opensearch-project#7546, opensearch-project#7540 this commit added skip(1) back to dataset manager observable: fef6156, we need to revert changes done in fix(query assist): update reading data source id from dataset manager opensearch-project#7464 (comment) revert dataset manager observable usage in query assist to support skip(1) revert dataset manager tests [Discover Next] Fixes Discover styles opensearch-project#7546 removed query editor header div, this PR adds it back to enable query editor extensions Signed-off-by: Joshua Li <joshuali925@gmail.com>

* [Discover 2.0] Updating fetch functions to include local cluster (#7542) * Update datasources fetch function to include local cluster * Check for duplicates when fetching external datasources (in the case local cluster is added as a datasource) * Clean up types in DataSetNavigator so items are displayed properly --------- Signed-off-by: Sean Li <lnse@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [discover-next][bug] add max height to dataset navigator and use memoization (#7540) * add max heigh. use memoization Signed-off-by: Kawika Avilla <kavilla414@gmail.com> almost working pretty nicely Signed-off-by: Kawika Avilla <kavilla414@gmail.com> a little bit better Signed-off-by: Kawika Avilla <kavilla414@gmail.com> its ok Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update mock Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update another mock Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix mock for extension Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * rebase fixes Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update script Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix initial load Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * Fix query assist for query editor (#7552) After the following PRs: #7492, #7546, #7540 this commit added skip(1) back to dataset manager observable: fef6156, we need to revert changes done in fix(query assist): update reading data source id from dataset manager #7464 (comment) revert dataset manager observable usage in query assist to support skip(1) revert dataset manager tests [Discover Next] Fixes Discover styles #7546 removed query editor header div, this PR adds it back to enable query editor extensions Signed-off-by: Joshua Li <joshuali925@gmail.com> * [Discover next] Fixes dataset navigator menu styling & search error toast (#7566) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Discover 2.0] Loading fix for databases (#7567) * add back in useeffect for loading databases Signed-off-by: Sean Li <lnse@amazon.com> * Changeset file for PR #7567 created/updated --------- Signed-off-by: Sean Li <lnse@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Sean Li <lnse@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>

…ensearch-project#7492) * Revert "Revert "[Discover-next] data set picker (opensearch-project#7426)" (opensearch-project#7479)" This reverts commit 2208df9. * fix(query assist): update reading data source id from dataset manager (opensearch-project#7464) * revert to read datasource id from index pattern Signed-off-by: Joshua Li <joshuali925@gmail.com> * add dataset mock to query mock Signed-off-by: Joshua Li <joshuali925@gmail.com> * update query assist to use dataset manager Signed-off-by: Joshua Li <joshuali925@gmail.com> * use selected dataset state instead of relying on rerender Signed-off-by: Joshua Li <joshuali925@gmail.com> * remove skip 1 in dataset observable Signed-off-by: Joshua Li <joshuali925@gmail.com> * update dataset_manager tests Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> * [Auto Suggest] DQL autosuggest with ANTLR (opensearch-project#7467) * Antlr autocomplete (opensearch-project#7159) * dql grammar with rudamentary testing parser Signed-off-by: Paul Sebastian <paulstn@amazon.com> * show suggestion of fields depending on current index pattern Signed-off-by: Paul Sebastian <paulstn@amazon.com> * basic code completion with fields populated Signed-off-by: Paul Sebastian <paulstn@amazon.com> * updated grammar and generated for better group handling Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add ignored tokens Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove console logs Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * dql Antlr autocomplete (opensearch-project#7160) * re-add provider for sql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added temporary fix for language providor to appear for more than one language Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove EOF in parser to fix suggestions Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use custom version of cursor token index for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implemented value suggestions based on field Signed-off-by: Paul Sebastian <paulstn@amazon.com> * set param type Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update grouping grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix grammar for dots in field and value term search with spaces Signed-off-by: Paul Sebastian <paulstn@amazon.com> * value suggestions match field to avoid failing api call and to find assc keyword field Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update value suggestions from partially formed value Signed-off-by: Paul Sebastian <paulstn@amazon.com> * refactor value suggestions and change fieldval listener to visitor Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implement value suggestions within phrases Signed-off-by: Paul Sebastian <paulstn@amazon.com> * make grammar more readable Signed-off-by: Paul Sebastian <paulstn@amazon.com> * rename grammar parser rules Signed-off-by: Paul Sebastian <paulstn@amazon.com> * bring back minimal autocomplete optimized grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * enable partially complete value suggestion for value groups Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove number as lexer rule Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix cursor import and clean up Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix completion item range to be current word Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update cursor to use monaco position Signed-off-by: Paul Sebastian <paulstn@amazon.com> * cursor index to use position directly Signed-off-by: Paul Sebastian <paulstn@amazon.com> * move language registration into render function to handle new languages Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include auto closing quotes and parenthesis for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * rename generated file Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include single line editor closing pairs Signed-off-by: Paul Sebastian <paulstn@amazon.com> * Changeset file for PR opensearch-project#7391 created/updated * add license and fix linting Signed-off-by: Paul Sebastian <paulstn@amazon.com> * modify grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add tests for fields and keywords Signed-off-by: Paul Sebastian <paulstn@amazon.com> * move dql test constants to separate file Signed-off-by: Paul Sebastian <paulstn@amazon.com> * pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update an import Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use updated dataset for index pattern Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove console log Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [tests][discover-next] update the tests and async nature of the dataset navigator (opensearch-project#7489) * [tests][discover-next] update the tests and async nature of the dataset manager Address test failures related to the dataset navigator. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * bad fingers accidentally hit the x button Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [DataSet Navigator] Rewire S3 components (opensearch-project#7470) * rewiring databases back into navigator Signed-off-by: Sean Li <lnse@amazon.com> * fixing async query support Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> * Fix UI and detection of external data source in query assist (opensearch-project#7494) * fix(queryEditorExtensions): use dataset manager to determine external datasource Remove datasource and indexpattern since they are no longer the source of truth after dataset manager is added, and they are not used in query enhancement plugin. Signed-off-by: Joshua Li <joshuali925@gmail.com> * fix(queryAssist): enable click to change language in banner Signed-off-by: Joshua Li <joshuali925@gmail.com> * fix(queryAssist): hide query assist bar if editor is collapsed Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> * pass in index patterns Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (opensearch-project#7463) * add tests for sql autocomplete rule processing Signed-off-by: Eric <menwe@amazon.com> * refer to monaco type directly Signed-off-by: Eric <menwe@amazon.com> * remove unnecessary antlr auto generated files Signed-off-by: Eric <menwe@amazon.com> * inital adoption of dataSet manager Signed-off-by: Eric <menwe@amazon.com> * mds support Signed-off-by: Eric <menwe@amazon.com> * remove test that are failed due to adopting dataSet manager Signed-off-by: Eric <menwe@amazon.com> * add changelog Signed-off-by: Eric <menwe@amazon.com> * fix(query assist): update reading data source id from dataset manager (opensearch-project#7464) * revert to read datasource id from index pattern Signed-off-by: Joshua Li <joshuali925@gmail.com> * add dataset mock to query mock Signed-off-by: Joshua Li <joshuali925@gmail.com> * update query assist to use dataset manager Signed-off-by: Joshua Li <joshuali925@gmail.com> * use selected dataset state instead of relying on rerender Signed-off-by: Joshua Li <joshuali925@gmail.com> * remove skip 1 in dataset observable Signed-off-by: Joshua Li <joshuali925@gmail.com> * update dataset_manager tests Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> * update utils Signed-off-by: Eric <menwe@amazon.com> * keep with observable and remove values suggestion Signed-off-by: Eric <menwe@amazon.com> * update unit tests Signed-off-by: Eric <menwe@amazon.com> * [Auto Suggest] DQL autosuggest with ANTLR (opensearch-project#7467) * Antlr autocomplete (opensearch-project#7159) * dql grammar with rudamentary testing parser Signed-off-by: Paul Sebastian <paulstn@amazon.com> * show suggestion of fields depending on current index pattern Signed-off-by: Paul Sebastian <paulstn@amazon.com> * basic code completion with fields populated Signed-off-by: Paul Sebastian <paulstn@amazon.com> * updated grammar and generated for better group handling Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add ignored tokens Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove console logs Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * dql Antlr autocomplete (opensearch-project#7160) * re-add provider for sql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added temporary fix for language providor to appear for more than one language Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove EOF in parser to fix suggestions Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use custom version of cursor token index for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implemented value suggestions based on field Signed-off-by: Paul Sebastian <paulstn@amazon.com> * set param type Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update grouping grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix grammar for dots in field and value term search with spaces Signed-off-by: Paul Sebastian <paulstn@amazon.com> * value suggestions match field to avoid failing api call and to find assc keyword field Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update value suggestions from partially formed value Signed-off-by: Paul Sebastian <paulstn@amazon.com> * refactor value suggestions and change fieldval listener to visitor Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implement value suggestions within phrases Signed-off-by: Paul Sebastian <paulstn@amazon.com> * make grammar more readable Signed-off-by: Paul Sebastian <paulstn@amazon.com> * rename grammar parser rules Signed-off-by: Paul Sebastian <paulstn@amazon.com> * bring back minimal autocomplete optimized grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * enable partially complete value suggestion for value groups Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove number as lexer rule Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix cursor import and clean up Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix completion item range to be current word Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update cursor to use monaco position Signed-off-by: Paul Sebastian <paulstn@amazon.com> * cursor index to use position directly Signed-off-by: Paul Sebastian <paulstn@amazon.com> * move language registration into render function to handle new languages Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include auto closing quotes and parenthesis for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * rename generated file Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include single line editor closing pairs Signed-off-by: Paul Sebastian <paulstn@amazon.com> * Changeset file for PR opensearch-project#7391 created/updated * add license and fix linting Signed-off-by: Paul Sebastian <paulstn@amazon.com> * modify grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add tests for fields and keywords Signed-off-by: Paul Sebastian <paulstn@amazon.com> * move dql test constants to separate file Signed-off-by: Paul Sebastian <paulstn@amazon.com> * pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update an import Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use updated dataset for index pattern Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove console log Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [tests][discover-next] update the tests and async nature of the dataset navigator (opensearch-project#7489) * [tests][discover-next] update the tests and async nature of the dataset manager Address test failures related to the dataset navigator. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * bad fingers accidentally hit the x button Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * resolve conflicts Signed-off-by: Eric <menwe@amazon.com> * fix one minor linting Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Eric Wei <menwe@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> * More styling on query enhancement UI styling (opensearch-project#7496) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Auto Suggest] DQL Updates (opensearch-project#7498) * update code completion to not return for visualize Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update types to match completionitemkind Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix some typing issues Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * delete manual changelogs Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixing sessionId support Signed-off-by: Sean Li <lnse@amazon.com> * remove height Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Revert "[Auto Suggest] DQL Updates (opensearch-project#7498)" This reverts commit 27a74ab. * Revert "[Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (opensearch-project#7463)" This reverts commit 9f68352. * Revert "[Auto Suggest] DQL autosuggest with ANTLR (opensearch-project#7467)" This reverts commit 74b03e9. * fixing typing issue Signed-off-by: Sean Li <lnse@amazon.com> * remove unused export Signed-off-by: Sean Li <lnse@amazon.com> * fix texts and some state mgmt Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix file Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * more clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * default to false Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * only push the set with enhancements Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix two tests Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * render hell Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * test update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * passing in settings Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add changelog Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Sean Li <lnse@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>

After the following PRs: opensearch-project#7492, opensearch-project#7546, opensearch-project#7540 this commit added skip(1) back to dataset manager observable: fef6156, we need to revert changes done in fix(query assist): update reading data source id from dataset manager opensearch-project#7464 (comment) revert dataset manager observable usage in query assist to support skip(1) revert dataset manager tests [Discover Next] Fixes Discover styles opensearch-project#7546 removed query editor header div, this PR adds it back to enable query editor extensions Signed-off-by: Joshua Li <joshuali925@gmail.com>

kavilla and others added 4 commits July 25, 2024 19:55

Revert "Revert "[Discover-next] data set picker (#7426)" (#7479)"

8a5faff

This reverts commit 2208df9.

kavilla requested review from ananzh, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, zhongnansu, manasvinibs, ZilongX, Flyingliuhub, curq, bandinib-amzn, SuZhou-Joe, ruanyl, BionIT, xinruiba, zhyuanqi, mengweieric, LDrago27, virajsanghvi and sejli as code owners July 25, 2024 20:00

github-actions bot added the distinguished-contributor label Jul 25, 2024

github-actions bot added the failed changeset label Jul 25, 2024

kavilla changed the title ~~Feature/discover 2.0 1~~ [discover-next] data set navigator Jul 25, 2024

abbyhu2000 previously approved these changes Jul 26, 2024

View reviewed changes

paulstn reviewed Jul 26, 2024

View reviewed changes

sejli previously approved these changes Jul 26, 2024

View reviewed changes

ashwin-pc previously approved these changes Jul 26, 2024

View reviewed changes

kavilla removed the failed changeset label Jul 26, 2024

github-actions bot added the failed changeset label Jul 26, 2024

add changelog

6ff7e26

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

kavilla dismissed stale reviews from ashwin-pc, sejli, and abbyhu2000 via 6ff7e26 July 26, 2024 23:37

kavilla added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Jul 26, 2024

ashwin-pc approved these changes Jul 26, 2024

View reviewed changes

abbyhu2000 approved these changes Jul 26, 2024

View reviewed changes

sejli approved these changes Jul 26, 2024

View reviewed changes

kavilla merged commit 3168283 into main Jul 26, 2024
53 of 57 checks passed

opensearch-trigger-bot bot mentioned this pull request Jul 26, 2024

[Backport 2.x] [discover-next][bug] add back data set navigator to control state #7532

Merged

opensearch-trigger-bot bot mentioned this pull request Jul 26, 2024

[Backport 2.16] [discover-next][bug] add back data set navigator to control state #7533

Closed

kavilla deleted the feature/discover-2.0-1 branch September 13, 2024 21:00

AMoo-Miki added the in-next label Sep 27, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[discover-next][bug] add back data set navigator to control state #7492

[discover-next][bug] add back data set navigator to control state #7492

kavilla commented Jul 25, 2024 •

edited

Loading

github-actions bot commented Jul 25, 2024

github-actions bot commented Jul 25, 2024

paulstn Jul 26, 2024

sejli left a comment

sejli Jul 26, 2024

sejli Jul 26, 2024

sejli Jul 26, 2024

sejli Jul 26, 2024

ashwin-pc Jul 26, 2024

ashwin-pc Jul 26, 2024

ashwin-pc Jul 26, 2024

mengweieric Jul 26, 2024 •

edited

Loading

github-actions bot commented Jul 26, 2024

github-actions bot commented Jul 26, 2024

ashwin-pc left a comment

[discover-next][bug] add back data set navigator to control state #7492

[discover-next][bug] add back data set navigator to control state #7492

Conversation

kavilla commented Jul 25, 2024 • edited Loading

Description

Issues Resolved

Changelog

Check List

github-actions bot commented Jul 25, 2024

ℹ️ Manual Changeset Creation Reminder

github-actions bot commented Jul 25, 2024

❌ Changeset File Not Added Yet

Choose a reason for hiding this comment

sejli left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mengweieric Jul 26, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jul 26, 2024

❌ Invalid Prefix For Manual Changeset Creation

github-actions bot commented Jul 26, 2024

❌ Changeset File Must Not Exist With Skip Entry

ashwin-pc left a comment

Choose a reason for hiding this comment

kavilla commented Jul 25, 2024 •

edited

Loading

mengweieric Jul 26, 2024 •

edited

Loading