[Backport 2.x] [discover-next][bug] add back data set navigator to control state #7532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
) * Revert "Revert "[Discover-next] data set picker (#7426)" (#7479)" This reverts commit 2208df9. * fix(query assist): update reading data source id from dataset manager (#7464) * revert to read datasource id from index pattern Signed-off-by: Joshua Li <joshuali925@gmail.com> * add dataset mock to query mock Signed-off-by: Joshua Li <joshuali925@gmail.com> * update query assist to use dataset manager Signed-off-by: Joshua Li <joshuali925@gmail.com> * use selected dataset state instead of relying on rerender Signed-off-by: Joshua Li <joshuali925@gmail.com> * remove skip 1 in dataset observable Signed-off-by: Joshua Li <joshuali925@gmail.com> * update dataset_manager tests Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> * [Auto Suggest] DQL autosuggest with ANTLR (#7467) * Antlr autocomplete (#7159) * dql grammar with rudamentary testing parser Signed-off-by: Paul Sebastian <paulstn@amazon.com> * show suggestion of fields depending on current index pattern Signed-off-by: Paul Sebastian <paulstn@amazon.com> * basic code completion with fields populated Signed-off-by: Paul Sebastian <paulstn@amazon.com> * updated grammar and generated for better group handling Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add ignored tokens Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove console logs Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * dql Antlr autocomplete (#7160) * re-add provider for sql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added temporary fix for language providor to appear for more than one language Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove EOF in parser to fix suggestions Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use custom version of cursor token index for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implemented value suggestions based on field Signed-off-by: Paul Sebastian <paulstn@amazon.com> * set param type Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update grouping grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix grammar for dots in field and value term search with spaces Signed-off-by: Paul Sebastian <paulstn@amazon.com> * value suggestions match field to avoid failing api call and to find assc keyword field Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update value suggestions from partially formed value Signed-off-by: Paul Sebastian <paulstn@amazon.com> * refactor value suggestions and change fieldval listener to visitor Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implement value suggestions within phrases Signed-off-by: Paul Sebastian <paulstn@amazon.com> * make grammar more readable Signed-off-by: Paul Sebastian <paulstn@amazon.com> * rename grammar parser rules Signed-off-by: Paul Sebastian <paulstn@amazon.com> * bring back minimal autocomplete optimized grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * enable partially complete value suggestion for value groups Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove number as lexer rule Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix cursor import and clean up Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix completion item range to be current word Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update cursor to use monaco position Signed-off-by: Paul Sebastian <paulstn@amazon.com> * cursor index to use position directly Signed-off-by: Paul Sebastian <paulstn@amazon.com> * move language registration into render function to handle new languages Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include auto closing quotes and parenthesis for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * rename generated file Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include single line editor closing pairs Signed-off-by: Paul Sebastian <paulstn@amazon.com> * Changeset file for PR #7391 created/updated * add license and fix linting Signed-off-by: Paul Sebastian <paulstn@amazon.com> * modify grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add tests for fields and keywords Signed-off-by: Paul Sebastian <paulstn@amazon.com> * move dql test constants to separate file Signed-off-by: Paul Sebastian <paulstn@amazon.com> * pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update an import Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use updated dataset for index pattern Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove console log Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [tests][discover-next] update the tests and async nature of the dataset navigator (#7489) * [tests][discover-next] update the tests and async nature of the dataset manager Address test failures related to the dataset navigator. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * bad fingers accidentally hit the x button Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [DataSet Navigator] Rewire S3 components (#7470) * rewiring databases back into navigator Signed-off-by: Sean Li <lnse@amazon.com> * fixing async query support Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> * Fix UI and detection of external data source in query assist (#7494) * fix(queryEditorExtensions): use dataset manager to determine external datasource Remove datasource and indexpattern since they are no longer the source of truth after dataset manager is added, and they are not used in query enhancement plugin. Signed-off-by: Joshua Li <joshuali925@gmail.com> * fix(queryAssist): enable click to change language in banner Signed-off-by: Joshua Li <joshuali925@gmail.com> * fix(queryAssist): hide query assist bar if editor is collapsed Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> * pass in index patterns Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * [Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (#7463) * add tests for sql autocomplete rule processing Signed-off-by: Eric <menwe@amazon.com> * refer to monaco type directly Signed-off-by: Eric <menwe@amazon.com> * remove unnecessary antlr auto generated files Signed-off-by: Eric <menwe@amazon.com> * inital adoption of dataSet manager Signed-off-by: Eric <menwe@amazon.com> * mds support Signed-off-by: Eric <menwe@amazon.com> * remove test that are failed due to adopting dataSet manager Signed-off-by: Eric <menwe@amazon.com> * add changelog Signed-off-by: Eric <menwe@amazon.com> * fix(query assist): update reading data source id from dataset manager (#7464) * revert to read datasource id from index pattern Signed-off-by: Joshua Li <joshuali925@gmail.com> * add dataset mock to query mock Signed-off-by: Joshua Li <joshuali925@gmail.com> * update query assist to use dataset manager Signed-off-by: Joshua Li <joshuali925@gmail.com> * use selected dataset state instead of relying on rerender Signed-off-by: Joshua Li <joshuali925@gmail.com> * remove skip 1 in dataset observable Signed-off-by: Joshua Li <joshuali925@gmail.com> * update dataset_manager tests Signed-off-by: Joshua Li <joshuali925@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> * update utils Signed-off-by: Eric <menwe@amazon.com> * keep with observable and remove values suggestion Signed-off-by: Eric <menwe@amazon.com> * update unit tests Signed-off-by: Eric <menwe@amazon.com> * [Auto Suggest] DQL autosuggest with ANTLR (#7467) * Antlr autocomplete (#7159) * dql grammar with rudamentary testing parser Signed-off-by: Paul Sebastian <paulstn@amazon.com> * show suggestion of fields depending on current index pattern Signed-off-by: Paul Sebastian <paulstn@amazon.com> * basic code completion with fields populated Signed-off-by: Paul Sebastian <paulstn@amazon.com> * updated grammar and generated for better group handling Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add ignored tokens Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove console logs Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * dql Antlr autocomplete (#7160) * re-add provider for sql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * added temporary fix for language providor to appear for more than one language Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove EOF in parser to fix suggestions Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use custom version of cursor token index for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implemented value suggestions based on field Signed-off-by: Paul Sebastian <paulstn@amazon.com> * set param type Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update grouping grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix grammar for dots in field and value term search with spaces Signed-off-by: Paul Sebastian <paulstn@amazon.com> * value suggestions match field to avoid failing api call and to find assc keyword field Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update value suggestions from partially formed value Signed-off-by: Paul Sebastian <paulstn@amazon.com> * refactor value suggestions and change fieldval listener to visitor Signed-off-by: Paul Sebastian <paulstn@amazon.com> * implement value suggestions within phrases Signed-off-by: Paul Sebastian <paulstn@amazon.com> * make grammar more readable Signed-off-by: Paul Sebastian <paulstn@amazon.com> * rename grammar parser rules Signed-off-by: Paul Sebastian <paulstn@amazon.com> * bring back minimal autocomplete optimized grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * enable partially complete value suggestion for value groups Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove number as lexer rule Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix cursor import and clean up Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix completion item range to be current word Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update cursor to use monaco position Signed-off-by: Paul Sebastian <paulstn@amazon.com> * cursor index to use position directly Signed-off-by: Paul Sebastian <paulstn@amazon.com> * move language registration into render function to handle new languages Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include auto closing quotes and parenthesis for dql Signed-off-by: Paul Sebastian <paulstn@amazon.com> * rename generated file Signed-off-by: Paul Sebastian <paulstn@amazon.com> * include single line editor closing pairs Signed-off-by: Paul Sebastian <paulstn@amazon.com> * Changeset file for PR #7391 created/updated * add license and fix linting Signed-off-by: Paul Sebastian <paulstn@amazon.com> * modify grammar Signed-off-by: Paul Sebastian <paulstn@amazon.com> * add tests for fields and keywords Signed-off-by: Paul Sebastian <paulstn@amazon.com> * move dql test constants to separate file Signed-off-by: Paul Sebastian <paulstn@amazon.com> * pass core setup from autocomplete constructor to query sugg provider and utilize selectionEnd if no position Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update an import Signed-off-by: Paul Sebastian <paulstn@amazon.com> * use updated dataset for index pattern Signed-off-by: Paul Sebastian <paulstn@amazon.com> * remove console log Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> * [tests][discover-next] update the tests and async nature of the dataset navigator (#7489) * [tests][discover-next] update the tests and async nature of the dataset manager Address test failures related to the dataset navigator. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * bad fingers accidentally hit the x button Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * resolve conflicts Signed-off-by: Eric <menwe@amazon.com> * fix one minor linting Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Eric Wei <menwe@amazon.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Kawika Avilla <kavilla414@gmail.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> * More styling on query enhancement UI styling (#7496) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Auto Suggest] DQL Updates (#7498) * update code completion to not return for visualize Signed-off-by: Paul Sebastian <paulstn@amazon.com> * update types to match completionitemkind Signed-off-by: Paul Sebastian <paulstn@amazon.com> --------- Signed-off-by: Paul Sebastian <paulstn@amazon.com> * fix some typing issues Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * delete manual changelogs Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fixing sessionId support Signed-off-by: Sean Li <lnse@amazon.com> * remove height Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Revert "[Auto Suggest] DQL Updates (#7498)" This reverts commit 27a74ab. * Revert "[Auto Suggest] Add MDS Support Along with A Few Cleanup and tests (#7463)" This reverts commit 9f68352. * Revert "[Auto Suggest] DQL autosuggest with ANTLR (#7467)" This reverts commit 74b03e9. * fixing typing issue Signed-off-by: Sean Li <lnse@amazon.com> * remove unused export Signed-off-by: Sean Li <lnse@amazon.com> * fix texts and some state mgmt Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix file Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * update snapshot Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * more clean up Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * default to false Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * only push the set with enhancements Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * fix two tests Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * render hell Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * test update Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * passing in settings Signed-off-by: Kawika Avilla <kavilla414@gmail.com> * add changelog Signed-off-by: Kawika Avilla <kavilla414@gmail.com> --------- Signed-off-by: Joshua Li <joshuali925@gmail.com> Signed-off-by: Paul Sebastian <paulstn@amazon.com> Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Eric <menwe@amazon.com> Signed-off-by: Eric Wei <menwe@amazon.com> Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Co-authored-by: Joshua Li <joshuali925@gmail.com> Co-authored-by: Paul Sebastian <paulstn@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Sean Li <lnse@amazon.com> Co-authored-by: Eric Wei <menwe@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com> (cherry picked from commit 3168283) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi and
sejli
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
github-actions
bot
removed
the
Skip-Changelog
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7532 +/- ##
==========================================
- Coverage 64.21% 63.75% -0.46%
==========================================
Files 3614 3628 +14
Lines 78750 79488 +738
Branches 12446 12587 +141
==========================================
+ Hits 50569 50681 +112
- Misses 25131 25746 +615
- Partials 3050 3061 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kavilla
approved these changes
Jul 27, 2024
ashwin-pc
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 3168283 from #7492.