Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Workspace] Content menu picker in side bar and enable searching #7881

Merged
merged 12 commits into from
Sep 5, 2024
Merged

[Workspace] Content menu picker in side bar and enable searching #7881

merged 12 commits into from
Sep 5, 2024

Conversation

Qxisylolo
Copy link
Contributor

@Qxisylolo Qxisylolo commented Aug 28, 2024 •
edited
Loading

Description

In this pr, I update content menu picker in side bar and enable searching.

  1. the search bar is sticky, and the workspace is scrollable
  2. enable searching by workspace name.

Screenshot

  1. In a workspace
Screenshot 2024-09-05 at 13 45 02 Screenshot 2024-09-05 at 14 02 14
  1. enable searching
Screenshot 2024-09-05 at 13 45 05
  1. empty state
Screenshot 2024-09-05 at 13 47 02
  1. in the side bar
Screenshot 2024-09-05 at 13 45 41 Screenshot 2024-09-05 at 13 47 47

Changelog

  • feat: refactor content menu picker in side bar and enable searching

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 28, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#7881 created/updated
8f33838
@codecov Codecov
Copy link

codecov bot commented Aug 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.52%. Comparing base (84d5de3) to head (3009390).
Report is 90 commits behind head on main.

Files with missing lines Patch % Lines
...ublic/components/workspace_menu/workspace_menu.tsx 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7881   +/-   ##
=======================================
  Coverage   60.52%   60.52%           
=======================================
  Files        3728     3728           
  Lines       88297    88309   +12     
  Branches    13662    13666    +4     
=======================================
+ Hits        53439    53453   +14     
+ Misses      31603    31602    -1     
+ Partials     3255     3254    -1
Flag Coverage Δ
Linux_1 28.73% <96.55%> (+0.01%) ⬆️
Linux_2 56.24% <ø> (ø)
Linux_3 37.41% <ø> (+<0.01%) ⬆️
Linux_4 29.60% <ø> (ø)
Windows_1 28.75% <96.55%> (+0.01%) ⬆️
Windows_2 56.20% <ø> (ø)
Windows_3 37.41% <ø> (ø)
Windows_4 29.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Qxisylolo Qxisylolo force-pushed the feat/refractor-content-menu-picker-in-side-bar branch from 8f33838 to 0afaea9 Compare August 28, 2024 10:52
@Qxisylolo Qxisylolo changed the title [Workspace] refractor content menu picker in side bar and enable searching [Workspace] Style content menu picker in side bar and enable searching Aug 29, 2024
opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 29, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#7881 created/updated
8200975
@Qxisylolo Qxisylolo changed the title [Workspace] Style content menu picker in side bar and enable searching [Workspace] Content menu picker in side bar and enable searching Aug 29, 2024
@Qxisylolo Qxisylolo marked this pull request as ready for review August 29, 2024 01:41
@Qxisylolo Qxisylolo force-pushed the feat/refractor-content-menu-picker-in-side-bar branch from 50492da to 407184f Compare September 2, 2024 03:38
@Qxisylolo
01-feat/refractor-content-menu-picker-in-side-bar
1f36b87 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo
02-enable-associated-icon
00c0bfa 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo
03-update-side-bar
89e0e00 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo
04-fix-bugs
2a78511 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo
04-fix-bugs, add test
c9e22ea 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo
05-delete search
044f267 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo
06-delete search
fc8108e 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo
06-fix-bug
dd47fb0 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo Qxisylolo force-pushed the feat/refractor-content-menu-picker-in-side-bar branch from 811f37b to dd47fb0 Compare September 3, 2024 06:43
SuZhou-Joe
SuZhou-Joe previously approved these changes Sep 3, 2024
View reviewed changes
@Qxisylolo
07-fix-conflication
ac4d75f 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
opensearch-changeset-bot bot added a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Sep 5, 2024
@opensearch-changeset-bot
Changeset file for PR opensearch-project#7881 created/updated
41a4ef9
@Qxisylolo
07-fix-conflication-1
a77a6b5 
Signed-off-by: Qxisylolo <qianxisy@amazon.com>
@Qxisylolo Qxisylolo force-pushed the feat/refractor-content-menu-picker-in-side-bar branch from 41a4ef9 to a77a6b5 Compare September 5, 2024 05:55
@SuZhou-Joe
Copy link
Member

Thanks for the PR, good job!

@SuZhou-Joe
Copy link
Member

Run cypress tests (osd:ciGroup6) should be irrelevant to the code changes.

@SuZhou-Joe SuZhou-Joe merged commit a05c4a2 into opensearch-project:main Sep 5, 2024
66 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 5, 2024
@github-actions @opensearch-changeset-bot
[Workspace] Content menu picker in side bar and enable searching (#7881)
71ebe1d 
* 01-feat/refractor-content-menu-picker-in-side-bar

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* 02-enable-associated-icon

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* 03-update-side-bar

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* 04-fix-bugs

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* 04-fix-bugs, add test

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* 05-delete search

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* 06-delete search

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* 06-fix-bug

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* 07-fix-conflication-1

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* 07-fix-conflication-adjust-icon-size

Signed-off-by: Qxisylolo <qianxisy@amazon.com>

* Changeset file for PR #7881 created/updated

---------

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit a05c4a2)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 5, 2024
Merged
ruanyl pushed a commit that referenced this pull request Sep 5, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Workspace] Content menu picker in side bar and enable searching (#7881…
f29bc57 
…) (#8017)

* 01-feat/refractor-content-menu-picker-in-side-bar



* 02-enable-associated-icon



* 03-update-side-bar



* 04-fix-bugs



* 04-fix-bugs, add test



* 05-delete search



* 06-delete search



* 06-fix-bug



* 07-fix-conflication-1



* 07-fix-conflication-adjust-icon-size



* Changeset file for PR #7881 created/updated

---------



(cherry picked from commit a05c4a2)

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
@github-actions @opensearch-changeset-bot
[Workspace] Content menu picker in side bar and enable searching (#7881…
6b15eac 
…) (#8017)

* 01-feat/refractor-content-menu-picker-in-side-bar

* 02-enable-associated-icon

* 03-update-side-bar

* 04-fix-bugs

* 04-fix-bugs, add test

* 05-delete search

* 06-delete search

* 06-fix-bug

* 07-fix-conflication-1

* 07-fix-conflication-adjust-icon-size

* Changeset file for PR #7881 created/updated

---------

(cherry picked from commit a05c4a2)

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit f29bc57)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Sep 6, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
[Workspace] Content menu picker in side bar and enable searching (#7881…
55792b1 
…) (#8017) (#8049)

* 01-feat/refractor-content-menu-picker-in-side-bar

* 02-enable-associated-icon

* 03-update-side-bar

* 04-fix-bugs

* 04-fix-bugs, add test

* 05-delete search

* 06-delete search

* 06-fix-bug

* 07-fix-conflication-1

* 07-fix-conflication-adjust-icon-size

* Changeset file for PR #7881 created/updated

---------

(cherry picked from commit a05c4a2)





(cherry picked from commit f29bc57)

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raintygao raintygao raintygao left review comments

@SuZhou-Joe SuZhou-Joe SuZhou-Joe approved these changes

@ruanyl ruanyl ruanyl approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
backport 2.x in-next repeat-contributor v2.17.0 workspace
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Qxisylolo @SuZhou-Joe @ruanyl @raintygao @AMoo-Miki