Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.17] [Backport 2.x] [Workspace] Content menu picker in side bar and enable searching #8049

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport f29bc57 from #8017.

…) (#8017)

* 01-feat/refractor-content-menu-picker-in-side-bar

* 02-enable-associated-icon

* 03-update-side-bar

* 04-fix-bugs

* 04-fix-bugs, add test

* 05-delete search

* 06-delete search

* 06-fix-bug

* 07-fix-conflication-1

* 07-fix-conflication-adjust-icon-size

* Changeset file for PR #7881 created/updated

---------

(cherry picked from commit a05c4a2)

Signed-off-by: Qxisylolo <qianxisy@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit f29bc57)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

github-actions bot commented Sep 6, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Sep 6, 2024

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.58%. Comparing base (e35f80e) to head (6b15eac).
Report is 3 commits behind head on 2.17.

Files with missing lines Patch % Lines
...ublic/components/workspace_menu/workspace_menu.tsx 75.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             2.17    #8049      +/-   ##
==========================================
+ Coverage   60.56%   60.58%   +0.01%     
==========================================
  Files        3726     3726              
  Lines       88171    88183      +12     
  Branches    13630    13634       +4     
==========================================
+ Hits        53400    53424      +24     
+ Misses      31524    31514      -10     
+ Partials     3247     3245       -2     
Flag Coverage Δ
Linux_1 28.65% <96.55%> (+0.01%) ⬆️
Linux_2 56.35% <ø> (ø)
Linux_3 37.39% <ø> (ø)
Linux_4 29.74% <ø> (ø)
Windows_1 28.66% <96.55%> (+0.01%) ⬆️
Windows_2 56.31% <ø> (?)
Windows_3 37.40% <ø> (ø)
Windows_4 29.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit 55792b1 into 2.17 Sep 6, 2024
68 of 71 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset repeat-contributor v2.17.0 workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants