-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the HttpChannel trace termination in case of exceptions #10325
Conversation
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@Gaganjuneja please take a look, thank you |
Compatibility status:Checks if related components are compatible with change 5381e13 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git] |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Rebase? |
Looks good to me. Please take care of build :) |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #10325 +/- ##
============================================
- Coverage 71.15% 71.14% -0.01%
- Complexity 58247 58286 +39
============================================
Files 4831 4832 +1
Lines 274684 274696 +12
Branches 40026 40028 +2
============================================
- Hits 195443 195434 -9
- Misses 62884 62930 +46
+ Partials 16357 16332 -25
|
@andrross @dblock @kotwanikunal looking for review please, needs to be in |
Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit bddf0d3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…ch-project#10325) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ch-project#10325) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ch-project#10325) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Fix the HttpChannel trace termination in case of exceptions
Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.