Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the HttpChannel trace termination in case of exceptions #10325

Merged
merged 1 commit into from
Oct 3, 2023

Conversation

reta
Copy link
Collaborator

@reta reta commented Oct 2, 2023

Description

Fix the HttpChannel trace termination in case of exceptions

Related Issues

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta
Copy link
Collaborator Author

reta commented Oct 2, 2023

@Gaganjuneja please take a look, thank you

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Compatibility status:

Checks if related components are compatible with change 5381e13

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

@Poojita-Raj
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/26662/

* **CommitID:** [5381e13](https://github.com/opensearch-project/OpenSearch/commit/5381e138b45fc5c428907679536174692a227b0a)
  Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
  Is the failure [a flaky test](https://github.com/opensearch-project/OpenSearch/blob/main/DEVELOPER_GUIDE.md#flaky-tests) unrelated to your change?
FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of null.
> Could not resolve all task dependencies for configuration ':buildSrc:buildScriptClasspath'.
   > Could not resolve org.apache.rat:apache-rat:0.15.
     Required by:
         project :buildSrc
      > Could not resolve org.apache.rat:apache-rat:0.15.
         > Could not get resource 'https://repo.maven.apache.org/maven2/org/apache/rat/apache-rat/0.15/apache-rat-0.15.pom'.
            > Could not GET 'https://repo.maven.apache.org/maven2/org/apache/rat/apache-rat/0.15/apache-rat-0.15.pom'.
               > Read timed out

Rebase?

@Gaganjuneja
Copy link
Contributor

Gaganjuneja commented Oct 3, 2023

@Gaganjuneja please take a look, thank you

Looks good to me. Please take care of build :)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.client.PitIT.testDeleteAllAndListAllPits

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #10325 (5381e13) into main (d3bf230) will decrease coverage by 0.01%.
Report is 6 commits behind head on main.
The diff coverage is 55.00%.

@@             Coverage Diff              @@
##               main   #10325      +/-   ##
============================================
- Coverage     71.15%   71.14%   -0.01%     
- Complexity    58247    58286      +39     
============================================
  Files          4831     4832       +1     
  Lines        274684   274696      +12     
  Branches      40026    40028       +2     
============================================
- Hits         195443   195434       -9     
- Misses        62884    62930      +46     
+ Partials      16357    16332      -25     
Files Coverage Δ
...rg/opensearch/telemetry/tracing/DefaultTracer.java 100.00% <ø> (ø)
...rch/extensions/rest/RestActionsRequestHandler.java 100.00% <100.00%> (ø)
...extensions/rest/RestInitializeExtensionAction.java 65.00% <100.00%> (-0.44%) ⬇️
...rch/extensions/rest/RestSendToExtensionAction.java 42.14% <100.00%> (ø)
...g/opensearch/http/AbstractHttpServerTransport.java 75.13% <100.00%> (+0.13%) ⬆️
...src/main/java/org/opensearch/http/HttpChannel.java 100.00% <100.00%> (ø)
...ing/handler/TraceableTransportResponseHandler.java 80.00% <0.00%> (-3.34%) ⬇️
...opensearch/transport/TransportResponseHandler.java 0.00% <0.00%> (ø)
...a/org/opensearch/extensions/ExtensionsManager.java 52.14% <62.50%> (+8.12%) ⬆️
...lemetry/tracing/channels/TraceableHttpChannel.java 57.14% <0.00%> (-13.45%) ⬇️

... and 451 files with indirect coverage changes

@reta
Copy link
Collaborator Author

reta commented Oct 3, 2023

@andrross @dblock @kotwanikunal looking for review please, needs to be in 2.11, thank you

@reta reta added the v2.11.0 Issues and PRs related to version 2.11.0 label Oct 3, 2023
@andrross andrross added the backport 2.x Backport to 2.x branch label Oct 3, 2023
@andrross andrross merged commit bddf0d3 into opensearch-project:main Oct 3, 2023
71 of 72 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 3, 2023
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit bddf0d3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Oct 4, 2023
…10344)

(cherry picked from commit bddf0d3)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 9, 2023
vikasvb90 pushed a commit to vikasvb90/OpenSearch that referenced this pull request Oct 10, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ch-project#10325)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog v2.11.0 Issues and PRs related to version 2.11.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants