Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix the HttpChannel trace termination in case of exceptions #10344

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport bddf0d3 from #10325.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit bddf0d3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Compatibility status:

Checks if related components are compatible with change ce3f348

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.snapshots.CloneSnapshotIT.testClonePreventsSnapshotDelete
      1 org.opensearch.search.SearchWeightedRoutingIT.testMultiGetWithNetworkDisruption_FailOpenEnabled
      1 org.opensearch.action.admin.cluster.node.tasks.ResourceAwareTasksTests.testTaskResourceTrackingDuringTaskCancellation

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #10344 (ce3f348) into 2.x (3c1e5fb) will decrease coverage by 0.08%.
Report is 4 commits behind head on 2.x.
The diff coverage is 25.00%.

@@             Coverage Diff              @@
##                2.x   #10344      +/-   ##
============================================
- Coverage     70.96%   70.88%   -0.08%     
+ Complexity    58445    58406      -39     
============================================
  Files          4816     4817       +1     
  Lines        275763   275770       +7     
  Branches      40534    40535       +1     
============================================
- Hits         195683   195471     -212     
- Misses        63405    63618     +213     
- Partials      16675    16681       +6     
Files Coverage Δ
...rg/opensearch/telemetry/tracing/DefaultTracer.java 100.00% <ø> (ø)
...g/opensearch/http/AbstractHttpServerTransport.java 75.13% <100.00%> (+0.13%) ⬆️
...src/main/java/org/opensearch/http/HttpChannel.java 100.00% <100.00%> (ø)
...ing/handler/TraceableTransportResponseHandler.java 80.00% <0.00%> (-3.34%) ⬇️
...opensearch/transport/TransportResponseHandler.java 0.00% <0.00%> (ø)
...lemetry/tracing/channels/TraceableHttpChannel.java 57.14% <0.00%> (-13.45%) ⬇️

... and 503 files with indirect coverage changes

@reta reta merged commit 912b60a into 2.x Oct 4, 2023
38 of 64 checks passed
@github-actions github-actions bot deleted the backport/backport-10325-to-2.x branch October 4, 2023 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants