Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManagerTests #10490

Merged
merged 1 commit into from
Oct 7, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Oct 7, 2023

Description

This fixes #10489

Related Issues

Resolves #10489

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…rTests

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@ashking94
Copy link
Member Author

Ran it for 100+ iterations and it does not fail.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Compatibility status:

Checks if related components are compatible with change d16ad5f

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git]

@ashking94
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

Flaky test - #7530

@gbbafna gbbafna merged commit 22ddcf1 into opensearch-project:main Oct 7, 2023
41 of 67 checks passed
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Oct 7, 2023
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Oct 7, 2023
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Oct 7, 2023
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Oct 7, 2023
gbbafna added a commit that referenced this pull request Oct 7, 2023
…names (#10491)

* [Remote Store] Using hash of node id in metadata file names (#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManagerTests (#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
gbbafna added a commit that referenced this pull request Oct 9, 2023
… names (#10492)

* [Remote Store] Using hash of node id in metadata file names (#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManagerTests (#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 9, 2023
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…rTests (opensearch-project#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working skip-changelog Storage:Durability Issues and PRs related to the durability framework
Projects
None yet
2 participants