Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManagerTests #10490

Merged
merged 1 commit into from
Oct 7, 2023
Merged

Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManagerTests #10490

merged 1 commit into from
Oct 7, 2023

Conversation

ashking94
Copy link
Member

@ashking94 ashking94 commented Oct 7, 2023 •
edited
Loading

Description

This fixes #10489

Related Issues

Resolves #10489

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ashking94
Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManage…
d16ad5f 
…rTests

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions github-actions bot added bug Something isn't working Storage:Durability Issues and PRs related to the durability framework labels Oct 7, 2023
@ashking94
Copy link
Member Author

Ran it for 100+ iterations and it does not fail.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

Compatibility status:

Checks if related components are compatible with change d16ad5f

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/reporting.git]

@ashking94
Copy link
Member Author

Gradle Check (Jenkins) Run Completed with:

Flaky test - #7530

@gbbafna gbbafna merged commit 22ddcf1 into opensearch-project:main Oct 7, 2023
41 of 67 checks passed
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Oct 7, 2023
@ashking94
Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManage…
4fb6467 
…rTests (opensearch-project#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@ashking94 ashking94 mentioned this pull request Oct 7, 2023
Merged
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Oct 7, 2023
@ashking94
Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManage…
a9d0ac5 
…rTests (opensearch-project#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
@ashking94 ashking94 mentioned this pull request Oct 7, 2023
Merged
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Oct 7, 2023
@ashking94
Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManage…
fb10d4a 
…rTests (opensearch-project#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
ashking94 added a commit to ashking94/OpenSearch that referenced this pull request Oct 7, 2023
@ashking94
Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManage…
da44f91 
…rTests (opensearch-project#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
gbbafna added a commit that referenced this pull request Oct 7, 2023
@ashking94 @gbbafna
[Backport 2.x] [Remote Store] Using hash of node id in metadata file …
b2a836b 
…names (#10491)

* [Remote Store] Using hash of node id in metadata file names (#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManagerTests (#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
gbbafna added a commit that referenced this pull request Oct 9, 2023
@ashking94 @gbbafna
[Backport 2.11] [Remote Store] Using hash of node id in metadata file…
38df519 
… names (#10492)

* [Remote Store] Using hash of node id in metadata file names (#10480)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>

* Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManagerTests (#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>

---------

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Ashish Singh <ssashish@amazon.com>
Co-authored-by: Gaurav Bafna <85113518+gbbafna@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 9, 2023
@ashking94 @deshsidd
Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManage…
17c32af 
…rTests (opensearch-project#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
@ashking94 @austintlee
Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManage…
22a4251 
…rTests (opensearch-project#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@ashking94 @shiv0408
Fix failing testGetPrimaryTermAndGeneration in TranslogTransferManage…
c9cde5a 
…rTests (opensearch-project#10490)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@reta reta Awaiting requested review from reta reta is a code owner

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@setiah setiah Awaiting requested review from setiah

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@peternied peternied Awaiting requested review from peternied

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

Assignees
No one assigned
Labels
bug Something isn't working skip-changelog Storage:Durability Issues and PRs related to the durability framework
Projects
None yet
Milestone
No milestone
2 participants
@ashking94 @gbbafna