Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats #11880

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

ajaymovva
Copy link
Contributor

@ajaymovva ajaymovva commented Jan 14, 2024

Description

Integrate IO Based Usage Tracker and Stats for the Resource Usage Collector Service

  • This change is to track IO Usage Stats and emit these stats as part of resource_usage_stats.
  • Created AverageIoUsageTracker which uses IO stats from the fsService and evaluate the IO Usage Consumption.
  • Currently we are emitting only IO UsagePercent as part of io_usage_stats and eventually we will add more parameters.

NodeStats Output on Linux

resource_usage_stats: {
    Edk086LhT_mu47MpzHgc4g: {
        timestamp: 1709545252312,
        cpu_utilization_percent: "0.0",
        memory_utilization_percent: "1.0",
        io_usage_stats: {
            max_io_utilization_percent: "99.6"
        }
    }
}

NodeStats Output on Mac

resource_usage_stats: {
    qi1V9avrSwC_OyRtA2khbA: {
        timestamp: 1709544705354,
        cpu_utilization_percent: "0.1",
        memory_utilization_percent: "35.5"
    }
}

Related Issues

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ajaymovva ajaymovva force-pushed the feature/io-based-ac branch from 4b4f782 to 8dcf40e Compare January 14, 2024 05:53
Copy link
Contributor

github-actions bot commented Jan 14, 2024

Compatibility status:

Checks if related components are compatible with change 55db771

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

❌ Gradle check result for 4b4f782: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 8dcf40e: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ajaymovva ajaymovva changed the title Integrate IO Based Usage Tracker and Stats for the Resource Usage Collector Service Integrate IO Based Usage Tracker to the Resource Usage Collector Service Jan 14, 2024
@ajaymovva ajaymovva changed the title Integrate IO Based Usage Tracker to the Resource Usage Collector Service Integrate IO Usage Tracker to the Resource Usage Collector Service and emit IO Stats Jan 14, 2024
@ajaymovva ajaymovva changed the title Integrate IO Usage Tracker to the Resource Usage Collector Service and emit IO Stats Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Stats Jan 14, 2024
@ajaymovva ajaymovva changed the title Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Stats Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats Jan 14, 2024
@ajaymovva ajaymovva force-pushed the feature/io-based-ac branch from 8dcf40e to 842d3d4 Compare January 14, 2024 18:59
Copy link
Contributor

❌ Gradle check result for 842d3d4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Mar 4, 2024

❌ Gradle check result for 27b60be: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ajaymovva ajaymovva force-pushed the feature/io-based-ac branch from 27b60be to b5fa081 Compare March 4, 2024 09:04
Copy link
Contributor

github-actions bot commented Mar 4, 2024

✅ Gradle check result for b5fa081: SUCCESS

@ajaymovva ajaymovva force-pushed the feature/io-based-ac branch from b5fa081 to 14ca3ca Compare March 4, 2024 10:01
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
@ajaymovva ajaymovva force-pushed the feature/io-based-ac branch from 14ca3ca to a39baba Compare March 4, 2024 10:28
Copy link
Contributor

github-actions bot commented Mar 4, 2024

❌ Gradle check result for 14ca3ca: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Mar 4, 2024

✅ Gradle check result for a39baba: SUCCESS

Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM minor comments

Copy link
Contributor

github-actions bot commented Mar 5, 2024

❌ Gradle check result for 4b4dd48: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
@ajaymovva ajaymovva force-pushed the feature/io-based-ac branch from 4b4dd48 to 55db771 Compare March 5, 2024 19:47
Copy link
Contributor

github-actions bot commented Mar 5, 2024

✅ Gradle check result for 55db771: SUCCESS

@sachinpkale sachinpkale merged commit 63f20fe into opensearch-project:main Mar 7, 2024
32 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Mar 7, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11880-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 63f20fe5e4a2bba269db619c5ad0ce6df95c82ba
# Push it to GitHub
git push --set-upstream origin backport/backport-11880-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-11880-to-2.x.

ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Mar 7, 2024
…d Emit IO Usage Stats (opensearch-project#11880)

* Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

* Enable IO Usage Tracker For Linux OS

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

* Addressing Comments

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

---------

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
gbbafna pushed a commit that referenced this pull request Mar 8, 2024
…ctor Service and Emit IO Usage Stats #11880 (#12558)

* Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats (#11880)

* Updating OS Version to 2_13

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 12, 2024
…d Emit IO Usage Stats (opensearch-project#11880)

* Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

* Enable IO Usage Tracker For Linux OS

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

* Addressing Comments

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

---------

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
Signed-off-by: Aman Khare <amkhar@amazon.com>
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 14, 2024
…d Emit IO Usage Stats (opensearch-project#11880)

* Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

* Enable IO Usage Tracker For Linux OS

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

* Addressing Comments

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

---------

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…d Emit IO Usage Stats (opensearch-project#11880)

* Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

* Enable IO Usage Tracker For Linux OS

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

* Addressing Comments

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

---------

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…d Emit IO Usage Stats (opensearch-project#11880)

* Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

* Enable IO Usage Tracker For Linux OS

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

* Addressing Comments

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

---------

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants