-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats #11880
Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats #11880
Conversation
4b4f782
to
8dcf40e
Compare
Compatibility status:Checks if related components are compatible with change 55db771 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git] |
❌ Gradle check result for 4b4f782: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for 8dcf40e: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
8dcf40e
to
842d3d4
Compare
❌ Gradle check result for 842d3d4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/node/NodeResourceUsageStats.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/node/resource/tracker/NodeResourceUsageTracker.java
Show resolved
Hide resolved
❌ Gradle check result for 27b60be: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
27b60be
to
b5fa081
Compare
b5fa081
to
14ca3ca
Compare
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
14ca3ca
to
a39baba
Compare
❌ Gradle check result for 14ca3ca: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
server/src/main/java/org/opensearch/node/resource/tracker/AverageIoUsageTracker.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/opensearch/node/resource/tracker/AverageIoUsageTracker.java
Show resolved
Hide resolved
server/src/main/java/org/opensearch/node/resource/tracker/ResourceTrackerSettings.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM minor comments
❌ Gradle check result for 4b4dd48: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
4b4dd48
to
55db771
Compare
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-11880-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 63f20fe5e4a2bba269db619c5ad0ce6df95c82ba
# Push it to GitHub
git push --set-upstream origin backport/backport-11880-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…d Emit IO Usage Stats (opensearch-project#11880) * Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * Enable IO Usage Tracker For Linux OS Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * Addressing Comments Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> --------- Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
…d Emit IO Usage Stats (opensearch-project#11880) * Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * Enable IO Usage Tracker For Linux OS Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * Addressing Comments Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> --------- Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com> Signed-off-by: Aman Khare <amkhar@amazon.com>
…d Emit IO Usage Stats (opensearch-project#11880) * Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * Enable IO Usage Tracker For Linux OS Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * Addressing Comments Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> --------- Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
…d Emit IO Usage Stats (opensearch-project#11880) * Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * Enable IO Usage Tracker For Linux OS Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * Addressing Comments Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> --------- Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
…d Emit IO Usage Stats (opensearch-project#11880) * Integrate IO Usage Tracker to the Resource Usage Collector Service and Emit IO Usage Stats Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * Enable IO Usage Tracker For Linux OS Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * Addressing Comments Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> --------- Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Integrate IO Based Usage Tracker and Stats for the Resource Usage Collector Service
resource_usage_stats
.NodeStats Output on Linux
NodeStats Output on Mac
Related Issues
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.