-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate IO Based AdmissionController to AdmissionControl Framework #12702
Integrate IO Based AdmissionController to AdmissionControl Framework #12702
Conversation
d4ba448
to
651c2c5
Compare
❌ Gradle check result for d4ba448: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Compatibility status:Checks if related components are compatible with change 2032928 Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git] |
❌ Gradle check result for 651c2c5: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
651c2c5
to
d3c10e8
Compare
Test |
…pensearch-project#12583) * Integrated IO Based AdmissionController to AdmissionControl Framework Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * Integration Tests Fixes to Add Delay for Trackers Update Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * Fixing Integ Test and Removed Multi Node Tests Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> * Addressing Comments Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> --------- Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
4717c53
to
2032928
Compare
❌ Gradle check result for 2032928: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12702-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fbcc0d94d1183e15ea3c74c72894c527460b2ce3
# Push it to GitHub
git push --set-upstream origin backport/backport-12702-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x Then, create a pull request where the |
…pensearch-project#12702) * Integrate IO Based AdmissionController to AdmissionControl Framework (opensearch-project#12583) --------- Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
…pensearch-project#12702) Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
…pensearch-project#12702) Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
…pensearch-project#12702) Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
…pensearch-project#12702) Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
…pensearch-project#12702) * Integrate IO Based AdmissionController to AdmissionControl Framework (opensearch-project#12583) --------- Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
…pensearch-project#12702) Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
…pensearch-project#12702) Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
…pensearch-project#12702) Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
@ajaymovva @sachinpkale this pull request was merged with failing Gradle checks and now we have build failures across whole repository, I am reverting this pull request |
I have done backport to 2.x as well but I didn't faced this falky test issue there: #12716 |
Thanks @ajaymovva , I am trying to pinpoint the cause of this regression, other PRs (like #12709) are rebased on top of main, with this change included |
@reta Atleast at this point where we saw the same test failure: #12709 (comment) I didn't even merged my changes into main. |
@ajaymovva I am still looking, the test was flaky before, but the nature and the frequencies of the failures have changed: looking what is causing it, if it is not this pull request - nothing will be reverted for sure. |
…pensearch-project#12702) * Integrate IO Based AdmissionController to AdmissionControl Framework (opensearch-project#12583) --------- Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com> Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
Node Stats Output On Linux
Node Stats Output On Mac
Fixed the flaky tests in this PR: #12583. Modification Only in
AdmissionControlSingleNodeTests
Test File.Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.