Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate IO Based AdmissionController to AdmissionControl Framework #12702

Merged
merged 2 commits into from
Mar 18, 2024

Conversation

ajaymovva
Copy link
Contributor

@ajaymovva ajaymovva commented Mar 16, 2024

Description

Node Stats Output On Linux

"admission_control": {
    "global_io_usage": {
        "transport": {
            "rejection_count": {
                "search": 8
            }
        }
    },
    "global_cpu_usage": {
        "transport": {
            "rejection_count": {}
        }
    }
}

Node Stats Output On Mac

"admission_control": {
    "global_cpu_usage": {
        "transport": {
            "rejection_count": {
                "search": 4
            }
        }
    }
}

Fixed the flaky tests in this PR: #12583. Modification Only in AdmissionControlSingleNodeTests Test File.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ajaymovva ajaymovva changed the title Feature/io based ac Integrate IO Based AdmissionController to AdmissionControl Framework Mar 16, 2024
@ajaymovva ajaymovva force-pushed the feature/io-based-ac branch from d4ba448 to 651c2c5 Compare March 16, 2024 08:18
Copy link
Contributor

❌ Gradle check result for d4ba448: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Mar 16, 2024

Compatibility status:

Checks if related components are compatible with change 2032928

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

Copy link
Contributor

❌ Gradle check result for 651c2c5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ajaymovva ajaymovva force-pushed the feature/io-based-ac branch from 651c2c5 to d3c10e8 Compare March 16, 2024 08:55
@ajaymovva
Copy link
Contributor Author

❌ Gradle check result for 4717c53: null

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Test org.opensearch.transport.RemoteClusterClientTests.testConnectAndExecuteRequest is continously failing.
Issue link: #12338

ajaymovva and others added 2 commits March 18, 2024 12:15
…pensearch-project#12583)

* Integrated IO Based AdmissionController to AdmissionControl Framework

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

* Integration Tests Fixes to Add Delay for Trackers Update

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

* Fixing Integ Test and Removed Multi Node Tests

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

* Addressing Comments

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>

---------

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
@ajaymovva ajaymovva force-pushed the feature/io-based-ac branch from 4717c53 to 2032928 Compare March 18, 2024 06:46
Copy link
Contributor

❌ Gradle check result for 2032928: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sachinpkale sachinpkale merged commit fbcc0d9 into opensearch-project:main Mar 18, 2024
27 of 28 checks passed
@sachinpkale sachinpkale added the backport 2.x Backport to 2.x branch label Mar 18, 2024
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch/backport-2.x
# Create a new branch
git switch --create backport/backport-12702-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fbcc0d94d1183e15ea3c74c72894c527460b2ce3
# Push it to GitHub
git push --set-upstream origin backport/backport-12702-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-12702-to-2.x.

ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Mar 18, 2024
…pensearch-project#12702)

* Integrate IO Based AdmissionController to AdmissionControl Framework (opensearch-project#12583)
---------
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Mar 18, 2024
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Mar 18, 2024
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Mar 18, 2024
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Mar 18, 2024
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…pensearch-project#12702)

* Integrate IO Based AdmissionController to AdmissionControl Framework (opensearch-project#12583)
---------
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Mar 18, 2024
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Mar 18, 2024
ajaymovva added a commit to ajaymovva/OpenSearch that referenced this pull request Mar 18, 2024
sachinpkale pushed a commit that referenced this pull request Mar 18, 2024
…12702) (#12716)

Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
@reta
Copy link
Collaborator

reta commented Mar 18, 2024

@ajaymovva @sachinpkale this pull request was merged with failing Gradle checks and now we have build failures across whole repository, I am reverting this pull request

@ajaymovva
Copy link
Contributor Author

ajaymovva commented Mar 18, 2024

@reta Even before I merged the PR I saw this is failing for other PR's : #12709.
We retried multiple times to autofix it but it was not.

@ajaymovva
Copy link
Contributor Author

I have done backport to 2.x as well but I didn't faced this falky test issue there: #12716

@reta
Copy link
Collaborator

reta commented Mar 18, 2024

@reta Even before I merged the PR I saw this is failing for other PR's : #12709.

Thanks @ajaymovva , I am trying to pinpoint the cause of this regression, other PRs (like #12709) are rebased on top of main, with this change included

@ajaymovva
Copy link
Contributor Author

other PRs (like #12709) are rebased on top of main, with this change included

@reta Atleast at this point where we saw the same test failure: #12709 (comment) I didn't even merged my changes into main.

@reta
Copy link
Collaborator

reta commented Mar 18, 2024

@ajaymovva I am still looking, the test was flaky before, but the nature and the frequencies of the failures have changed: looking what is causing it, if it is not this pull request - nothing will be reverted for sure.

shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…pensearch-project#12702)

* Integrate IO Based AdmissionController to AdmissionControl Framework (opensearch-project#12583)
---------
Signed-off-by: Ajay Kumar Movva <movvaam@amazon.com>
Co-authored-by: Ajay Kumar Movva <movvaam@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport-failed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants