Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build due to multiple commits to same file causing compilation fa… #13019

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Fix build due to multiple commits to same file causing compilation fa… #13019

merged 1 commit into from
Apr 2, 2024

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Apr 2, 2024 •
edited
Loading

…ilure

Description

#12994 and #12821 were merged back to back w/o any merge conflicts . However build failed as the first PR did a refactor of a function used in second PR .

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gbbafna gbbafna marked this pull request as ready for review April 2, 2024 11:41
shourya035
shourya035 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@shourya035 shourya035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This needs to be merged asap so that other builds are unblocked

@gbbafna
Fix build due to multiple commits to same file causing compilation fa…
bcbb01b 
…ilure

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

❌ Gradle check result for 60e483a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change bcbb01b

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 2, 2024

✅ Gradle check result for bcbb01b: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 71.45%. Comparing base (b15cb0c) to head (bcbb01b).
Report is 116 commits behind head on main.

Files Patch % Lines
...in/java/org/opensearch/index/shard/IndexShard.java 0.00% 1 Missing and 1 partial ⚠️
...org/opensearch/index/seqno/ReplicationTracker.java 50.00% 0 Missing and 1 partial ⚠️
...nsearch/index/shard/CheckpointRefreshListener.java 0.00% 0 Missing and 1 partial ⚠️
...s/replication/SegmentReplicationSourceFactory.java 0.00% 0 Missing and 1 partial ⚠️
...eplication/checkpoint/PublishCheckpointAction.java 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #13019      +/-   ##
============================================
+ Coverage     71.42%   71.45%   +0.03%     
- Complexity    59978    60422     +444     
============================================
  Files          4985     5024      +39     
  Lines        282275   284294    +2019     
  Branches      40946    41173     +227     
============================================
+ Hits         201603   203138    +1535     
- Misses        63999    64334     +335     
- Partials      16673    16822     +149

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit f33db50 into opensearch-project:main Apr 2, 2024
29 of 31 checks passed
shourya035 pushed a commit to shourya035/OpenSearch that referenced this pull request Apr 2, 2024
@gbbafna @shourya035
Fix build due to multiple commits to same file causing compilation fa…
de584e1 
…ilure (opensearch-project#13019)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
@shourya035 shourya035 mentioned this pull request Apr 2, 2024
Merged
8 tasks
shourya035 pushed a commit to shourya035/OpenSearch that referenced this pull request Apr 2, 2024
@gbbafna @shourya035
Fix build due to multiple commits to same file causing compilation fa…
34d223d 
…ilure (opensearch-project#13019)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
@shourya035 shourya035 mentioned this pull request Apr 3, 2024
Closed
shourya035 pushed a commit to shourya035/OpenSearch that referenced this pull request Apr 17, 2024
@gbbafna @shourya035
Fix build due to multiple commits to same file causing compilation fa…
8883cd0 
…ilure (opensearch-project#13019)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
shourya035 pushed a commit to shourya035/OpenSearch that referenced this pull request Apr 17, 2024
@gbbafna @shourya035
Fix build due to multiple commits to same file causing compilation fa…
dad8184 
…ilure (opensearch-project#13019)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Apr 17, 2024
@shourya035
[Backport 2.x] Remote Store - Add Primary/Replica side changes to sup…
ba453da 
…port Dual Replication during Remote Store Migration (#13028)

* [Remote Store] Add Primary/Replica side changes to support Dual Replication during Remote Store Migration (#12821)

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>

* Fix build due to multiple commits to same file causing compilation failure (#13019)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>

---------

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@gbbafna @shiv0408
Fix build due to multiple commits to same file causing compilation fa…
af4d500 
…ilure (opensearch-project#13019)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Apr 29, 2024
@gbbafna @harshavamsi
Fix build due to multiple commits to same file causing compilation fa…
a13dfa5 
…ilure (opensearch-project#13019)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shourya035 shourya035 shourya035 approved these changes

@sachinpkale sachinpkale sachinpkale approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gbbafna @sachinpkale @shourya035