Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Remote Store - Add Primary/Replica side changes to support Dual Replication during Remote Store Migration #13028

Merged
merged 2 commits into from
Apr 17, 2024

Conversation

shourya035
Copy link
Member

Description

Backporting #12821 and #13019 to 2.x branch

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

Compatibility status:

Checks if related components are compatible with change a9a33aa

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/alerting.git]

Copy link
Contributor

github-actions bot commented Apr 2, 2024

❌ Gradle check result for de584e1: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 2, 2024

❌ Gradle check result for 34d223d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 3, 2024

❌ Gradle check result for 94e2dec: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

github-actions bot commented Apr 8, 2024

✅ Gradle check result for a9a33aa: SUCCESS

…cation during Remote Store Migration (opensearch-project#12821)

Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
…ilure (opensearch-project#13019)

Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Shourya Dutta Biswas <114977491+shourya035@users.noreply.github.com>
Copy link
Contributor

❕ Gradle check result for 8883cd0: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Apr 17, 2024

Codecov Report

Attention: Patch coverage is 70.17544% with 17 lines in your changes are missing coverage. Please review.

Project coverage is 71.24%. Comparing base (0dd892c) to head (dad8184).
Report is 149 commits behind head on 2.x.

Files Patch % Lines
...org/opensearch/index/seqno/ReplicationTracker.java 76.19% 0 Missing and 5 partials ⚠️
...rg/opensearch/indices/recovery/RecoveryTarget.java 0.00% 2 Missing and 2 partials ⚠️
...eplication/checkpoint/PublishCheckpointAction.java 25.00% 2 Missing and 1 partial ⚠️
...in/java/org/opensearch/index/shard/IndexShard.java 80.00% 1 Missing and 1 partial ⚠️
...support/replication/ReplicationModeAwareProxy.java 83.33% 0 Missing and 1 partial ⚠️
...nsearch/index/shard/CheckpointRefreshListener.java 0.00% 0 Missing and 1 partial ⚠️
...s/replication/SegmentReplicationSourceFactory.java 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #13028      +/-   ##
============================================
- Coverage     71.28%   71.24%   -0.04%     
- Complexity    60145    60619     +474     
============================================
  Files          4957     5004      +47     
  Lines        282799   285386    +2587     
  Branches      41409    41725     +316     
============================================
+ Hits         201591   203329    +1738     
- Misses        64189    64893     +704     
- Partials      17019    17164     +145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

✅ Gradle check result for dad8184: SUCCESS

@gbbafna gbbafna merged commit ba453da into opensearch-project:2.x Apr 17, 2024
49 of 51 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants