[Remote Store] Fix sleep time bug during remote store sync #14037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Gradle check result for f2e8385: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 0a22073: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 0a22073: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
|
❌ Gradle check result for 5bb5203: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
gbbafna
changed the title
gbbafna
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
saratvemulapalli,
shwetathareja and
sohami
as code owners
|
❕ Gradle check result for fff944a: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14037 +/- ##
============================================
+ Coverage 71.42% 71.64% +0.22%
- Complexity 59978 62053 +2075
============================================
Files 4985 5117 +132
Lines 282275 291689 +9414
Branches 40946 42166 +1220
============================================
+ Hits 201603 208990 +7387
- Misses 63999 65482 +1483
- Partials 16673 17217 +544 ☔ View full report in Codecov by Sentry. |
sachinpkale
reviewed
Jun 13, 2024
sachinpkale
approved these changes
Jun 13, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
--------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit afeddc2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 13, 2024
--------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit afeddc2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna
added a commit
to gbbafna/OpenSearch
that referenced
this pull request
Jun 13, 2024
gbbafna
added a commit
to gbbafna/OpenSearch
that referenced
this pull request
Jun 13, 2024
…pensearch-project#14037)" This reverts commit afeddc2. Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
reta
pushed a commit
that referenced
this pull request
Jun 13, 2024
This was referenced Jun 13, 2024
gbbafna
added a commit
to gbbafna/OpenSearch
that referenced
this pull request
Jun 14, 2024
…h-project#14037) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
sachinpkale
pushed a commit
that referenced
this pull request
Jun 14, 2024
* [Remote Store] Fix sleep time bug during remote store sync (#14037) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Fix remote migration ITs Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
* [Remote Store] Fix sleep time bug during remote store sync (#14037) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Fix remote migration ITs Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 5f2bff3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
* [Remote Store] Fix sleep time bug during remote store sync (#14037) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Fix remote migration ITs Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 5f2bff3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3 tasks
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Jul 12, 2024
…h-project#14037) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Jul 12, 2024
…pensearch-project#14037)" (opensearch-project#14274) This reverts commit afeddc2. Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Jul 12, 2024
…ch-project#14342) * [Remote Store] Fix sleep time bug during remote store sync (opensearch-project#14037) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Fix remote migration ITs Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…h-project#14037) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…pensearch-project#14037)" (opensearch-project#14274) This reverts commit afeddc2. Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…ch-project#14342) * [Remote Store] Fix sleep time bug during remote store sync (opensearch-project#14037) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Fix remote migration ITs Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix sleep time bug during remote store sync . Instead of sleeping for 30 sec, it was sleeping for 30ms unintentionally. This would waste unnecessary CPU cycles and context switches.
Related Issues
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.