[Remote Store] Fix sleep time bug during remote store sync #14342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…h-project#14037) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14342 +/- ##
============================================
+ Coverage 71.42% 71.75% +0.33%
- Complexity 59978 62073 +2095
============================================
Files 4985 5117 +132
Lines 282275 291712 +9437
Branches 40946 42168 +1222
============================================
+ Hits 201603 209316 +7713
- Misses 63999 65151 +1152
- Partials 16673 17245 +572 ☔ View full report in Codecov by Sentry. |
gbbafna
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
sachinpkale
approved these changes
Jun 14, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
* [Remote Store] Fix sleep time bug during remote store sync (#14037) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Fix remote migration ITs Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 5f2bff3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 14, 2024
* [Remote Store] Fix sleep time bug during remote store sync (#14037) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Fix remote migration ITs Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> (cherry picked from commit 5f2bff3) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
3 tasks
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Jul 12, 2024
…ch-project#14342) * [Remote Store] Fix sleep time bug during remote store sync (opensearch-project#14037) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Fix remote migration ITs Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
kkewwei
pushed a commit
to kkewwei/OpenSearch
that referenced
this pull request
Jul 24, 2024
…ch-project#14342) (opensearch-project#14343) (cherry picked from commit 5f2bff3) Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
…ch-project#14342) * [Remote Store] Fix sleep time bug during remote store sync (opensearch-project#14037) --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> * Fix remote migration ITs Signed-off-by: Gaurav Bafna <gbbafna@amazon.com> --------- Signed-off-by: Gaurav Bafna <gbbafna@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix sleep time bug during remote store sync . Instead of sleeping for 30 sec, it was sleeping for 30ms unintentionally. This would waste unnecessary CPU cycles and context switches.
Related Issues
Check List
API changes companion pull request created, if applicable.Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.