Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing auto backport workflow #1845

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

VachaShah
Copy link
Collaborator

@VachaShah VachaShah commented Jan 4, 2022

Signed-off-by: Vacha Shah vachshah@amazon.com

Description

This should fix the backport workflow failures since the branch protection is relaxed in PR #1816. I tried with the similar set of permissions on my repo and the workflow ran successfully https://github.com/VachaShah/TestGithubActions/runs/4706516920?check_suite_focus=true. The default permissions are read for all the scopes if not specified, for example: https://github.com/opensearch-project/OpenSearch/runs/4702581161?check_suite_focus=true

Note: I will add a backport label to a PR in this repo to verify.

Issues Resolved

#1712

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vacha Shah <vachshah@amazon.com>
@VachaShah VachaShah requested a review from a team as a code owner January 4, 2022 19:48
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 6d404e8
Log 1769

Reports 1769

Copy link
Member

@saratvemulapalli saratvemulapalli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @VachaShah !

Now probably we have to tackle stale branches after the backport PR is merged.
May be can you submit a PR tibdex/backport to add support?

@owaiskazi19
Copy link
Member

Let's test the flow 🎉

@VachaShah
Copy link
Collaborator Author

Looks good to me. Thanks @VachaShah !

Now probably we have to tackle stale branches after the backport PR is merged. May be can you submit a PR tibdex/backport to add support?

Sure will do!

@VachaShah VachaShah merged commit b99f10a into opensearch-project:main Jan 4, 2022
@VachaShah VachaShah deleted the auto-backport-fix branch January 4, 2022 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants