Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typo in TESTING.md #1849

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Conversation

VachaShah
Copy link
Collaborator

Signed-off-by: Vacha Shah vachshah@amazon.com

Description

Fixes some typos. Creating this PR to test the auto-backport workflow from PR #1845

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Vacha Shah <vachshah@amazon.com>
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 5b4a59e
Log 1771

Reports 1771

@VachaShah
Copy link
Collaborator Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 5b4a59e
Log 1773

Reports 1773

@dblock dblock merged commit 6e26679 into opensearch-project:main Jan 5, 2022
@dblock dblock added the pending backport Identifies an issue or PR that still needs to be backported label Jan 5, 2022
@dblock
Copy link
Member

dblock commented Jan 5, 2022

Was it supposed to create a backport PR for this?

@VachaShah
Copy link
Collaborator Author

Was it supposed to create a backport PR for this?

Yes it was supposed to, the workflow still fails with the branch permission issues. I will look into why it is still failing since the branch protection rules are fine now.

github-actions bot pushed a commit that referenced this pull request Jan 21, 2022
Signed-off-by: Vacha Shah <vachshah@amazon.com>
(cherry picked from commit 6e26679)
nknize pushed a commit that referenced this pull request Jan 26, 2022
Fixes some grammar and link typos found in TESTING.md. 

Signed-off-by: Vacha Shah <vachshah@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 1.x pending backport Identifies an issue or PR that still needs to be backported
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants