-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing typo in TESTING.md #1849
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vacha Shah <vachshah@amazon.com>
Can one of the admins verify this patch? |
andrross
approved these changes
Jan 5, 2022
saratvemulapalli
approved these changes
Jan 5, 2022
start gradle check |
dblock
added
the
pending backport
Identifies an issue or PR that still needs to be backported
label
Jan 5, 2022
Was it supposed to create a backport PR for this? |
Yes it was supposed to, the workflow still fails with the branch permission issues. I will look into why it is still failing since the branch protection rules are fine now. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 21, 2022
Signed-off-by: Vacha Shah <vachshah@amazon.com> (cherry picked from commit 6e26679)
nknize
pushed a commit
that referenced
this pull request
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vacha Shah vachshah@amazon.com
Description
Fixes some typos. Creating this PR to test the auto-backport workflow from PR #1845
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.