Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary empty build.gradle files #4723

Merged

Conversation

rursprung
Copy link
Contributor

Description

these have no impact, as the targets are added by the parent build.gradle. thus they do not need to exist and are currently just cluttering the workspace and confusing people trying to work in that area.

see also the discussion on opensearch-project/opensearch-build#99 for some details.

Signed-off-by: Ralph Ursprung Ralph.Ursprung@avaloq.com

Issues Resolved

n/a

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@rursprung rursprung force-pushed the remove-unnecessary-empty-gradle-files branch from 4084e02 to 17170ec Compare October 10, 2022 09:28
@rursprung rursprung marked this pull request as ready for review October 10, 2022 09:29
@rursprung rursprung requested review from a team and reta as code owners October 10, 2022 09:29
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@rursprung
Copy link
Contributor Author

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/4242/

* **CommitID:** [17170ec](https://github.com/opensearch-project/OpenSearch/commit/17170ec11c12bc365c930501e0215873777e5eec)

this might be a relevant failure:

FAILURE: Build completed with 2 failures.

1: Task failed with an exception.
-----------
* What went wrong:
Execution failed for task ':distribution:docker:docker-export:exportDockerImage'.
> A problem occurred starting process 'command 'docker''

however, i sadly currently don't have a linux box with docker on it (and a connection to the internet) available to test this... could somebody else maybe briefly try to run this with --info to see more details? thanks!

@dblock
Copy link
Member

dblock commented Oct 11, 2022

I just kicked it to see if it's transient.

Does ./gradle :distribution:docker:docker-export:exportDockerImage fail the same way for you locally?

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@rursprung
Copy link
Contributor Author

Does ./gradle :distribution:docker:docker-export:exportDockerImage fail the same way for you locally?

i wouldn't know, our infrastructure doesn't support having a local docker installation 😞 (and the OpenSearch gradle build doesn't support using Docker CLI with a remote docker server)

@rursprung rursprung force-pushed the remove-unnecessary-empty-gradle-files branch from 17170ec to 695b01f Compare October 24, 2022 12:01
@rursprung
Copy link
Contributor Author

Does ./gradle :distribution:docker:docker-export:exportDockerImage fail the same way for you locally?

i wouldn't know, our infrastructure doesn't support having a local docker installation 😞 (and the OpenSearch gradle build doesn't support using Docker CLI with a remote docker server)

i've now temporarily patched the gradle build to use Docker CLI, then it works. i've also raised #4883 to get a more long-term solution for this.

i can confirm that the gradle target builds just fine for me locally. so i've now rebased and pushed that again in the hopes that the jenkins build will now run through.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@rursprung
Copy link
Contributor Author

Gradle Check (Jenkins) Run Completed with:

* **RESULT:** FAILURE ❌

* **URL:** https://build.ci.opensearch.org/job/gradle-check/5337/

* **CommitID:** [695b01f](https://github.com/opensearch-project/OpenSearch/commit/695b01f40eb7e8ca2ec728511364c6f3cb462391)

see my comment above: in my environment this gradle target runs just fine, so this might be linux-specific. if somebody with access to a linux box (where they can build this project) could test if they can reproduce this error that'd be great, thanks! otherwise i'm a bit stuck here.

however, this is also not an important PR, it's just a minor cleanup...

@rursprung rursprung deleted the remove-unnecessary-empty-gradle-files branch June 17, 2023 12:28
gaiksaya pushed a commit to gaiksaya/OpenSearch that referenced this pull request Jun 26, 2023
… (opensearch-project#8113)

* remove unnecessary empty `build.gradle` files

these have no impact, as the targets are added by the parent
`build.gradle`. thus they do not need to exist and are currently just
cluttering the workspace and confusing people trying to work in that
area.

see also the discussion on opensearch-build#99 for some details.



* Revert removal of distribution/docker/docker-export/build.gradle



---------




(cherry picked from commit a6b984b)

Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Kartik Ganesh <gkart@amazon.com>
imRishN pushed a commit to imRishN/OpenSearch that referenced this pull request Jun 27, 2023
* remove unnecessary empty `build.gradle` files

these have no impact, as the targets are added by the parent
`build.gradle`. thus they do not need to exist and are currently just
cluttering the workspace and confusing people trying to work in that
area.

see also the discussion on opensearch-build#99 for some details.

Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>

* Revert removal of distribution/docker/docker-export/build.gradle

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

---------

Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Co-authored-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 8, 2023
reta added a commit to reta/OpenSearch that referenced this pull request Nov 8, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 8, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 8, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 8, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 9, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 14, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 17, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 27, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 29, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 29, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 29, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 29, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 29, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 29, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 29, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit to reta/OpenSearch that referenced this pull request Nov 29, 2023
…ject#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta added a commit that referenced this pull request Nov 30, 2023
* Update Gradle to 8.5

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Revert "remove unnecessary empty `build.gradle` files (#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 30, 2023
* Update Gradle to 8.5

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Revert "remove unnecessary empty `build.gradle` files (#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit a123c43)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kotwanikunal pushed a commit that referenced this pull request Nov 30, 2023
* Update Gradle to 8.5



* Revert "remove unnecessary empty `build.gradle` files (#4723)"

This reverts commit a6b984b.



---------


(cherry picked from commit a123c43)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
fahadshamiinsta pushed a commit to fahadshamiinsta/OpenSearch270 that referenced this pull request Dec 4, 2023
* Update Gradle to 8.5

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Revert "remove unnecessary empty `build.gradle` files (opensearch-project#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Dec 11, 2023
* Update Gradle to 8.5

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Revert "remove unnecessary empty `build.gradle` files (opensearch-project#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
* Update Gradle to 8.5

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Revert "remove unnecessary empty `build.gradle` files (opensearch-project#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* remove unnecessary empty `build.gradle` files

these have no impact, as the targets are added by the parent
`build.gradle`. thus they do not need to exist and are currently just
cluttering the workspace and confusing people trying to work in that
area.

see also the discussion on opensearch-build#99 for some details.

Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>

* Revert removal of distribution/docker/docker-export/build.gradle

Signed-off-by: Kartik Ganesh <gkart@amazon.com>

---------

Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com>
Signed-off-by: Kartik Ganesh <gkart@amazon.com>
Co-authored-by: Kartik Ganesh <gkart@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
* Update Gradle to 8.5

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

* Revert "remove unnecessary empty `build.gradle` files (opensearch-project#4723)"

This reverts commit a6b984b.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants