-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove unnecessary empty build.gradle
files
#4723
remove unnecessary empty build.gradle
files
#4723
Conversation
4084e02
to
17170ec
Compare
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
this might be a relevant failure:
however, i sadly currently don't have a linux box with docker on it (and a connection to the internet) available to test this... could somebody else maybe briefly try to run this with |
I just kicked it to see if it's transient. Does |
Gradle Check (Jenkins) Run Completed with:
|
i wouldn't know, our infrastructure doesn't support having a local docker installation 😞 (and the OpenSearch gradle build doesn't support using Docker CLI with a remote docker server) |
17170ec
to
695b01f
Compare
i've now temporarily patched the gradle build to use Docker CLI, then it works. i've also raised #4883 to get a more long-term solution for this. i can confirm that the gradle target builds just fine for me locally. so i've now rebased and pushed that again in the hopes that the jenkins build will now run through. |
Gradle Check (Jenkins) Run Completed with:
|
see my comment above: in my environment this gradle target runs just fine, so this might be linux-specific. if somebody with access to a linux box (where they can build this project) could test if they can reproduce this error that'd be great, thanks! otherwise i'm a bit stuck here. however, this is also not an important PR, it's just a minor cleanup... |
695b01f
to
28fc470
Compare
… (opensearch-project#8113) * remove unnecessary empty `build.gradle` files these have no impact, as the targets are added by the parent `build.gradle`. thus they do not need to exist and are currently just cluttering the workspace and confusing people trying to work in that area. see also the discussion on opensearch-build#99 for some details. * Revert removal of distribution/docker/docker-export/build.gradle --------- (cherry picked from commit a6b984b) Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com> Signed-off-by: Kartik Ganesh <gkart@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Kartik Ganesh <gkart@amazon.com>
* remove unnecessary empty `build.gradle` files these have no impact, as the targets are added by the parent `build.gradle`. thus they do not need to exist and are currently just cluttering the workspace and confusing people trying to work in that area. see also the discussion on opensearch-build#99 for some details. Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com> * Revert removal of distribution/docker/docker-export/build.gradle Signed-off-by: Kartik Ganesh <gkart@amazon.com> --------- Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com> Signed-off-by: Kartik Ganesh <gkart@amazon.com> Co-authored-by: Kartik Ganesh <gkart@amazon.com> Signed-off-by: Rishab Nahata <rnnahata@amazon.com>
…ject#4723)" This reverts commit a6b984b.
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
…ject#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Update Gradle to 8.5 Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Revert "remove unnecessary empty `build.gradle` files (#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit a123c43) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update Gradle to 8.5 * Revert "remove unnecessary empty `build.gradle` files (#4723)" This reverts commit a6b984b. --------- (cherry picked from commit a123c43) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Update Gradle to 8.5 Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Revert "remove unnecessary empty `build.gradle` files (opensearch-project#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Update Gradle to 8.5 Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Revert "remove unnecessary empty `build.gradle` files (opensearch-project#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* Update Gradle to 8.5 Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Revert "remove unnecessary empty `build.gradle` files (opensearch-project#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
* remove unnecessary empty `build.gradle` files these have no impact, as the targets are added by the parent `build.gradle`. thus they do not need to exist and are currently just cluttering the workspace and confusing people trying to work in that area. see also the discussion on opensearch-build#99 for some details. Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com> * Revert removal of distribution/docker/docker-export/build.gradle Signed-off-by: Kartik Ganesh <gkart@amazon.com> --------- Signed-off-by: Ralph Ursprung <Ralph.Ursprung@avaloq.com> Signed-off-by: Kartik Ganesh <gkart@amazon.com> Co-authored-by: Kartik Ganesh <gkart@amazon.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
* Update Gradle to 8.5 Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Revert "remove unnecessary empty `build.gradle` files (opensearch-project#4723)" This reverts commit a6b984b. Signed-off-by: Andriy Redko <andriy.redko@aiven.io> --------- Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
these have no impact, as the targets are added by the parent
build.gradle
. thus they do not need to exist and are currently just cluttering the workspace and confusing people trying to work in that area.see also the discussion on opensearch-project/opensearch-build#99 for some details.
Signed-off-by: Ralph Ursprung Ralph.Ursprung@avaloq.com
Issues Resolved
n/a
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.