Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added empty build.gradle files for arm64 and s390x because the gradle assemble task fails without them #8904

Merged

Conversation

evankielley
Copy link
Contributor

Description

This change fixes the gradle assemble task which is failing due to missing build.gradle files in the docker subprojects for arm64 and s390x. These files were removed in PR #4723. I created issue #8903 to discuss this particular bug and created this PR for a quick fix. In addition, issue #8112 was created to further investigate why removing those files causes the build to fail.

Related Issues

Resolves #8903
Related #8112

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

… assemble task fails without them.

Signed-off-by: Evan Kielley <evankielley@gmail.com>
@evankielley evankielley force-pushed the bugfix-add-empty-dirs-for-docker branch from b7804fd to 1e368ed Compare July 27, 2023 01:10
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@reta
Copy link
Collaborator

reta commented Jul 27, 2023

@evankielley could you please rebase against latest main (to fix build issues)? Also, thanks to you finding, I will suggest to add distribution checks for pull requests (#8924), that would have caught the issue ... thank you

@evankielley
Copy link
Contributor Author

@evankielley could you please rebase against latest main (to fix build issues)? Also, thanks to you finding, I will suggest to add distribution checks for pull requests (#8924), that would have caught the issue ... thank you

@reta I just rebased but as for adding a distro check to gradle assemble, it looks like you have that covered now in PR #8924 ?

@reta
Copy link
Collaborator

reta commented Jul 27, 2023

@reta I just rebased but as for adding a distro check to gradle assemble, it looks like you have that covered now in PR #8924 ?

Thanks @evankielley , I temporarily applied your fix (to prove that all checks pass) but it is removed. I will rebase the my change after we get this one in, thank you.

@evankielley
Copy link
Contributor Author

@reta I just rebased but as for adding a distro check to gradle assemble, it looks like you have that covered now in PR #8924 ?

Thanks @evankielley , I temporarily applied your fix (to prove that all checks pass) but it is removed. I will rebase the my change after we get this one in, thank you.

Perfect, thank you

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testStartReplicaAfterPrimaryIndexesDocs

@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Merging #8904 (b34224d) into main (5495c64) will increase coverage by 0.40%.
Report is 6 commits behind head on main.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #8904      +/-   ##
============================================
+ Coverage     71.08%   71.49%   +0.40%     
- Complexity    57276    57552     +276     
============================================
  Files          4758     4758              
  Lines        269869   269869              
  Branches      39487    39487              
============================================
+ Hits         191836   192930    +1094     
+ Misses        61891    61054     -837     
+ Partials      16142    15885     -257     

see 436 files with indirect coverage changes

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.client.PitIT.testDeleteAllAndListAllPits

@reta reta merged commit 0003bd8 into opensearch-project:main Jul 28, 2023
@reta reta added the backport 2.x Backport to 2.x branch label Jul 28, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 28, 2023
… assemble task fails without them. (#8904)

Signed-off-by: Evan Kielley <evankielley@gmail.com>
(cherry picked from commit 0003bd8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Jul 28, 2023
… assemble task fails without them. (#8904) (#8964)

(cherry picked from commit 0003bd8)

Signed-off-by: Evan Kielley <evankielley@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 28, 2023
… assemble task fails without them. (opensearch-project#8904)

Signed-off-by: Evan Kielley <evankielley@gmail.com>
baba-devv pushed a commit to baba-devv/OpenSearch that referenced this pull request Jul 29, 2023
… assemble task fails without them. (opensearch-project#8904)

Signed-off-by: Evan Kielley <evankielley@gmail.com>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
… assemble task fails without them. (opensearch-project#8904)

Signed-off-by: Evan Kielley <evankielley@gmail.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
… assemble task fails without them. (opensearch-project#8904)

Signed-off-by: Evan Kielley <evankielley@gmail.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
… assemble task fails without them. (opensearch-project#8904)

Signed-off-by: Evan Kielley <evankielley@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Gradle assemble task fails due to missing build.gradle files in docker subprojects
2 participants