-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added empty build.gradle files for arm64 and s390x because the gradle assemble task fails without them #8904
Added empty build.gradle files for arm64 and s390x because the gradle assemble task fails without them #8904
Conversation
Gradle Check (Jenkins) Run Completed with:
|
… assemble task fails without them. Signed-off-by: Evan Kielley <evankielley@gmail.com>
b7804fd
to
1e368ed
Compare
Gradle Check (Jenkins) Run Completed with:
|
@evankielley could you please rebase against latest |
@reta I just rebased but as for adding a distro check to gradle assemble, it looks like you have that covered now in PR #8924 ? |
Thanks @evankielley , I temporarily applied your fix (to prove that all checks pass) but it is removed. I will rebase the my change after we get this one in, thank you. |
Perfect, thank you |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Codecov Report
@@ Coverage Diff @@
## main #8904 +/- ##
============================================
+ Coverage 71.08% 71.49% +0.40%
- Complexity 57276 57552 +276
============================================
Files 4758 4758
Lines 269869 269869
Branches 39487 39487
============================================
+ Hits 191836 192930 +1094
+ Misses 61891 61054 -837
+ Partials 16142 15885 -257 |
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
Gradle Check (Jenkins) Run Completed with:
|
… assemble task fails without them. (#8904) (#8964) (cherry picked from commit 0003bd8) Signed-off-by: Evan Kielley <evankielley@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
… assemble task fails without them. (opensearch-project#8904) Signed-off-by: Evan Kielley <evankielley@gmail.com>
… assemble task fails without them. (opensearch-project#8904) Signed-off-by: Evan Kielley <evankielley@gmail.com>
… assemble task fails without them. (opensearch-project#8904) Signed-off-by: Evan Kielley <evankielley@gmail.com> Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
… assemble task fails without them. (opensearch-project#8904) Signed-off-by: Evan Kielley <evankielley@gmail.com> Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
… assemble task fails without them. (opensearch-project#8904) Signed-off-by: Evan Kielley <evankielley@gmail.com> Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Description
This change fixes the gradle assemble task which is failing due to missing build.gradle files in the docker subprojects for arm64 and s390x. These files were removed in PR #4723. I created issue #8903 to discuss this particular bug and created this PR for a quick fix. In addition, issue #8112 was created to further investigate why removing those files causes the build to fail.
Related Issues
Resolves #8903
Related #8112
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.