Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing SnapshotResiliencyTests.testTransportGetSnapshotsAction #9189

Merged

Conversation

indrajohn7
Copy link
Contributor

@indrajohn7 indrajohn7 commented Aug 9, 2023

Description

This PR resolves the flaky test: testTransportGetSnapshotsAction with a single createSnapshotResponseStepListener object.

Related Issues

Resolves #9186

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

indrajohn7 and others added 29 commits June 30, 2023 17:11
Signed-off-by: INDRAJIT BANERJEE <indrajohn7@gmail.com>
Signed-off-by: INDRAJIT BANERJEE <indrajohn7@gmail.com>
Signed-off-by: INDRAJIT BANERJEE <indrajohn7@gmail.com>
Signed-off-by: INDRAJIT BANERJEE <indrajohn7@gmail.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
…tener object

Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
@indrajohn7 indrajohn7 marked this pull request as ready for review August 9, 2023 08:58
@shwetathareja shwetathareja changed the title Get snapshot async listener Fxing SnapshotResiliencyTests.testTransportGetSnapshotsAction Aug 9, 2023
@shwetathareja shwetathareja changed the title Fxing SnapshotResiliencyTests.testTransportGetSnapshotsAction Fixing SnapshotResiliencyTests.testTransportGetSnapshotsAction Aug 9, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #9189 (cb72ba5) into main (6eb87b5) will decrease coverage by 0.08%.
The diff coverage is n/a.

❗ Current head cb72ba5 differs from pull request most recent head 73ac6b6. Consider uploading reports for the commit 73ac6b6 to get more accurate results

@@             Coverage Diff              @@
##               main    #9189      +/-   ##
============================================
- Coverage     71.10%   71.02%   -0.08%     
+ Complexity    57326    57308      -18     
============================================
  Files          4768     4768              
  Lines        270540   270540              
  Branches      39559    39559              
============================================
- Hits         192369   192154     -215     
- Misses        61966    62215     +249     
+ Partials      16205    16171      -34     

see 452 files with indirect coverage changes

Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git]
Compatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/reporting.git]

BUILD SUCCESSFUL in 31m 26s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.client.PitIT.testDeleteAllAndListAllPits

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 40m 4s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Gradle Check (Jenkins) Run Completed with:

Signed-off-by: INDRAJIT BANERJEE <indrajohn7@gmail.com>
@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Gradle Check (Jenkins) Run Completed with:

@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:



> Task :checkCompatibility
Incompatible components: [https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git]

BUILD SUCCESSFUL in 36m 13s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDropPrimaryDuringReplication

@shwetathareja shwetathareja merged commit d252de1 into opensearch-project:main Aug 9, 2023
@shwetathareja shwetathareja added the backport 2.x Backport to 2.x branch label Aug 9, 2023
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-9189-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 d252de15f510322a2aeb55b4c1995a4434074dd2
# Push it to GitHub
git push --set-upstream origin backport/backport-9189-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-9189-to-2.x.

@indrajohn7 indrajohn7 mentioned this pull request Aug 9, 2023
6 tasks
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Sep 12, 2023
…earch-project#9189)

* Fixing flaky test testTransportGetSnapshotsAction

Signed-off-by: INDRAJIT BANERJEE <indrajohn7@gmail.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Kaushal Kumar <ravi.kaushal97@gmail.com>
brusic pushed a commit to brusic/OpenSearch that referenced this pull request Sep 25, 2023
…earch-project#9189)

* Fixing flaky test testTransportGetSnapshotsAction

Signed-off-by: INDRAJIT BANERJEE <indrajohn7@gmail.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Ivan Brusic <ivan.brusic@flocksafety.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…earch-project#9189)

* Fixing flaky test testTransportGetSnapshotsAction

Signed-off-by: INDRAJIT BANERJEE <indrajohn7@gmail.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky Test]SnapshotResiliencyTests.testTransportGetSnapshotsAction
4 participants