Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/backport 8377 to 2.x #9192

Merged

Conversation

indrajohn7
Copy link
Contributor

Description

This PR resolves the flaky test: testTransportGetSnapshotsAction with a single createSnapshotResponseStepListener object.
Back-port #9189

Related Issues

Resolves #9186

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

indrajohn7 and others added 4 commits August 8, 2023 14:37
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
…ingle listener object

Signed-off-by: Indrajit Banerjee <banerind@amazon.com>
@opensearch-trigger-bot
Copy link
Contributor

Compatibility status:

> Task :checkCompatibility
Checking compatibility for: https://github.com/opensearch-project/common-utils.git with ref: 2.x
Checking compatibility for: https://github.com/opensearch-project/reporting.git with ref: 2.x
Incompatible components: [https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/anomaly-detection.git]
Components skipped due to git failures: [https://github.com/opensearch-project/opensearch-oci-object-storage.git]
Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/ml-commons.git]

BUILD SUCCESSFUL in 23m 34s

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.search.SearchTimeoutIT.testSimpleTimeout

@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #9192 (11a3548) into 2.x (cc9d907) will decrease coverage by 0.08%.
Report is 4 commits behind head on 2.x.
The diff coverage is 61.76%.

@@             Coverage Diff              @@
##                2.x    #9192      +/-   ##
============================================
- Coverage     70.83%   70.76%   -0.08%     
- Complexity    57454    57462       +8     
============================================
  Files          4754     4754              
  Lines        271758   271764       +6     
  Branches      40082    40084       +2     
============================================
- Hits         192504   192307     -197     
- Misses        62713    62974     +261     
+ Partials      16541    16483      -58     
Files Changed Coverage Δ
...ter/snapshots/get/TransportGetSnapshotsAction.java 55.14% <61.76%> (+13.55%) ⬆️

... and 481 files with indirect coverage changes

@shwetathareja shwetathareja merged commit 545bf9d into opensearch-project:2.x Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants