Update property when switching layer config panel #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
ruanyl
reviewed
Jan 4, 2023
| @@ -30,14 +30,12 @@ interface Props { | |||
| setSelectedLayerConfig: Function; | |||
| selectedLayerConfig: DocumentLayerSpecification; | |||
| setIsUpdateDisabled: Function; | |||
| layersIndexPatterns: IndexPattern[]; | |||
| } | |||
|
|
|||
| export const DocumentLayerSource = ({ | |||
There was a problem hiding this comment.
It looks unnecessary to keep the component DocumentLayerSource state of selectedNumber tooltipSelection, etc.
It could use layer config passed by props and update the layer config directly with setSelectedLayerConfig, like what we do in onFiltersUpdated. Layer config passed by props should be the only source of truth. What do you think?
There was a problem hiding this comment.
Yeah, just updated the code, thanks!
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
VijayanB
approved these changes
Jan 5, 2023
heemin32
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junqiu Lei junqiu@amazon.com
Description
This PR contains:
###Demo
Screen.Recording.2023-01-05.at.12.06.20.PM.mov
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.