Merge Feature/new-maps branch head to main #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
VijayanB
approved these changes
Jan 7, 2023
junqiu-lei
changed the title
|
The tests failure is unrelated with this PR. |
navneet1v
approved these changes
Jan 7, 2023
|
@junqiu-lei as a next steps can we focus on fixing the CI for this plugin, I think this pending for some time. Given that it is mainly a path change that we have done for our cypress tests it should be straightforward. |
Yes, I'm fixing the existing cypress CI and then add new maps cypress test case to CI. |
|
Also we should backport these changes to 2.x |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Junqiu Lei junqiu@amazon.com
Description
Merge Feature/new maps branch head to main after #166 merged.
This PR contains:
#158
#165
#154
#159
#148
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.