[WIP ] OverviewPage made with Content Management #2036
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TackAdam
commented
Aug 10, 2024
| props.setStartDate(onTimeChangeProps.start); | ||
| props.setEndDate(onTimeChangeProps.end); | ||
|
|
||
| coreRefs.contentManagement?.updatePageSection(HOME_CONTENT_AREAS.DASHBOARD, (section) => { |
There was a problem hiding this comment.
Allows the date-picker to update the displayed dashboard. Pending opensearch-project/OpenSearch-Dashboards#7651
|
@danieldong51 Can you please resolve the conflicts here |
ps48
reviewed
Aug 12, 2024
| @@ -3,159 +3,239 @@ | |||
| * SPDX-License-Identifier: Apache-2.0 | |||
| */ | |||
|
|
|||
| import React, { useState, useEffect } from 'react'; | |||
| import React, { useEffect, useState } from 'react'; | |||
There was a problem hiding this comment.
Can we please add some jest, cypress tests here.
danieldong51
force-pushed
the
overviewCM
branch
from
39c65a8 to
ac0acdc
Compare
Signed-off-by: Adam Tackett <tackadam@amazon.com> Co-authored-by: Adam Tackett <tackadam@amazon.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
…t#2023) Signed-off-by: sumukhswamy <sumukhhs@amazon.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
* fix direct url load for trace analytics Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update side nav link Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com> Co-authored-by: Adam Tackett <tackadam@amazon.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
…ch-project#2037) * bugfix ids and breadcrumbs Signed-off-by: Adam Tackett <tackadam@amazon.com> * remove comments Signed-off-by: Adam Tackett <tackadam@amazon.com> * quick fix Signed-off-by: Adam Tackett <tackadam@amazon.com> --------- Signed-off-by: Adam Tackett <tackadam@amazon.com> Co-authored-by: Adam Tackett <tackadam@amazon.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: SuZhou-Joe <suzhou@amazon.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
* add job scheduler to observability CI Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update workflow for integ tests Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove datasources test Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * exclude localhost links from link checker Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update links for link checker Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
* Move the save button to the header control bar Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the save button and correct its size + position Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the date picker location Signed-off-by: Ryan Liang <jiallian@amazon.com> * Rename the navigation in coreRef and switch to use compressed date picker Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the popover Signed-off-by: Ryan Liang <jiallian@amazon.com> * Rename the button Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update to latest mockup Signed-off-by: Ryan Liang <jiallian@amazon.com> * Update snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> * Fix the ui issues Signed-off-by: Ryan Liang <jiallian@amazon.com> * Dummy metrics Signed-off-by: Ryan Liang <jiallian@amazon.com> * Remove dummy Signed-off-by: Ryan Liang <jiallian@amazon.com> * update snapshots Signed-off-by: Ryan Liang <jiallian@amazon.com> * minor changes to match mocks Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Ryan Liang <jiallian@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Co-authored-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
…roject#2048) * first step of MDS Signed-off-by: Adam Tackett <tackadam@amazon.com> * add mds support to getting started Signed-off-by: Adam Tackett <tackadam@amazon.com> * update references, renaming, code cleanup Signed-off-by: Adam Tackett <tackadam@amazon.com> * update snapshots, remove depend Signed-off-by: Adam Tackett <tackadam@amazon.com> * only add mds reference to index patterns Signed-off-by: Adam Tackett <tackadam@amazon.com> --------- Signed-off-by: Adam Tackett <tackadam@amazon.com> Co-authored-by: Adam Tackett <tackadam@amazon.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
…pensearch-project#2068) * Use EuiSmallButton Signed-off-by: Miki <miki@amazon.com> * Use EuiSmallButtonIcon Signed-off-by: Miki <miki@amazon.com> * Use EuiSmallButtonEmpty Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedFormRow Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedField* Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedSelect and EuiCompressedSuperSelect Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedFilePicker Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedRadio and EuiCompressedRadioGroup Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedSwitch Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedEuiTextArea Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedComboBox Signed-off-by: Miki <miki@amazon.com> * Use EuiSmallFilterButton Signed-off-by: Miki <miki@amazon.com> * Undo unnecessary EuiSmallButton* uses Signed-off-by: Miki <miki@amazon.com> * Use EuiCompressedSuperDatePicker Signed-off-by: Miki <miki@amazon.com> * Fix tests and snapshots Signed-off-by: Miki <miki@amazon.com> * Fix tests and snapshots Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Dan Dong <danieldong51@gmail.com> Signed-off-by: Adam Tackett <tackadam@amazon.com>
Signed-off-by: Adam Tackett <tackadam@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
New core plugin for dynamic content rendering OpenSearch-Dashboards#7201
(Overview of functionality)
Example.mov
(Before the change)
(After the change)
(The setting)
By default is empty, once the user selects a dashboard in the overview page it is updated so that it persist when they return to the page.
Issues Resolved
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.