Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support dark mode and session for sql, minor bug fixes #165

Merged
merged 7 commits into from
Oct 20, 2023
Merged

Support dark mode and session for sql, minor bug fixes #165

merged 7 commits into from
Oct 20, 2023

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Oct 19, 2023 •
edited
Loading

Description

  1. Dark mode update
  2. Removes custom theme partially for Oui compliance
  3. Session Id enabled
  4. Async query poll interval time changed to 2 seconds

Issues Resolved

#105

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@ps48 ps48 marked this pull request as draft October 19, 2023 22:00
@ps48 ps48 changed the title Support dark mode and editor theming from dev tools Support dark mode and session for sql, minor bug fixes Oct 19, 2023
@codecov
Copy link

codecov bot commented Oct 19, 2023 •
edited
Loading

Codecov Report

Merging #165 (7cffe25) into main (75f9cca) will decrease coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   59.02%   58.68%   -0.34%     
==========================================
  Files          33       32       -1     
  Lines        1452     1428      -24     
  Branches      237      234       -3     
==========================================
- Hits          857      838      -19     
+ Misses        575      570       -5     
  Partials       20       20
Flag Coverage Δ
dashboards-query-workbench 58.68% <ø> (-0.34%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@ps48 ps48 marked this pull request as ready for review October 20, 2023 20:59
mengweieric
mengweieric approved these changes Oct 20, 2023
View reviewed changes
public/utils/PanelWrapper.tsx
</div> : <>{children}</>;
</div>
) : (
<>{children}</>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need the same wrapping div here if shouldWrap == false?, just thinking if we need to keep the same styling regardless of shouldWrap flag

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll recheck in a bit, this is some legacy code from workbench.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked seems like we are only using this for SQL. I'll keep this as is for now. Will have to remove this piece during refactoring.

ps48 added 4 commits October 20, 2023 14:54
@ps48
suport dark mode and editor theming from dev tools
219d679 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48
remove sql editor theme, add session check
90ea1db 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48
update snapshots
87ce8f7 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48
minor fixes
40b6cb8 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48 ps48 force-pushed the dark_mode_session branch from c471fdb to 40b6cb8 Compare October 20, 2023 21:56
@ps48
fix import
472b48c 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
ps48 added 2 commits October 20, 2023 15:04
@ps48
fix job query url
d6569e4 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48
update poll interval to 2000
7cffe25 
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48 ps48 merged commit 937ff30 into opensearch-project:main Oct 20, 2023
8 of 9 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 20, 2023
@github-actions
Support dark mode and session for sql, minor bug fixes (#165)
f88003f 
* suport dark mode and editor theming from dev tools

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* remove sql editor theme, add session check

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update snapshots

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* minor fixes

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* fix import

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* fix job query url

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update poll interval to 2000

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 937ff30)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 20, 2023
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 20, 2023
@github-actions
Support dark mode and session for sql, minor bug fixes (#165)
f8f8747 
* suport dark mode and editor theming from dev tools

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* remove sql editor theme, add session check

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update snapshots

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* minor fixes

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* fix import

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* fix job query url

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* update poll interval to 2000

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

---------

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
(cherry picked from commit 937ff30)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Oct 20, 2023
Merged
ps48 pushed a commit that referenced this pull request Oct 23, 2023
@opensearch-trigger-bot @github-actions
Support dark mode and session for sql, minor bug fixes (#165) (#168)
6f5944d 
* suport dark mode and editor theming from dev tools



* remove sql editor theme, add session check



* update snapshots



* minor fixes



* fix import



* fix job query url



* update poll interval to 2000



---------


(cherry picked from commit 937ff30)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48 pushed a commit that referenced this pull request Oct 23, 2023
@opensearch-trigger-bot @github-actions
Support dark mode and session for sql, minor bug fixes (#165) (#169)
0f5673a 
* suport dark mode and editor theming from dev tools



* remove sql editor theme, add session check



* update snapshots



* minor fixes



* fix import



* fix job query url



* update poll interval to 2000



---------


(cherry picked from commit 937ff30)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 8, 2023
@mengweieric
Revert "Support dark mode and session for sql, minor bug fixes (opens…
607b01c 
…earch-project#165) (opensearch-project#169)"

This reverts commit 0f5673a.
mengweieric added a commit to mengweieric/dashboards-query-workbench that referenced this pull request Nov 8, 2023
@mengweieric
Revert "Support dark mode and session for sql, minor bug fixes (opens…
7da6aba 
…earch-project#165) (opensearch-project#169)"

This reverts commit 0f5673a.

Signed-off-by: Eric <menwe@amazon.com>
mengweieric added a commit that referenced this pull request Nov 13, 2023
@mengweieric
Revert commits back to after 2.11 release (#211)
32a7495 
* Revert "Fix error handling for user w/o proper permissions (#195) (#197)"

This reverts commit 26ed0dc.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Increment version to 2.11.1.0 (#186)"

This reverts commit b18f5f4.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "added fix for loading spinner issue for other database (#189) (#192)"

This reverts commit 94805c5.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "UI-bug fixes, added create query for MV (#182) (#188)"

This reverts commit 4187b6d.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Add backticks and remove ckpt for manual refresh in acceleration flyout (#183) (#185)"

This reverts commit f96c5d9.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Session update, minor fixes for acceleration flyout (#179) (#181)"

This reverts commit 257fb53.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "UI fixes for loading state, empty tree, added toast for error, fixed no indicies error (#176) (#178)"

This reverts commit 3c47d47.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Make checkpoint mandatory, add watermark delay, minor UI fixes (#173) (#175)"

This reverts commit 0198fa7.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "design changes for loading, changed the banner, updated tests (#170) (#172)"

This reverts commit 786c7c7.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Support dark mode and session for sql, minor bug fixes (#165) (#169)"

This reverts commit 0f5673a.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "Added changes for making tree view persistent, made changes for bugs for loading screen (#153) (#167)"

This reverts commit 2269d1d.

Signed-off-by: Eric <menwe@amazon.com>

* Revert "fixed create table async query bug (#158) (#163)"

This reverts commit 1964008.

Signed-off-by: Eric <menwe@amazon.com>

---------

Signed-off-by: Eric <menwe@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derek-ho derek-ho derek-ho left review comments

@mengweieric mengweieric mengweieric approved these changes

@YANG-DB YANG-DB YANG-DB approved these changes

@pjfitzgibbons pjfitzgibbons Awaiting requested review from pjfitzgibbons

@kavithacm kavithacm Awaiting requested review from kavithacm kavithacm is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@dai-chen dai-chen Awaiting requested review from dai-chen dai-chen is a code owner

@rupal-bq rupal-bq Awaiting requested review from rupal-bq

@vmmusings vmmusings Awaiting requested review from vmmusings

@Swiddis Swiddis Awaiting requested review from Swiddis Swiddis is a code owner

@penghuo penghuo Awaiting requested review from penghuo penghuo is a code owner

@seankao-az seankao-az Awaiting requested review from seankao-az seankao-az is a code owner

@MaxKsyunz MaxKsyunz Awaiting requested review from MaxKsyunz

@Yury-Fridlyand Yury-Fridlyand Awaiting requested review from Yury-Fridlyand Yury-Fridlyand is a code owner

@anirudha anirudha Awaiting requested review from anirudha anirudha is a code owner

Assignees
No one assigned
Labels
backport 2.x backport 2.11
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ps48 @derek-ho @YANG-DB @mengweieric