-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Session update, minor fixes for acceleration flyout #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
ps48
requested review from
pjfitzgibbons,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand and
anirudha
as code owners
October 25, 2023 05:40
Codecov Report
@@ Coverage Diff @@
## main #179 +/- ##
==========================================
- Coverage 58.21% 53.91% -4.31%
==========================================
Files 33 33
Lines 1546 1560 +14
Branches 270 274 +4
==========================================
- Hits 900 841 -59
- Misses 622 628 +6
- Partials 24 91 +67
Flags with carried forward coverage won't be shown. Click here to find out more. |
YANG-DB
approved these changes
Oct 25, 2023
mengweieric
approved these changes
Oct 25, 2023
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
ps48
changed the title
Remove clearing session from storage
Session update, minor fixes for acceleration flyout
Oct 25, 2023
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
* update session if not null Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * clear query and window on datasource selection Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update primary shard to 5 and MV index preview name Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update tumble input width and MV validation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update s3 regex Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Add toast for load failure in acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add error toasts for invalid job id Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 16e2e1c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Oct 25, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 25, 2023
* update session if not null Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * clear query and window on datasource selection Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update primary shard to 5 and MV index preview name Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update tumble input width and MV validation Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * update s3 regex Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Add toast for load failure in acc flyout Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * add error toasts for invalid job id Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> --------- Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> (cherry picked from commit 16e2e1c) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Oct 25, 2023
* update session if not null * clear query and window on datasource selection * update primary shard to 5 and MV index preview name * update tumble input width and MV validation * update s3 regex * Add toast for load failure in acc flyout * add error toasts for invalid job id --------- (cherry picked from commit 16e2e1c) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ps48
pushed a commit
that referenced
this pull request
Oct 25, 2023
* update session if not null * clear query and window on datasource selection * update primary shard to 5 and MV index preview name * update tumble input width and MV validation * update s3 regex * Add toast for load failure in acc flyout * add error toasts for invalid job id --------- (cherry picked from commit 16e2e1c) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
mengweieric
added a commit
to mengweieric/dashboards-query-workbench
that referenced
this pull request
Nov 8, 2023
mengweieric
added a commit
to mengweieric/dashboards-query-workbench
that referenced
this pull request
Nov 8, 2023
…ch-project#179) (opensearch-project#181)" This reverts commit 257fb53. Signed-off-by: Eric <menwe@amazon.com>
mengweieric
added a commit
that referenced
this pull request
Nov 13, 2023
* Revert "Fix error handling for user w/o proper permissions (#195) (#197)" This reverts commit 26ed0dc. Signed-off-by: Eric <menwe@amazon.com> * Revert "Increment version to 2.11.1.0 (#186)" This reverts commit b18f5f4. Signed-off-by: Eric <menwe@amazon.com> * Revert "added fix for loading spinner issue for other database (#189) (#192)" This reverts commit 94805c5. Signed-off-by: Eric <menwe@amazon.com> * Revert "UI-bug fixes, added create query for MV (#182) (#188)" This reverts commit 4187b6d. Signed-off-by: Eric <menwe@amazon.com> * Revert "Add backticks and remove ckpt for manual refresh in acceleration flyout (#183) (#185)" This reverts commit f96c5d9. Signed-off-by: Eric <menwe@amazon.com> * Revert "Session update, minor fixes for acceleration flyout (#179) (#181)" This reverts commit 257fb53. Signed-off-by: Eric <menwe@amazon.com> * Revert "UI fixes for loading state, empty tree, added toast for error, fixed no indicies error (#176) (#178)" This reverts commit 3c47d47. Signed-off-by: Eric <menwe@amazon.com> * Revert "Make checkpoint mandatory, add watermark delay, minor UI fixes (#173) (#175)" This reverts commit 0198fa7. Signed-off-by: Eric <menwe@amazon.com> * Revert "design changes for loading, changed the banner, updated tests (#170) (#172)" This reverts commit 786c7c7. Signed-off-by: Eric <menwe@amazon.com> * Revert "Support dark mode and session for sql, minor bug fixes (#165) (#169)" This reverts commit 0f5673a. Signed-off-by: Eric <menwe@amazon.com> * Revert "Added changes for making tree view persistent, made changes for bugs for loading screen (#153) (#167)" This reverts commit 2269d1d. Signed-off-by: Eric <menwe@amazon.com> * Revert "fixed create table async query bug (#158) (#163)" This reverts commit 1964008. Signed-off-by: Eric <menwe@amazon.com> --------- Signed-off-by: Eric <menwe@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Issues Resolved
#127
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.