Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to actions/upload-artifact@v4 #1310

Closed
wants to merge 2 commits into from

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Nov 25, 2024

Description

Upgrade to actions/upload-artifact@v4

Modeled after opensearch-project/job-scheduler#702

Related Issues

Resolves #1304

Check List

  • New functionality includes testing.
  • New functionality has been documented.
  • API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Copy link
Collaborator

@Hailong-am Hailong-am left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for CI pass

@cwperks
Copy link
Member Author

cwperks commented Dec 13, 2024

@Hailong-am Sorry I meant to close this PR. This change is included on #1311 and that PR will fix all CI checks.

@cwperks cwperks closed this Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Github Action Deprecation: actions/upload-artifact@v3
2 participants