Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable custom start commands and options to resolve GHA issues #702

Merged

Conversation

peterzhuamazon
Copy link
Member

@peterzhuamazon peterzhuamazon commented Nov 11, 2024

Description

Enable custom start commands and options to resolve GHA issues

Related Issues

Closes #698
#700
opensearch-project/opensearch-build#5178

Check List

  • [ ] New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@peterzhuamazon peterzhuamazon added the enhancement New feature or request label Nov 11, 2024
@peterzhuamazon peterzhuamazon self-assigned this Nov 11, 2024
@peterzhuamazon peterzhuamazon changed the title Enforce node16 for ci workflow runs Enforce node20 for ci workflow runs on AL2 Nov 14, 2024
@peterzhuamazon peterzhuamazon changed the title Enforce node20 for ci workflow runs on AL2 Enable custom start commands and options to resolve GHA issues Nov 15, 2024
@peterzhuamazon
Copy link
Member Author

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.67%. Comparing base (3ec460a) to head (f4a59a2).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #702   +/-   ##
=========================================
  Coverage     37.67%   37.67%           
  Complexity      135      135           
=========================================
  Files            22       22           
  Lines          1189     1189           
  Branches        109      109           
=========================================
  Hits            448      448           
  Misses          704      704           
  Partials         37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peterzhuamazon peterzhuamazon merged commit ea02229 into opensearch-project:main Nov 15, 2024
14 of 15 checks passed
@peterzhuamazon peterzhuamazon deleted the update-nodejs-compat branch November 15, 2024 20:14
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 15, 2024
Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
(cherry picked from commit ea02229)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/job-scheduler/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/job-scheduler/backport-1.3
# Create a new branch
git switch --create backport/backport-702-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 ea022295bf2c6fb3b81429d870b4f6b0e1a7a6d6
# Push it to GitHub
git push --set-upstream origin backport/backport-702-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/job-scheduler/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-702-to-1.3.

peterzhuamazon pushed a commit that referenced this pull request Nov 15, 2024
…#703)

(cherry picked from commit ea02229)

Signed-off-by: Peter Zhu <zhujiaxi@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Github Action Deprecation: actions/upload-artifact@v3
2 participants