Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Communication mechanism for js #289
Communication mechanism for js #289
Changes from 3 commits
7b23218
ecb3462
692d659
97e783b
b97d08a
92e5a15
da64ca7
5eb8dc5
21dfd75
15e9e2e
c9933e6
ff9e493
7933c4e
37c8d0d
7879155
1367c02
a27c263
f4e36f0
0b62209
fac7c69
1494680
dbc9382
6796447
eb1ccb6
3ef8a3c
b726e5c
a123089
d6bea89
3613ec8
9a881dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why
opendistro
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, I am changing it to plugins. The reason to change as suggested by @saratvemulapalli is
opendistro is part of ODFE: https://opendistro.github.io/for-elasticsearch/ which end of life.
AD security features were built in ODFE which is why it has legacy code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to understand, a. do we need to check if they are null?
b. And would they be ever null?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we do have to check if they are null or not as while testing if we provide no value then it should handle that test case gracefully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the api call will be made then the job index will never be null.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nulls are dangerous and usually best avoided. Personal preference is to try to use
Optional
instead. I can be convinced to stick with null but will ask for it to be amply documented in that case.Looking at all the classes in this PR, it seems that we always require
jobType
to be non-null, but the other values are allowed to be null. That isn't obvious from looking at this class in isolation. I suggest:jobType
before returning here, and throw an appropriate parsing exception here if it is null.@Nullable
annotation to the getters for the other three fields.@Nullable
annotation to each of the (allowed to be null) parameters on the constructor.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done