Communication mechanism for js #289

vibrantvarun · 2022-12-29T19:23:38Z

Description

Get Job Index and Get Job Type Api's to fetch job details for Job Scheduler

Issues Resolved

opensearch-project/opensearch-sdk-java#274

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Varun Jain <varunudr@amazon.com>

src/main/java/org/opensearch/jobscheduler/JobSchedulerPlugin.java

src/test/java/org/opensearch/jobscheduler/transport/GetJobTypeTransportActionTests.java

codecov-commenter · 2022-12-29T19:51:15Z

Codecov Report

Merging #289 (3613ec8) into main (b67c000) will decrease coverage by 12.75%.
The diff coverage is 23.75%.

@@              Coverage Diff              @@
##               main     #289       +/-   ##
=============================================
- Coverage     52.33%   39.58%   -12.76%     
- Complexity       65       90       +25     
=============================================
  Files             8       14        +6     
  Lines           449      811      +362     
  Branches         50       82       +32     
=============================================
+ Hits            235      321       +86     
- Misses          195      469      +274     
- Partials         19       21        +2

Impacted Files	Coverage Δ
...rg/opensearch/jobscheduler/JobSchedulerPlugin.java	`33.92% <0.00%> (-2.61%)`	⬇️
.../org/opensearch/jobscheduler/model/JobDetails.java	`0.00% <0.00%> (ø)`
...ensearch/jobscheduler/utils/JobDetailsService.java	`3.70% <3.70%> (ø)`
...search/jobscheduler/rest/RestGetJobTypeAction.java	`47.61% <47.61%> (ø)`
...earch/jobscheduler/rest/RestGetJobIndexAction.java	`50.00% <50.00%> (ø)`
...arch/jobscheduler/transport/GetJobTypeRequest.java	`50.00% <50.00%> (ø)`
...rch/jobscheduler/transport/GetJobIndexRequest.java	`51.06% <51.06%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Varun Jain <varunudr@amazon.com>

joshpalis

Doing an initial pass

src/main/java/org/opensearch/jobscheduler/JobSchedulerPlugin.java

src/main/java/org/opensearch/jobscheduler/constant/CommonValue.java

src/main/java/org/opensearch/jobscheduler/model/JobDetails.java

src/main/java/org/opensearch/jobscheduler/rest/RestGetJobIndexAction.java

src/main/java/org/opensearch/jobscheduler/utils/RestHandlerUtils.java

src/test/java/org/opensearch/jobscheduler/rest/RestGetJobIndexActionTests.java

src/test/java/org/opensearch/jobscheduler/rest/RestGetJobTypeActionTests.java

src/test/java/org/opensearch/jobscheduler/transport/GetJobTypeTransportActionTests.java

src/test/java/org/opensearch/jobscheduler/transport/GetJobIndexTransportActionTests.java

src/test/java/org/opensearch/jobscheduler/rest/RestGetJobTypeActionTests.java

src/test/java/org/opensearch/jobscheduler/TestHelpers.java

src/main/java/org/opensearch/jobscheduler/rest/RestGetJobTypeAction.java

src/test/java/org/opensearch/jobscheduler/rest/RestGetJobIndexActionTests.java

src/main/java/org/opensearch/jobscheduler/rest/RestGetJobIndexAction.java

src/main/java/org/opensearch/jobscheduler/JobSchedulerPlugin.java

Signed-off-by: Varun Jain <varunudr@amazon.com>

src/main/java/org/opensearch/jobscheduler/JobSchedulerPlugin.java

src/main/java/org/opensearch/jobscheduler/model/JobDetails.java

src/main/java/org/opensearch/jobscheduler/transport/GetJobIndexRequest.java

src/main/java/org/opensearch/jobscheduler/utils/RestHandlerUtils.java

src/test/java/org/opensearch/jobscheduler/TestHelpers.java

src/test/java/org/opensearch/jobscheduler/rest/RestGetJobIndexActionTests.java

src/test/java/org/opensearch/jobscheduler/rest/RestGetJobTypeActionTests.java

src/test/java/org/opensearch/jobscheduler/transport/GetJobTypeTransportActionTests.java

Signed-off-by: Varun Jain <varunudr@amazon.com>

joshpalis

LGTM

Signed-off-by: Varun Jain <varunudr@amazon.com>

dbwiddis

Looks great!

Signed-off-by: Varun Jain <varunudr@amazon.com>

joshpalis

Doing an initial pass

src/test/java/org/opensearch/jobscheduler/ODFERestTestCase.java

src/test/java/org/opensearch/jobscheduler/multinode/GetJobDetailsMultiNodeRestIT.java

src/test/java/org/opensearch/jobscheduler/rest/RestGetJobIndexActionTests.java

src/test/java/org/opensearch/jobscheduler/rest/RestGetJobTypeActionTests.java

I dont think I can get to this today, feel free to merge the changes if you get the approvals.

Signed-off-by: Varun Jain <varunudr@amazon.com>

dbwiddis · 2023-01-05T18:48:11Z

build.gradle

@@ -238,7 +240,8 @@ task integTestRemote(type: RestIntegTestTask) {
    systemProperty "security", System.getProperty("security")
    systemProperty "user", System.getProperty("user")
    systemProperty "password", System.getProperty("password")
-
+    systemProperty 'tests.rest.cluster', 'localhost:9200'


(Style) Something about hardcoding a port here seems off to me, but I'm not sure what a better choice is. So probably ok.

dbwiddis · 2023-01-05T18:56:47Z

src/main/java/org/opensearch/jobscheduler/utils/JobDetailsService.java

+     *
+     * @param extensionId unique id to find the job details document in the index
+     * @param listener an {@code ActionListener} that has onResponse and onFailure that is used to return the job details if it was found
+     *      *                 or else null.


(Nit) stray *

dbwiddis · 2023-01-05T18:57:00Z

src/main/java/org/opensearch/jobscheduler/utils/JobDetailsService.java

+     *
+     * @param extensionId unique id to find and delete the job details document in the index
+     * @param listener an {@code ActionListener} that has onResponse and onFailure that is used to return the job details if it was deleted
+     *      *                 or else null.


another stray *

dbwiddis · 2023-01-05T18:57:19Z

src/main/java/org/opensearch/jobscheduler/utils/JobDetailsService.java

+     * @param updateJobDetails update job details object entry
+     * @param extensionId unique id to find and update the corresponding document mapped to it
+     * @param listener an {@code ActionListener} that has onResponse and onFailure that is used to return the job details if it was updated
+     *      *                 or else null.


copypaste *?

dbwiddis · 2023-01-05T19:37:19Z

src/main/java/org/opensearch/jobscheduler/utils/JobDetailsService.java

+    /**
+     *
+     * @param listener an {@code ActionListener} that has onResponse and onFailure that is used to return the job details index if it was created
+     *      *                 or else null.


Going to stop tagging these *'s now.

dbwiddis · 2023-01-05T20:38:01Z

src/main/java/org/opensearch/jobscheduler/utils/JobDetailsService.java

+            isJobIndexRequest = true;
+            if (jobIndexName == null) {
+                listener.onFailure(new IllegalArgumentException("Job Index Name should not be null"));
+            } else if (jobParameterActionName == null) {


Since none of these can be null, seems we should include all of them in one exception. So a single if check whether any are null, and an IAE listing which ones are null.

src/main/java/org/opensearch/jobscheduler/utils/JobDetailsService.java

dbwiddis · 2023-01-05T20:42:07Z

src/main/java/org/opensearch/jobscheduler/utils/JobDetailsService.java

+            }
+        }
+        if (extensionId == null) {
+            listener.onFailure(new IllegalArgumentException("Extension Id should not be null"));


"Should" or "must" have formalized meaning in standards. Must is absolutely a requirement (error if wrong) while should is a recommendation. These error messages should conform.

dbwiddis · 2023-01-05T20:43:00Z

src/test/java/org/opensearch/jobscheduler/ODFERestTestCase.java

+        return Settings.builder()
+            // disable the warning exception for admin client since it's only used for cleanup.
+            .put("strictDeprecationMode", false)
+            .put("http.port", 9200)


Can we make the 9200 a constant at the top of the class?

src/test/java/org/opensearch/jobscheduler/multinode/GetJobDetailsMultiNodeRestIT.java

Signed-off-by: Varun Jain <varunudr@amazon.com>

…duler

Signed-off-by: Varun Jain <varunudr@amazon.com>

joshpalis

LGTM other than the exception handling for the timeouts.

src/main/java/org/opensearch/jobscheduler/rest/RestGetJobIndexAction.java

Signed-off-by: Varun Jain <varunudr@amazon.com>

dbwiddis · 2023-01-06T17:27:27Z

src/main/java/org/opensearch/jobscheduler/rest/RestGetJobIndexAction.java

+                @Override
+                public void onFailure(Exception e) {
+                    logger.info("could not process job index", e);
+                    jobDetailsResponseHolder[0] = null;


This isn't necessary as the value is already null from the array instantiation. It's reasonable from a readability standpoint to add a comment here indicating this remains null.

dbwiddis · 2023-01-06T17:30:33Z

src/main/java/org/opensearch/jobscheduler/rest/RestGetJobIndexAction.java

+
+        try {
+            inProgressFuture.orTimeout(JobDetailsService.TIME_OUT_FOR_REQUEST, TimeUnit.SECONDS);
+            inProgressFuture.get(JobDetailsService.TIME_OUT_FOR_REQUEST, TimeUnit.SECONDS);


You don't need the timeout on both, they'll run sequentially. Suggest you do

inProgressFuture.orTimeout(JobDetailsService.TIME_OUT_FOR_REQUEST, TimeUnit.SECONDS).get();

... or .join() which throws different types of exceptions, doesn't throw checked exceptions, and may be preferred depending on how you choose to handle the exceptions. Specifically, .get() requires you to catch InterruptedException and ExecutionException) while .join() does not.

dbwiddis · 2023-01-06T17:37:54Z

src/main/java/org/opensearch/jobscheduler/rest/RestGetJobIndexAction.java

+        return channel -> {
+            XContentBuilder builder = channel.newBuilder();
+            RestStatus restStatus = RestStatus.OK;
+            String restResponse = jobDetailsResponseHolder[0] != null ? "success" : "failed";


(Style/Naming) So this isn't confused with the bytesRestResponse, suggest either restResponseValue or restResponseString or similar here.

dbwiddis · 2023-01-06T17:39:00Z

src/main/java/org/opensearch/jobscheduler/rest/RestGetJobTypeAction.java

+
+        try {
+            inProgressFuture.orTimeout(JobDetailsService.TIME_OUT_FOR_REQUEST, TimeUnit.SECONDS);
+            inProgressFuture.get();


This is the correct sequential way to handle (or you could chain .get() on the previous line, or .join(). Same comments regarding handling timeout exception differently than an exception during execution.

dbwiddis · 2023-01-06T17:40:12Z

src/main/java/org/opensearch/jobscheduler/rest/RestGetJobTypeAction.java

+        return channel -> {
+            XContentBuilder builder = channel.newBuilder();
+            RestStatus restStatus = RestStatus.OK;
+            String restResponse = jobDetailsResponseHolder[0] != null ? "success" : "failed";


Same comments regarding naming.

dbwiddis · 2023-01-06T17:42:53Z

src/main/java/org/opensearch/jobscheduler/utils/JobDetailsService.java

+    }
+
+    /**
+     *


Need a description of what the method actually does.

dbwiddis · 2023-01-06T17:50:41Z

src/main/java/org/opensearch/jobscheduler/model/JobDetails.java

+        if (jobRunnerAction != null) {
+            xContentBuilder.field(JOB_RUNNER_ACTION, jobRunnerAction);
+        }
+        return xContentBuilder.endObject();


Nulls are dangerous and usually best avoided. Personal preference is to try to use Optional instead. I can be convinced to stick with null but will ask for it to be amply documented in that case.

Looking at all the classes in this PR, it seems that we always require jobType to be non-null, but the other values are allowed to be null. That isn't obvious from looking at this class in isolation. I suggest:

Test the value of jobType before returning here, and throw an appropriate parsing exception here if it is null.

Add the @Nullable annotation to the getters for the other three fields.

Add the @Nullable annotation to each of the (allowed to be null) parameters on the constructor.

Add a javadoc somewhere (perhaps the class itself, or this parsing method) indicating the allowed/disallowed nulls.

Signed-off-by: Varun Jain <varunudr@amazon.com>

…#382) * Communication mechanism for js (#289) * Job Details from Extension for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Commnunication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Commnunication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Commnunication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Commnunication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Commnunication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Commnunication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> * Communication Mechanism for JS Signed-off-by: Varun Jain <varunudr@amazon.com> Signed-off-by: Varun Jain <varunudr@amazon.com> * [Extensions] Synchronize opensearch-plugin-job-details with JobDetailsService map (#299) * Added JobDetailsService as an indexOperationListener to synchronize metadata index with internal job details m and indicesToListen set. Signed-off-by: Joshua Palis <jpalis@amazon.com> * Changes indexToJobDetails to a ConcurrentMap, adds getter method for indexToJobDetails Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments, fixing log message Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments Signed-off-by: Joshua Palis <jpalis@amazon.com> * Added test to updateIndexToJobDetails Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments, changing extensionId to extensionUniqueId Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR Comments : Updating Job Details index Name and mapping file to opensearch-job-scheduler-job-details Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments, enabling extensions to submit more than 1 job details entry to support extensions registering multiple types of jobs, updated all integration, multinode tests now that the rest response value is the document Id Signed-off-by: Joshua Palis <jpalis@amazon.com> * Renaming TestHelper base URI name Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments, made multinode test request strings constant Signed-off-by: Joshua Palis <jpalis@amazon.com> Signed-off-by: Joshua Palis <jpalis@amazon.com> * [Extensions] Create a proxy ScheduledJobRunner, ScheduledJobParser to invoke corresponding registered Job Detail actions (#306) * Draft : Added JobParameterRequest to translate ScheduledJobParser parameters nto compatible inputs for the ExtensionActionRequest. Completed initial proxy scheduled job parser implementation. Added ExtensionJobParameter class to deserialize ExtensionActionResponsebyte array into an object of type ScheduledJobParameter Signed-off-by: Joshua Palis <jpalis@amazon.com> * Added JobRunnerRequest, modified JobExecutionContext to implement writeable, created initial proxy ScheduledJobRunner, fixed failing tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * Added generic ExtensionJobActionRequest that extends ExtensionActionRequest, modified JobParameter/Runner request to implement writeable, refactored proxy object creation so that the requests are added to the ExtensionJobActionRequest, which in turn upcasts the request into an ExtensionActionRequest Signed-off-by: Joshua Palis <jpalis@amazon.com> * Added byte array constructors for the JobRunner/Parameter requests, added javadocs Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing javadocs Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing javadocs Signed-off-by: Joshua Palis <jpalis@amazon.com> * Added placeholder string for an eventual access token to be sent to extensions to validate prior to invoking an action Signed-off-by: Joshua Palis <jpalis@amazon.com> * Added ExtensionJobActionResponse, JobParameterResponse, JobRunnerResponse to facilitate the response of extension actions Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing javadocs Signed-off-by: Joshua Palis <jpalis@amazon.com> * Added JobRunnerResponse handling Signed-off-by: Joshua Palis <jpalis@amazon.com> * Separating updateIndexToJobProviders into separate methods Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing javadocs Signed-off-by: Joshua Palis <jpalis@amazon.com> * SpotlessApply Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments Signed-off-by: Joshua Palis <jpalis@amazon.com> * Added tests for serialization/deserialization of JobExecutionContext, JobDocVersion, ExtensionJobParameter, ExtensionJobActionRequest, ExtensionJobActionResponse, JobRunner/JobParameter/Request/Response Signed-off-by: Joshua Palis <jpalis@amazon.com> * Writing ExtensionActionRequest/Response to bytestream output to test deserialization Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing imports Signed-off-by: Joshua Palis <jpalis@amazon.com> * Changing to extensionActionResponse constructor Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding tests for updateIndexToJobProviders Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments, added getters for lock duration seconds and jitter values, added javadocs to ScheduleType enum and made this public Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing Strings dependency from lock model to fix BWC tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixes BWC fullRestartClusterTask, rollingUpgradeClusterTask, oldVersionCluster task. mixedClusterTask is still failing Signed-off-by: Joshua Palis <jpalis@amazon.com> * Modified createProxyScheduledJobRunner to return the document Id of the extension job parameter entry within the registered job index, modifed the ExtensionJobParameter to null check the jitter value and setting this to 0.0 if null Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com> * [Extensions] Exposes a GetLock REST API to enable extensions to acquire a lock model for their job execution (#311) * Added RestGetLockAction API, added AcquireLockRequest, enables extensions to retrieve a lock model object to run their Job Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding Lock ID field to RestGetLockAction response Signed-off-by: Joshua Palis <jpalis@amazon.com> * Added multi node integration tests for GetLockApi Signed-off-by: Joshua Palis <jpalis@amazon.com> * Making lock service in RestGetLockAction private Signed-off-by: Joshua Palis <jpalis@amazon.com> * Added Rest integration tests for RestGetLockAction Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments Signed-off-by: Joshua Palis <jpalis@amazon.com> * Updating get lock rest path in tests Signed-off-by: Joshua Palis <jpalis@amazon.com> * Addressing PR comments Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com> * Communication Mechanism Work Item 6 Release lock api (#312) * Release lock API Signed-off-by: Varun Jain <varunudr@amazon.com> * Release Lock API Signed-off-by: Varun Jain <varunudr@amazon.com> * Release Lock API Signed-off-by: Varun Jain <varunudr@amazon.com> * Release Lock API Signed-off-by: Varun Jain <varunudr@amazon.com> * Reformatting Signed-off-by: Varun Jain <varunudr@amazon.com> * Reformatting Signed-off-by: Varun Jain <varunudr@amazon.com> * Reformatting Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing Dan's Comments Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing Dan's Comments Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing Sarat's Comments Signed-off-by: Varun Jain <varunudr@amazon.com> * Addressing Sarat's Comments Signed-off-by: Varun Jain <varunudr@amazon.com> * Fixing test cases Signed-off-by: Varun Jain <varunudr@amazon.com> * Fixing test cases Signed-off-by: Varun Jain <varunudr@amazon.com> * Fixing ReleaseLocktestcase Signed-off-by: Varun Jain <varunudr@amazon.com> * Fixing ReleaseLocktestcase Signed-off-by: Varun Jain <varunudr@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com> * Bumping BWC version to 2.7 and Fixing xcontent imports (#322) * [Extensions] Add all fields of LockModel to RestGetLockAction response (#342) * Modifies the RestGetLockAction response to include all fields of the lock model object, rather than the lock model object itself Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removing unused fields Signed-off-by: Joshua Palis <jpalis@amazon.com> * reverting field removal Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding lockID to back to response Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adding checks to multinode get lock rest integration tests to ensure that all response fields are populated Signed-off-by: Joshua Palis <jpalis@amazon.com> * fixing lock time parsing Signed-off-by: Joshua Palis <jpalis@amazon.com> * Adds a new Response class to house serde logic for RestGetLockAction response Signed-off-by: Joshua Palis <jpalis@amazon.com> * Moving parser.nextToken() within AcquireLockResponse.parse() Signed-off-by: Joshua Palis <jpalis@amazon.com> * Implementing toXContentObject for AcquireLockRequest Signed-off-by: Joshua Palis <jpalis@amazon.com> * Moving AcquireLockResponse to transpor package Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com> * Increasing JobDetailsService request timeoufrom 10 to 15, since the initial job detail registration request will initialize the job details metadata index, which takes some time (#346) Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixes serde logic for proxy scheduled jobrunner/parser requests/responses (#349) Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixes serde logic for JobParameterRequest/JobRunnerRequest. Removes extra trimming of request bytes for the streaminput constructor for the JobParameter/RunnerRequest, as this is already trimmed by the SDK prior to forwarding the actionrequest to the transport action (#351) Signed-off-by: Joshua Palis <jpalis@amazon.com> * [Extensions] Makes JobRunner/Parameter/Request/Response classes extend from ActionRequest/Response (#352) * Replaces ExtensionActionRequest class name with the JobParameter/RunnerRequest fully qualified class names, modifes JobParameter/Runner/Request/Response classes to extend from ActionRequest/Response Signed-off-by: Joshua Palis <jpalis@amazon.com> * Removes ExtensionJobActionResponse and fixes affected test classes Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing javadocs Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Joshua Palis <jpalis@amazon.com> * Consuming breaking changes from moving ExtensionActionRequest (#381) Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> * spotless Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing apache imports for TestHelpers class Signed-off-by: Joshua Palis <jpalis@amazon.com> * Modofies ODFERestTestCase to work with 2.x Signed-off-by: Joshua Palis <jpalis@amazon.com> * Fixing wipeAllODFEIndices Signed-off-by: Joshua Palis <jpalis@amazon.com> --------- Signed-off-by: Varun Jain <varunudr@amazon.com> Signed-off-by: Joshua Palis <jpalis@amazon.com> Signed-off-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> Co-authored-by: Varun Jain <varunudr@amazon.com> Co-authored-by: Sarat Vemulapalli <vemulapallisarat@gmail.com>

vibrantvarun added 3 commits December 27, 2022 14:14

Job Details from Extension for JS

7b23218

Signed-off-by: Varun Jain <varunudr@amazon.com>

Communication Mechanism for JS

ecb3462

Signed-off-by: Varun Jain <varunudr@amazon.com>

Communication mechanism for JS

692d659

Signed-off-by: Varun Jain <varunudr@amazon.com>

vibrantvarun requested a review from a team December 29, 2022 19:23

Communication mechanism for JS

97e783b

Signed-off-by: Varun Jain <varunudr@amazon.com>

dbwiddis requested changes Dec 29, 2022

View reviewed changes

vibrantvarun added 4 commits December 29, 2022 12:14

Communication mechanism for JS

b97d08a

Signed-off-by: Varun Jain <varunudr@amazon.com>

Communication mechanism for JS

92e5a15

Signed-off-by: Varun Jain <varunudr@amazon.com>

Commnunication Mechanism for JS

da64ca7

Signed-off-by: Varun Jain <varunudr@amazon.com>

Commnunication Mechanism for JS

5eb8dc5

Signed-off-by: Varun Jain <varunudr@amazon.com>

vibrantvarun force-pushed the Communication_Mechanism_For_JS branch from 92e5a15 to 5eb8dc5 Compare December 29, 2022 22:02

vibrantvarun requested a review from dbwiddis December 29, 2022 22:38

joshpalis requested review from joshpalis and saratvemulapalli December 29, 2022 22:39

joshpalis reviewed Dec 29, 2022

View reviewed changes

dbwiddis requested changes Dec 29, 2022

View reviewed changes

vibrantvarun added 2 commits December 29, 2022 16:03

Commnunication Mechanism for JS

21dfd75

Signed-off-by: Varun Jain <varunudr@amazon.com>

Commnunication Mechanism for JS

15e9e2e

Signed-off-by: Varun Jain <varunudr@amazon.com>

vibrantvarun requested review from joshpalis and dbwiddis December 30, 2022 00:23

dbwiddis requested changes Dec 30, 2022

View reviewed changes

Commnunication Mechanism for JS

c9933e6

Signed-off-by: Varun Jain <varunudr@amazon.com>

joshpalis previously approved these changes Dec 30, 2022

View reviewed changes

vibrantvarun requested a review from dbwiddis December 30, 2022 19:07

Commnunication Mechanism for JS

ff9e493

Signed-off-by: Varun Jain <varunudr@amazon.com>

vibrantvarun dismissed joshpalis’s stale review via ff9e493 December 30, 2022 19:26

vibrantvarun requested a review from joshpalis December 30, 2022 19:26

dbwiddis previously approved these changes Dec 30, 2022

View reviewed changes

joshpalis previously approved these changes Dec 30, 2022

View reviewed changes

vibrantvarun added 2 commits January 4, 2023 17:04

Communication Mechanism for JS

f4e36f0

Signed-off-by: Varun Jain <varunudr@amazon.com>

Communication Mechanism for JS

0b62209

Signed-off-by: Varun Jain <varunudr@amazon.com>

joshpalis reviewed Jan 5, 2023

View reviewed changes

vibrantvarun added 3 commits January 5, 2023 12:10

Communication Mechanism for JS

fac7c69

Signed-off-by: Varun Jain <varunudr@amazon.com>

Communication Mechanism for JS

1494680

Signed-off-by: Varun Jain <varunudr@amazon.com>

Communication Mechanism for JS

dbc9382

Signed-off-by: Varun Jain <varunudr@amazon.com>

dbwiddis requested changes Jan 5, 2023

View reviewed changes

vibrantvarun added 3 commits January 5, 2023 15:12

Communication Mechanism for JS

6796447

Signed-off-by: Varun Jain <varunudr@amazon.com>

Merge branch 'main' of https://github.com/opensearch-project/job-sche…

eb1ccb6

…duler

Merge branch 'main' into Communication_Mechanism_For_JS

3ef8a3c

vibrantvarun requested review from joshpalis and dbwiddis January 5, 2023 23:20

vibrantvarun added 3 commits January 5, 2023 15:23

Communication Mechanism for JS

b726e5c

Signed-off-by: Varun Jain <varunudr@amazon.com>

Communication Mechanism for JS

a123089

Signed-off-by: Varun Jain <varunudr@amazon.com>

Communication Mechanism for JS

d6bea89

Signed-off-by: Varun Jain <varunudr@amazon.com>

joshpalis previously approved these changes Jan 6, 2023

View reviewed changes

src/main/java/org/opensearch/jobscheduler/rest/RestGetJobIndexAction.java Show resolved Hide resolved

Communication Mechanism for JS

3613ec8

Signed-off-by: Varun Jain <varunudr@amazon.com>

vibrantvarun dismissed joshpalis’s stale review via 3613ec8 January 6, 2023 03:06

dbwiddis requested changes Jan 6, 2023

View reviewed changes

Communication Mechanism for JS

9a881dc

Signed-off-by: Varun Jain <varunudr@amazon.com>

vibrantvarun requested review from dbwiddis and joshpalis January 6, 2023 19:56

dbwiddis approved these changes Jan 6, 2023

View reviewed changes

joshpalis approved these changes Jan 6, 2023

View reviewed changes

joshpalis merged commit 2c9084b into opensearch-project:main Jan 6, 2023

vibrantvarun deleted the Communication_Mechanism_For_JS branch January 6, 2023 23:30

prudhvigodithi mentioned this pull request Jul 3, 2024

Update the job-scheduler plugin documentation with the list of supported API's #648

Open

dbwiddis mentioned this pull request Jul 30, 2024

Fix system index compatibility with v1 templates #658

Merged

1 task

+                  }
+                  /**
+                   *

Communication mechanism for js #289

Communication mechanism for js #289

Conversation

vibrantvarun commented Dec 29, 2022 • edited Loading

Description

Issues Resolved

Check List

codecov-commenter commented Dec 29, 2022 • edited Loading

Codecov Report

joshpalis left a comment

Choose a reason for hiding this comment

joshpalis left a comment

Choose a reason for hiding this comment

dbwiddis left a comment

Choose a reason for hiding this comment

joshpalis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joshpalis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vibrantvarun commented Dec 29, 2022 •

edited

Loading

codecov-commenter commented Dec 29, 2022 •

edited

Loading