-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Gradle 8.0.2 #348
Conversation
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #348 +/- ##
============================================
- Coverage 29.12% 28.94% -0.18%
Complexity 97 97
============================================
Files 23 23
Lines 1171 1171
Branches 109 109
============================================
- Hits 341 339 -2
- Misses 809 811 +2
Partials 21 21
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we set this repo up to do version bumps with Mend Renovate?
Any reason we're holding off on this merge? |
I don't have the ability to merge PRs in this repo |
Will re-run checks and merge this in once there is a successful 2.7.0 distribution opensearch build. Currently the tests are failing due to :
|
If it's going to be a long time until the upgrade, can we at least bump to 7.6+? The current config is 7.5 which is not compatible with JDK 19+. |
@dbwiddis Shouldn't take long. 2.7.0 distribution opensearch builds have been failing due to neural search but I see that this issue has been called out and will probably be resolved today. Either way, we won't be able to merge any change in until a successful build has been generated. |
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-348-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 6892ef0a27ad40788576404f13944c762dbf9a9d
# Push it to GitHub
git push --set-upstream origin backport/backport-348-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
@cwperks should we backport this to 2.x? |
@joshpalis Yes, this should be backported. |
I can create a manual backport |
* Update to Gradle 8.0.2 Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add validateNebulaPom.enabled = false back in Signed-off-by: Craig Perkins <cwperx@amazon.com> * Run spotlessApply Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 6892ef0)
@joshpalis I created a backport PR to 2.x for this change: #357 |
* Update to Gradle 8.0.2 Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add validateNebulaPom.enabled = false back in Signed-off-by: Craig Perkins <cwperx@amazon.com> * Run spotlessApply Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 6892ef0)
@cwperks seems that upgrading gradle to 8.0.2 has broken the maven publish snapshots workflow. Snapshots for 3.x and 2.x have not been updated since March 28th see https://github.com/opensearch-project/job-scheduler/actions/runs/4600506610/jobs/8127183785
|
* Update to Gradle 8.0.2 Signed-off-by: Craig Perkins <cwperx@amazon.com> * Add validateNebulaPom.enabled = false back in Signed-off-by: Craig Perkins <cwperx@amazon.com> * Run spotlessApply Signed-off-by: Craig Perkins <cwperx@amazon.com> --------- Signed-off-by: Craig Perkins <cwperx@amazon.com> (cherry picked from commit 6892ef0) Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Description
Starting a draft pull request to understand required efforts for migration to gradle 8. Reference PR from core: opensearch-project/OpenSearch#5666
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.