Fix the Maven publish #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prudhvigodithi
requested review from
joshpalis,
saratvemulapalli,
dbwiddis,
kaituo and
vibrantvarun
as code owners
|
Hey @vibrantvarun @cwperks can you please review? this should fix the issue that we see with JS maven publish. |
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #379 +/- ##
============================================
- Coverage 28.77% 28.69% -0.09%
+ Complexity 97 96 -1
============================================
Files 22 22
Lines 1178 1178
Branches 109 109
============================================
- Hits 339 338 -1
Misses 818 818
- Partials 21 22 +1 |
|
Hi @prudhvigodithi, thank you for raising this PR! It looks like the I see that this reintroduces |
|
Hey @cwperks thanks for checking, this PR targets removing all the code added that will hijack the task dependencies, adding task dependencies on the fly in |
cwperks
approved these changes
May 8, 2023
|
@prudhvigodithi Thank you for the explanation. I'm not sure what changed in gradle 8 that made the If we can use other commands in place of a single command to publish all artifacts than that sounds fine to me. |
|
Testing on my local machine. |
|
Hey @prudhvigodithi facing below error while testing on my local machine |
|
Thanks @vibrantvarun that error does not look like the error related to this PR? (Did not throw in the CI checks as well) @cwperks can you also please test on your local once ? |
|
|
@prudhvigodithi I do not receive that error on my local machine. @vibrantvarun did you have any issues when checking out Prudvhi's branch that prevented the switching to the branch? |
vibrantvarun
approved these changes
May 8, 2023
joshpalis
approved these changes
May 8, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
May 8, 2023
Signed-off-by: Prudhvi Godithi <pgodithi@amazon.com> (cherry picked from commit 946b0ca)
vibrantvarun
pushed a commit
that referenced
this pull request
May 8, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.7 2.7
# Navigate to the new working tree
cd .worktrees/backport-2.7
# Create a new branch
git switch --create backport/backport-379-to-2.7
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 946b0cafecda71bd5b19220a67a1e61af6081382
# Push it to GitHub
git push --set-upstream origin backport/backport-379-to-2.7
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.7Then, create a pull request where the |
This was referenced May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes the JS, JS-SPI and JS plugin zip maven publication.
Issues Resolved
#374
#377 (comment)
Testing Output:
For testing purposes I have used
url 'file://Users/pgodithi/.m2/repository'forSnapshotsRepoFor JS-SPI
For JS
For JS plugin zip
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.