Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comment out flaky test #54

Merged
merged 1 commit into from
Jun 25, 2021

Conversation

jmazanec15
Copy link
Member

@jmazanec15 jmazanec15 commented Jun 25, 2021

Signed-off-by: John Mazanec jmazane@amazon.com

Description

This PR comments out the flaky test to prevent integration tests from failing. This is a minor test that checks to see if the graph_query_errors stat is getting incremented on error.

Added information in a comment above the test:

// This test case intended to check whether the "graph_query_error" stat gets incremented when a query fails.
// It sets the circuit breaker limit to 1 kb and then indexes documents into the index and force merges so that
// the sole segment's graph will not fit in the cache. Then, it runs a query and expects an exception. Then it
// checks that the query errors get incremented. This test is flaky:
// #43. During query, when a segment to be
// searched is not present in the cache, it will first be loaded. Then it will be searched.
//
// The problem is that the cache built from CacheBuilder will not throw an exception if the entry exceeds the
// size of the cache - tested this via log statements. However, the entry gets marked as expired immediately.
// So, after loading the entry, sometimes the expired entry will get evicted before the search logic. This causes
// the search to fail. However, it appears sometimes that the entry doesnt get immediately evicted, causing the
// search to succeed.

Issues Resolved

#43

Check List

  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: John Mazanec <jmazane@amazon.com>
@jmazanec15 jmazanec15 added Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. v1.0.0 labels Jun 25, 2021
@jmazanec15 jmazanec15 requested review from VijayanB and vamshin June 25, 2021 03:17
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (main@0094dee). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage        ?   82.48%           
  Complexity      ?      474           
=======================================
  Files           ?       69           
  Lines           ?     1821           
  Branches        ?      178           
=======================================
  Hits            ?     1502           
  Misses          ?      257           
  Partials        ?       62           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0094dee...9f8305a. Read the comment docs.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@jmazanec15 jmazanec15 merged commit ff057f0 into opensearch-project:main Jun 25, 2021
jmazanec15 added a commit to jmazanec15/k-NN-1 that referenced this pull request Jun 28, 2021
Signed-off-by: John Mazanec <jmazane@amazon.com>

Co-authored-by: John Mazanec <jmazane@amazon.com>
@jmazanec15 jmazanec15 mentioned this pull request Jun 28, 2021
5 tasks
jmazanec15 added a commit to jmazanec15/k-NN-1 that referenced this pull request Jun 28, 2021
Signed-off-by: John Mazanec <jmazane@amazon.com>

Co-authored-by: John Mazanec <jmazane@amazon.com>
@jmazanec15 jmazanec15 mentioned this pull request Jun 28, 2021
5 tasks
jmazanec15 added a commit to jmazanec15/k-NN-1 that referenced this pull request Jun 28, 2021
Signed-off-by: John Mazanec <jmazane@amazon.com>

Co-authored-by: John Mazanec <jmazane@amazon.com>
jmazanec15 added a commit that referenced this pull request Jun 28, 2021
Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15 added a commit that referenced this pull request Jun 28, 2021
Signed-off-by: John Mazanec <jmazane@amazon.com>
jmazanec15 added a commit that referenced this pull request Jun 28, 2021
Signed-off-by: John Mazanec <jmazane@amazon.com>
martin-gaievski pushed a commit to martin-gaievski/k-NN that referenced this pull request Mar 7, 2022
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
martin-gaievski pushed a commit to martin-gaievski/k-NN that referenced this pull request Mar 30, 2022
Signed-off-by: John Mazanec <jmazane@amazon.com>

Co-authored-by: John Mazanec <jmazane@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Infrastructure Changes to infrastructure, testing, CI/CD, pipelines, etc. v1.0.0 v1.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants