Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #54 to 1.x #56

Merged
merged 1 commit into from
Jun 28, 2021

Conversation

jmazanec15
Copy link
Member

Signed-off-by: John Mazanec jmazane@amazon.com

Description

Cherry picks #54 to 1.x branch

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: John Mazanec <jmazane@amazon.com>

Co-authored-by: John Mazanec <jmazane@amazon.com>
@codecov-commenter
Copy link

Codecov Report

Merging #56 (9eb4d73) into 1.x (eb239ac) will decrease coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.x      #56      +/-   ##
============================================
- Coverage     82.81%   82.48%   -0.33%     
+ Complexity      476      475       -1     
============================================
  Files            69       69              
  Lines          1821     1821              
  Branches        178      178              
============================================
- Hits           1508     1502       -6     
- Misses          252      257       +5     
- Partials         61       62       +1     
Impacted Files Coverage Δ
.../java/org/opensearch/knn/index/v2011/KNNIndex.java 76.74% <0.00%> (-11.63%) ⬇️
.../java/org/opensearch/knn/index/util/KNNEngine.java 89.47% <0.00%> (-5.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb239ac...9eb4d73. Read the comment docs.

Copy link
Member

@vamshin vamshin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@jmazanec15 jmazanec15 merged commit ceeddd0 into opensearch-project:1.x Jun 28, 2021
martin-gaievski pushed a commit to martin-gaievski/k-NN that referenced this pull request Mar 7, 2022
Signed-off-by: John Mazanec <jmazane@amazon.com>
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants