Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate explainability for hybrid query into RRF processor #1037

Draft
wants to merge 1 commit into
base: feature/rrf-score-normalization-v2
Choose a base branch
from

Conversation

martin-gaievski
Copy link
Member

Description

Adding explainability support into RRF processor. PR is for feature branch while application security review for RRF feature is in progress. PR for explainability feature #1014

Check List

  • New functionality includes testing.
  • [ ] New functionality has been documented.
  • [ ] API changes companion pull request created.
  • Commits are signed per the DCO using --signoff.
  • [ ] Public documentation issue/PR created.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 78.53%. Comparing base (627fcb4) to head (8632f9c).

Files with missing lines Patch % Lines
...essor/normalization/RRFNormalizationTechnique.java 63.63% 7 Missing and 1 partial ⚠️
...processor/AbstractScoreHybridizationProcessor.java 60.00% 2 Missing ⚠️
...pensearch/neuralsearch/processor/RRFProcessor.java 75.00% 0 Missing and 1 partial ⚠️
...ssor/combination/RRFScoreCombinationTechnique.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                           Coverage Diff                            @@
##             feature/rrf-score-normalization-v2    #1037      +/-   ##
========================================================================
+ Coverage                                 78.49%   78.53%   +0.03%     
- Complexity                                 1070     1075       +5     
========================================================================
  Files                                        90       91       +1     
  Lines                                      3729     3745      +16     
  Branches                                    619      619              
========================================================================
+ Hits                                       2927     2941      +14     
- Misses                                      541      543       +2     
  Partials                                    261      261              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@martin-gaievski martin-gaievski force-pushed the integrate_explain_feature_with_rrf branch from 8632f9c to 3d67d74 Compare December 18, 2024 23:28
Signed-off-by: Martin Gaievski <gaievski@amazon.com>
@martin-gaievski martin-gaievski force-pushed the integrate_explain_feature_with_rrf branch from 3d67d74 to 2c5e6d0 Compare December 19, 2024 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant