-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature to main] Explainability in hybrid query #1014
Conversation
* Added Explainability support for hybrid query Signed-off-by: Martin Gaievski <gaievski@amazon.com>
a3fd3a2
to
66d8693
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Once this is merged, we should try to add more tests and increase the code coverage.
yup, for sure. Codecov was broken at time I was working on implementation PR, in this PR I just want to merge from feature branch, and anything else will be in a separate PR. Another thing we need to work on - add support for explainability in RRF #874 |
Description
Merge "Explainability in hybrid query" from feature branch to main, we do have clearance from app sec team.
Includes PRs:
Related Issues
Resolves #658
Check List
--signoff
.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.