-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing pulling of security plugin to run integ tests in secure opensearch cluster #543
Merged
martin-gaievski
merged 8 commits into
opensearch-project:main
from
vibrantvarun:fixing_build
Jan 23, 2024
Merged
Fixing pulling of security plugin to run integ tests in secure opensearch cluster #543
martin-gaievski
merged 8 commits into
opensearch-project:main
from
vibrantvarun:fixing_build
Jan 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Varun Jain <varunudr@amazon.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #543 +/- ##
=========================================
Coverage 84.33% 84.33%
Complexity 533 533
=========================================
Files 40 40
Lines 1564 1564
Branches 244 244
=========================================
Hits 1319 1319
Misses 133 133
Partials 112 112 ☔ View full report in Codecov by Sentry. |
BWC tests failure is expected as we do not have latest neural-search 2.12 artifact. |
vibrantvarun
changed the title
Fixing security plugin archive
Fixing pulling of security plugin to run integ tests in secure opensearch cluster
Jan 19, 2024
Signed-off-by: Varun Jain <varunudr@amazon.com>
jmazanec15
reviewed
Jan 19, 2024
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Signed-off-by: Varun Jain <varunudr@amazon.com>
vibrantvarun
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
naveentatikonda,
junqiu-lei,
martin-gaievski,
sean-zheng-amazon,
model-collapse,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
January 22, 2024 23:59
ryanbogan
approved these changes
Jan 23, 2024
martin-gaievski
approved these changes
Jan 23, 2024
martin-gaievski
added
the
backport 2.x
Label will add auto workflow to backport PR to 2.x branch
label
Jan 23, 2024
heemin32
reviewed
Jan 23, 2024
Signed-off-by: Varun Jain <varunudr@amazon.com>
heemin32
approved these changes
Jan 23, 2024
martin-gaievski
pushed a commit
that referenced
this pull request
Jan 24, 2024
…arch cluster (#543) * Fixing security plugin archive Signed-off-by: Varun Jain <varunudr@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR fixes the security plugin issue in the neural search build.
Premise:
While building neural search we are pulling security plugin via zip archive.
But in neural search we do not use security plugin as a compile time dependency.
How zipArchive works?
Zip Archive works by resolving all the dependencies provided in the dependencies section. opensearch-knn we use at compile time dependency and therefore we extract it as a jar in task extractKNN Jar. opensearch-ml-plugin zip we use it in bwc tests.
Now this line(from(zipTree(configurations.zipArchive.find { it.name.startsWith("opensearch-knn")})) ) of code tries to find opensearch-security as well however we don't use it.
The fix:
Segregate the pulling of security plugin in secureIntegTestPluginArchive configuration.
Also,
In this PR, Java 21 has been restricted to 21.0.1 due to ongoing issue in 21.0.2 version.
opensearch-project/OpenSearch#11968 (review).
Once the fix to the issue will be merged, will revert back to pulling of Java 21 to latest version.
Moreover, The bwc tests are disabled in the PR due to there is an ongoing failure of security tests due to zip archive issue. Therefore the latest build has not been published from last few days and bwc tests are failing.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.