Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression, introduced in JDK-21.0.2 #11968

reta · 2024-01-22T16:14:58Z

Description

Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression, introduced in JDK-21.0.2

Related Issues

See please #11906

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)
Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

github-actions · 2024-01-22T16:31:37Z

Compatibility status:

Checks if related components are compatible with change 286cc9c

Incompatible components

Incompatible components: [https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/k-nn.git]

github-actions · 2024-01-22T17:05:27Z

❕ Gradle check result for e6c3093: UNSTABLE

TEST FAILURES:

      1 org.opensearch.remotestore.RemoteStoreStatsIT.testNonZeroPrimaryStatsOnNewlyCreatedIndexWithZeroDocs

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov · 2024-01-22T17:06:18Z

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (761e13b) 70.86% compared to head (2f786e4) 71.41%.
Report is 2 commits behind head on main.

❗ Current head 2f786e4 differs from pull request most recent head 286cc9c. Consider uploading reports for the commit 286cc9c to get more accurate results

Files	Patch %	Lines
...ch/common/util/concurrent/OpenSearchExecutors.java	50.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11968      +/-   ##
============================================
+ Coverage     70.86%   71.41%   +0.54%     
- Complexity    58982    59398     +416     
============================================
  Files          4923     4923              
  Lines        279214   279218       +4     
  Branches      40596    40596              
============================================
+ Hits         197877   199398    +1521     
+ Misses        64876    63230    -1646     
- Partials      16461    16590     +129

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

reta · 2024-01-22T17:48:17Z

Looks like a related failure

Yeah, this is a new test, the latch is released inside pool worker but check may be performed while the task is not yet returned, changed the assertion check to be more robust.

github-actions · 2024-01-22T18:35:17Z

✅ Gradle check result for 2f786e4: SUCCESS

deshsidd · 2024-01-22T18:49:24Z

Code coverage check still not passing. Might need to add more tests?

reta · 2024-01-22T19:10:32Z

Code coverage check still not passing. Might need to add more tests?

We've been exercising only LinkedTransferQueue#put because this is what our internal policy uses.

github-actions · 2024-01-22T19:51:28Z

❌ Gradle check result for 768a430: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

…, introduced in JDK-21.0.2 Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

reta · 2024-01-22T19:59:23Z

❌ Gradle check result for 768a430: FAILURE

#11974

github-actions · 2024-01-22T20:44:55Z

❕ Gradle check result for 286cc9c: UNSTABLE

TEST FAILURES:

      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
      1 org.opensearch.action.admin.cluster.tasks.PendingTasksBlocksIT.testPendingTasksWithClusterNotRecoveredBlock

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

…, introduced in JDK-21.0.2 (#11968) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> (cherry picked from commit 48fdb4f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…, introduced in JDK-21.0.2 (#11968) (#11988) (cherry picked from commit 48fdb4f) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…, introduced in JDK-21.0.2 (opensearch-project#11968) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

…, introduced in JDK-21.0.2 (opensearch-project#11968) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> Signed-off-by: Shivansh Arora <hishiv@amazon.com>

reta added the skip-changelog label Jan 22, 2024

reta force-pushed the workaround.jdk.21.0.2 branch from e6c3093 to a09e08b Compare January 22, 2024 17:06

reta marked this pull request as ready for review January 22, 2024 17:06

reta force-pushed the workaround.jdk.21.0.2 branch from 13ab73a to 2f786e4 Compare January 22, 2024 17:46

owaiskazi19 approved these changes Jan 22, 2024

View reviewed changes

deshsidd approved these changes Jan 22, 2024

View reviewed changes

reta force-pushed the workaround.jdk.21.0.2 branch from 2f786e4 to 768a430 Compare January 22, 2024 19:28

Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression…

286cc9c

…, introduced in JDK-21.0.2 Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

reta force-pushed the workaround.jdk.21.0.2 branch from 768a430 to 286cc9c Compare January 22, 2024 19:56

msfroh approved these changes Jan 22, 2024

View reviewed changes

vibrantvarun approved these changes Jan 22, 2024

View reviewed changes

vibrantvarun mentioned this pull request Jan 22, 2024

Fixing pulling of security plugin to run integ tests in secure opensearch cluster opensearch-project/neural-search#543

Merged

5 tasks

dbwiddis approved these changes Jan 23, 2024

View reviewed changes

reta merged commit 48fdb4f into opensearch-project:main Jan 23, 2024
30 checks passed

reta added backport 2.x Backport to 2.x branch and removed skip-changelog labels Jan 23, 2024

opensearch-trigger-bot bot mentioned this pull request Jan 23, 2024

[Backport 2.x] Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression, introduced in JDK-21.0.2 #11988

Merged

This was referenced Jan 23, 2024

Update GA worklows to use JDK 21.0.2 opensearch-project/flow-framework#436

Merged

Update GA to use latest JDK-21 opensearch-project/neural-search#565

Merged

BrewTestBot mentioned this pull request Feb 21, 2024

opensearch 2.12.0 Homebrew/homebrew-core#163463

Merged

peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024

Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression…

69ea6c0

…, introduced in JDK-21.0.2 (opensearch-project#11968) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024

Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression…

96ab741

…, introduced in JDK-21.0.2 (opensearch-project#11968) Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

AmiStrn mentioned this pull request Aug 20, 2024

[BUG] Nodes dropping from cluster - possibly due to Java 21 #15092

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression, introduced in JDK-21.0.2 #11968

Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression, introduced in JDK-21.0.2 #11968

reta commented Jan 22, 2024

github-actions bot commented Jan 22, 2024 •

edited

Loading

github-actions bot commented Jan 22, 2024

codecov bot commented Jan 22, 2024 •

edited

Loading

reta commented Jan 22, 2024

github-actions bot commented Jan 22, 2024

deshsidd commented Jan 22, 2024

reta commented Jan 22, 2024

github-actions bot commented Jan 22, 2024

reta commented Jan 22, 2024

github-actions bot commented Jan 22, 2024

Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression, introduced in JDK-21.0.2 #11968

Workaround for https://bugs.openjdk.org/browse/JDK-8323659 regression, introduced in JDK-21.0.2 #11968

Conversation

reta commented Jan 22, 2024

Description

Related Issues

Check List

github-actions bot commented Jan 22, 2024 • edited Loading

Compatibility status:

Incompatible components

Skipped components

Compatible components

github-actions bot commented Jan 22, 2024

codecov bot commented Jan 22, 2024 • edited Loading

Codecov Report

reta commented Jan 22, 2024

github-actions bot commented Jan 22, 2024

deshsidd commented Jan 22, 2024

reta commented Jan 22, 2024

github-actions bot commented Jan 22, 2024

reta commented Jan 22, 2024

github-actions bot commented Jan 22, 2024

github-actions bot commented Jan 22, 2024 •

edited

Loading

codecov bot commented Jan 22, 2024 •

edited

Loading