Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GA to use latest JDK-21 #565

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

reta
Copy link
Contributor

@reta reta commented Jan 29, 2024

Description

Update GA to use latest JDK-21

Issues Resolved

See please opensearch-project/OpenSearch#11968

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed as per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f9937a4) 84.39% compared to head (a73ac40) 84.39%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #565   +/-   ##
=========================================
  Coverage     84.39%   84.39%           
  Complexity      535      535           
=========================================
  Files            40       40           
  Lines          1570     1570           
  Branches        245      245           
=========================================
  Hits           1325     1325           
  Misses          133      133           
  Partials        112      112           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vibrantvarun vibrantvarun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @reta

@martin-gaievski martin-gaievski added the backport 2.x Label will add auto workflow to backport PR to 2.x branch label Jan 29, 2024
@navneet1v navneet1v merged commit 51f9d6f into opensearch-project:main Jan 29, 2024
70 of 84 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 29, 2024
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 51f9d6f)
vibrantvarun pushed a commit to vibrantvarun/neural-search that referenced this pull request Jan 29, 2024
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
vibrantvarun pushed a commit to vibrantvarun/neural-search that referenced this pull request Jan 29, 2024
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Signed-off-by: Varun Jain <varunudr@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Label will add auto workflow to backport PR to 2.x branch skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants