[Metrics] Adding API Connection to Metrics Sidebar #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sean Li <lnse@amazon.com>
Closed
ps48
reviewed
Nov 1, 2022
Comment on lines
+28
to
+34
| const normalizedData = dataSet.visualizations.map((obj: any) => ({ | ||
| id: obj.id, | ||
| name: obj.name, | ||
| catalog: 'CUSTOM_METRICS', | ||
| type: obj.type, | ||
| })); | ||
| return normalizedData; |
There was a problem hiding this comment.
NOTE: We'll have to filter out the non-metrics visualizations later.
| metricsList: any; | ||
| visualizationsList: any; | ||
| http: CoreStart['http']; | ||
| pplService: PPLService; |
There was a problem hiding this comment.
Explanation for other reviewers :
The more-optimal solution here would be to enclose http and pplService into their own stores (Redux?), so that drill-down is not necessary. Unfortunately, that work is beyond the resource availability that we have for this release. For now we'll provide these values in the props here, and the larger refactoring of stores will naturally take care of this case.
pjfitzgibbons
approved these changes
Nov 1, 2022
ps48
reviewed
Nov 1, 2022
dashboards-observability/public/components/metrics/redux/slices/metrics_slice.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Sean Li <lnse@amazon.com>
ps48
approved these changes
Nov 1, 2022
This was referenced Nov 1, 2022
ps48
pushed a commit
to ps48/observability
that referenced
this pull request
Nov 3, 2022
…t#1211) * Adding API connects Signed-off-by: Sean Li <lnse@amazon.com> * Addressing constant chagne Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Sean Li <lnse@amazon.com>
ps48
added a commit
that referenced
this pull request
Nov 3, 2022
* Adding Empty View and Side Bar (#1154) * Added Metrics Home Page and date picker Signed-off-by: Sean Li <lnse@amazon.com> * Minor changes Signed-off-by: Sean Li <lnse@amazon.com> * Adding empty view and sidebar Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Sean Li <lnse@amazon.com> * added empty view Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Adding Sidebar to Metrics Home (#1171) * Added Metrics Home Page and date picker Signed-off-by: Sean Li <lnse@amazon.com> * Minor changes Signed-off-by: Sean Li <lnse@amazon.com> * Adding empty view and sidebar Signed-off-by: Sean Li <lnse@amazon.com> * Adding metrics reducer to redux store Signed-off-by: Sean Li <lnse@amazon.com> * Adding functioning sidebar to home page Signed-off-by: Sean Li <lnse@amazon.com> * Removing unnecessary function Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Sean Li <lnse@amazon.com> * [Events] Save panel (#1185) * Save panel Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * remove comments Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * remove milliseconds from constants Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * [Metrics] Adding API Connection to Metrics Sidebar (#1211) * Adding API connects Signed-off-by: Sean Li <lnse@amazon.com> * Addressing constant chagne Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Sean Li <lnse@amazon.com> * Metrics api events (#1214) * Add schema to router in events Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * update Saved Visualization in backend to include metrics Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * add SelectedLabels class Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * Add Token class in saved visualization Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * update test Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * fix frontend API data Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * update default subtype state to viz Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * disabling labels on front end Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * remove console.log comments Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * remove logger comments Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * Adding visualizations panel to metrics (#1222) * adding vizualization components Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * added metrics layout to redux Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * removed comments and updated constants Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * remove excess console.log Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * added dummy search field, panel push button (#1227) Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> * Show metrics in events homepage (#1232) * Add Metrics to events home page and fix jest test Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * fix save_query_table jest test Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * fix backend test Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> * Sidepanel update (#1230) * Updating sidepanel Signed-off-by: Sean Li <lnse@amazon.com> * Removing mock metrics Signed-off-by: Sean Li <lnse@amazon.com> * Allowing horizontal scroll on metric lists Signed-off-by: Sean Li <lnse@amazon.com> * Minor changes Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Sean Li <lnse@amazon.com> * add metrics to nav bar Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Shenoy Pratik <sgguruda@amazon.com> Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com> Co-authored-by: Sean Li <lnse@amazon.com> Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
derek-ho
pushed a commit
that referenced
this pull request
Dec 22, 2022
* Adding API connects Signed-off-by: Sean Li <lnse@amazon.com> * Addressing constant chagne Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: Sean Li <lnse@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sean Li lnse@amazon.com
Description
Adding API Connection to Metrics Sidebar and refactoring redux.
Issues Resolved
opensearch-project/dashboards-observability#43 opensearch-project/dashboards-observability#42 opensearch-project/dashboards-observability#58 opensearch-project/dashboards-observability#59
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.