Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics api events #1214

Merged
merged 14 commits into from
Nov 1, 2022
Merged

Metrics api events #1214

merged 14 commits into from
Nov 1, 2022

Conversation

kavithacm
Copy link
Collaborator

@kavithacm kavithacm commented Nov 1, 2022 •
edited
Loading

Description

Save button API workflow under event analytics for metrics

Issues Resolved

opensearch-project/dashboards-observability#139 opensearch-project/dashboards-observability#140

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@kavithacm
Add schema to router in events
c692304 
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm
update Saved Visualization in backend to include metrics
f16bd97 
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm
add SelectedLabels class
7de42d6 
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm
Add Token class in saved visualization
5b21792 
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm
Merge branch 'feature/metrics' of https://github.com/opensearch-proje…
2b4795e 
…ct/observability into metrics-api-events
@kavithacm
Merge branch 'feature/metrics' of https://github.com/opensearch-proje…
53d7fff 
…ct/observability into metrics-api-events
@kavithacm
update test
1c5dbda 
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm
fix frontend API data
20a9f87 
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm
Merge branch 'metrics-api-events' of https://github.com/kavithacm/tra…
3acbfa4 
…ce-analytics into metrics-api-events
@kavithacm
update default subtype state to viz
e36c73b 
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm
disabling labels on front end
322b929 
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm
remove console.log comments
1dfbda3 
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm
remove logger comments
9b899a7 
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
@kavithacm
Merge branch 'metrics-api-events' of https://github.com/kavithacm/tra…
2ef1f3a 
…ce-analytics into metrics-api-events
@kavithacm kavithacm requested a review from a team as a code owner November 1, 2022 19:01
sejli
sejli approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@sejli sejli left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! may need to take a look at the build errors though

dashboards-observability/public/components/event_analytics/explorer/save_panel/save_panel.tsx
</EuiTitle>
<EuiFormRow>
</EuiTitle> */}
{/* <EuiFormRow>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments if unnecessary? unless we are still deciding on using labels

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let this component be commented for now(can be used later), need to finish some more work in events home page

@kavithacm
Copy link
Collaborator Author

those are just failed tests, thats fine for now

@kavithacm kavithacm merged commit e64628d into opensearch-project:feature/metrics Nov 1, 2022
@pjfitzgibbons pjfitzgibbons mentioned this pull request Nov 1, 2022
Open
ps48 pushed a commit to ps48/observability that referenced this pull request Nov 3, 2022
@kavithacm @ps48
Metrics api events (opensearch-project#1214)
f701637 
* Add schema to router in events

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update Saved Visualization in backend to include metrics

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* add SelectedLabels class

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* Add Token class in saved visualization

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update test

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* fix frontend API data

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update default subtype state to viz

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* disabling labels on front end

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* remove console.log comments

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* remove logger comments

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
ps48 added a commit that referenced this pull request Nov 3, 2022
@ps48 @sejli @kavithacm
Merge feature/metrics branch to 2.4 (#1234)
04852a7 
* Adding Empty View and Side Bar (#1154)

* Added Metrics Home Page and date picker

Signed-off-by: Sean Li <lnse@amazon.com>

* Minor changes

Signed-off-by: Sean Li <lnse@amazon.com>

* Adding empty view and sidebar

Signed-off-by: Sean Li <lnse@amazon.com>

Signed-off-by: Sean Li <lnse@amazon.com>

* added empty view

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* Adding Sidebar to Metrics Home (#1171)

* Added Metrics Home Page and date picker

Signed-off-by: Sean Li <lnse@amazon.com>

* Minor changes

Signed-off-by: Sean Li <lnse@amazon.com>

* Adding empty view and sidebar

Signed-off-by: Sean Li <lnse@amazon.com>

* Adding metrics reducer to redux store

Signed-off-by: Sean Li <lnse@amazon.com>

* Adding functioning sidebar to home page

Signed-off-by: Sean Li <lnse@amazon.com>

* Removing unnecessary function

Signed-off-by: Sean Li <lnse@amazon.com>

Signed-off-by: Sean Li <lnse@amazon.com>

* [Events] Save panel (#1185)

* Save panel

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* remove comments

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* remove milliseconds from constants

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* [Metrics] Adding API Connection to Metrics Sidebar (#1211)

* Adding API connects

Signed-off-by: Sean Li <lnse@amazon.com>

* Addressing constant chagne

Signed-off-by: Sean Li <lnse@amazon.com>

Signed-off-by: Sean Li <lnse@amazon.com>

* Metrics api events (#1214)

* Add schema to router in events

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update Saved Visualization in backend to include metrics

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* add SelectedLabels class

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* Add Token class in saved visualization

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update test

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* fix frontend API data

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update default subtype state to viz

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* disabling labels on front end

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* remove console.log comments

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* remove logger comments

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* Adding visualizations panel to metrics (#1222)

* adding vizualization components

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* added metrics layout to redux

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* removed comments and updated constants

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* remove excess console.log

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* added dummy search field, panel push button (#1227)

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

* Show metrics in events homepage (#1232)

* Add Metrics to events home page and fix jest test

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* fix save_query_table jest test

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* fix backend test

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* Sidepanel update (#1230)

* Updating sidepanel

Signed-off-by: Sean Li <lnse@amazon.com>

* Removing mock metrics

Signed-off-by: Sean Li <lnse@amazon.com>

* Allowing horizontal scroll on metric lists

Signed-off-by: Sean Li <lnse@amazon.com>

* Minor changes

Signed-off-by: Sean Li <lnse@amazon.com>

Signed-off-by: Sean Li <lnse@amazon.com>

* add metrics to nav bar

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>

Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Co-authored-by: Sean Li <lnse@amazon.com>
Co-authored-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
derek-ho pushed a commit that referenced this pull request Dec 22, 2022
@kavithacm
Metrics api events (#1214)
0454110 
* Add schema to router in events

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update Saved Visualization in backend to include metrics

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* add SelectedLabels class

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* Add Token class in saved visualization

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update test

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* fix frontend API data

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* update default subtype state to viz

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* disabling labels on front end

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* remove console.log comments

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

* remove logger comments

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>

Signed-off-by: Kavitha Conjeevaram Mohan <mohakavi@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejli sejli sejli approved these changes

@pjfitzgibbons pjfitzgibbons pjfitzgibbons approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kavithacm @pjfitzgibbons @sejli