Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove metrics unit of measures #1261

Merged
merged 1 commit into from
Nov 4, 2022
Merged

Remove metrics unit of measures #1261

merged 1 commit into from
Nov 4, 2022

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Nov 4, 2022

Signed-off-by: Shenoy Pratik sgguruda@amazon.com

Description

Remove metrics unit of measures

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Shenoy Pratik <sgguruda@amazon.com>
@ps48 ps48 requested a review from a team as a code owner November 4, 2022 18:01
@mengweieric mengweieric self-requested a review November 4, 2022 18:02
@codecov-commenter
Copy link

codecov-commenter commented Nov 4, 2022

Codecov Report

Merging #1261 (7cd41af) into 2.4 (0ea635a) will increase coverage by 0.02%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.4    #1261      +/-   ##
============================================
+ Coverage     55.27%   55.30%   +0.02%     
  Complexity      292      292              
============================================
  Files           294      294              
  Lines         10180    10173       -7     
  Branches       2343     2343              
============================================
- Hits           5627     5626       -1     
+ Misses         4381     4375       -6     
  Partials        172      172              
Flag Coverage Δ
dashboards-observability 50.69% <ø> (+0.03%) ⬆️
opensearch-observability 70.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...shboards-observability/common/constants/metrics.ts 100.00% <ø> (ø)
...bility/public/components/metrics/helpers/utils.tsx 75.71% <ø> (ø)
...mponents/metrics/top_menu/metrics_export_panel.tsx 63.63% <ø> (+8.63%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ps48 ps48 merged commit 915fcc9 into opensearch-project:2.4 Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants