ScriptFinder logic temporary update to use correct integtest.sh #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pensearch-project#497 is fixed in plugin repos Signed-off-by: Himanshu Setia <setiah@amazon.com>
Codecov Report
@@ Coverage Diff @@
## main #499 +/- ##
=======================================
Coverage 69.31% 69.31%
=======================================
Files 58 58
Lines 1509 1509
=======================================
Hits 1046 1046
Misses 463 463
Continue to review full report at Codecov.
|
dblock
reviewed
Sep 16, 2021
| os.path.realpath(os.path.join(git_dir, "scripts/integtest.sh")), | ||
| # TODO: Uncomment this after the integtest.sh tool is removed from plugin repos. See issue #497 | ||
| # os.path.realpath(os.path.join(git_dir, "integtest.sh")), | ||
| # os.path.realpath(os.path.join(git_dir, "scripts/integtest.sh")), |
There was a problem hiding this comment.
Are there any repos doing this? If not I would uncomment it, this way repos can actually customize the integtest.sh script. And remove the option of having it at the root permanently.
There was a problem hiding this comment.
yeah, the 5 mentioned in issue #497 are doing this. The idea was to unblock integration testing, while we get these resolved in parallel, inside the mentioned plugin repos.
dblock
approved these changes
Sep 16, 2021
saratvemulapalli
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ScriptFinder logic temporary update to use correct integtest.sh until #497 is fixed in plugin repos
Signed-off-by: Himanshu Setia setiah@amazon.com
Issues Resolved
#469
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.