Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove integtest.sh from all plugin repos #497

Closed
5 tasks
setiah opened this issue Sep 15, 2021 · 2 comments · Fixed by #569
Closed
5 tasks

Remove integtest.sh from all plugin repos #497

setiah opened this issue Sep 15, 2021 · 2 comments · Fixed by #569
Assignees
Labels
enhancement New Enhancement

Comments

@setiah
Copy link
Contributor

setiah commented Sep 15, 2021

The integtest.sh tool contains the logic to run integration tests for a plugin. This logic is mostly common across most plugins, so it has been moved to opensearch-build repo. Thus it can be removed from the individual plugin repos.
However, if a plugin requires some custom logic to run integtests, which the standard tool doesn't provide, they can continue maintaining this integtest.sh in their own repo. In this case, when the integration tests are run, if a plugin has a integtest.sh tool in their repo, it gets precedence over the standard default integtest.sh in the opensearch-build repo. This precedence order logic is defined in ScriptFinder here

Action items:

Raise PRs on all plugin repos and remove integtest.sh

  • index-management
  • anomaly-detection,
  • alerting
  • asynchronous-search
  • k-NN

Changes will need to be backported into 1.x branches if such exist, too.

@setiah setiah added the enhancement New Enhancement label Sep 15, 2021
setiah pushed a commit to setiah/opensearch-build that referenced this issue Sep 15, 2021
…pensearch-project#497 is fixed in plugin repos

Signed-off-by: Himanshu Setia <setiah@amazon.com>
setiah added a commit that referenced this issue Sep 16, 2021
…497 is fixed in plugin repos (#499)

Signed-off-by: Himanshu Setia <setiah@amazon.com>
@dblock
Copy link
Member

dblock commented Sep 16, 2021

I took the liberty to make PRs in all plugin repos that had an integtest.sh file using meta, see opensearch-project/opensearch-plugins#80.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New Enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants