-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove integtest.sh
from all plugin repos
#497
Labels
enhancement
New Enhancement
Comments
setiah
pushed a commit
to setiah/opensearch-build
that referenced
this issue
Sep 15, 2021
…pensearch-project#497 is fixed in plugin repos Signed-off-by: Himanshu Setia <setiah@amazon.com>
1 task
This was referenced Sep 16, 2021
1 task
I took the liberty to make PRs in all plugin repos that had an integtest.sh file using meta, see opensearch-project/opensearch-plugins#80. |
This was referenced Sep 16, 2021
This was referenced Sep 17, 2021
This was referenced Sep 23, 2021
This was referenced Dec 13, 2023
Merged
DarshitChanpura
added a commit
to DarshitChanpura/security
that referenced
this issue
Dec 13, 2023
…/opensearch-build#497 Signed-off-by: Darshit Chanpura <dchanp@amazon.com>
3 tasks
This was referenced Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The integtest.sh tool contains the logic to run integration tests for a plugin. This logic is mostly common across most plugins, so it has been moved to
opensearch-build
repo. Thus it can be removed from the individual plugin repos.However, if a plugin requires some custom logic to run integtests, which the standard tool doesn't provide, they can continue maintaining this integtest.sh in their own repo. In this case, when the integration tests are run, if a plugin has a integtest.sh tool in their repo, it gets precedence over the standard default integtest.sh in the
opensearch-build
repo. This precedence order logic is defined in ScriptFinder hereAction items:
Raise PRs on all plugin repos and remove integtest.sh
Changes will need to be backported into 1.x branches if such exist, too.
The text was updated successfully, but these errors were encountered: