Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-add lookup for custom integtest.sh. #569

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

dblock
Copy link
Member

@dblock dblock commented Sep 23, 2021

Signed-off-by: dblock dblock@amazon.com

Description

All the projects have gotten rid of their custom integtest.sh for 1.1, so we can re-add the lookup and tests.

Issues Resolved

Closes #497.

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: dblock <dblock@amazon.com>
@dblock dblock requested review from VachaShah and setiah September 23, 2021 13:54
@setiah
Copy link
Contributor

setiah commented Sep 23, 2021

Spot checked few plugins, AD seems to have this file https://github.com/opensearch-project/anomaly-detection/blob/1.1/integtest.sh

Copy link
Contributor

@VachaShah VachaShah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,Thank you @dblock for the changes!

@dblock
Copy link
Member Author

dblock commented Sep 23, 2021

@dblock
Copy link
Member Author

dblock commented Sep 23, 2021

Okay, this time it's ready.

I used #574:

./bundle-workflow/checkout.sh manifests/1.1.0/opensearch-1.1.0.yml
cd /tmp/tmpco2jldpf
$ find . -name integtest.sh

@dblock
Copy link
Member Author

dblock commented Sep 23, 2021

@setiah ready for you

@dblock dblock merged commit 7b55167 into opensearch-project:main Sep 23, 2021
@dblock dblock deleted the add-integtest-sh branch September 23, 2021 21:14
@dblock dblock restored the add-integtest-sh branch November 22, 2021 22:33
@dblock dblock deleted the add-integtest-sh branch November 22, 2021 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove integtest.sh from all plugin repos
4 participants