Use moveToTestNotebook during notebooks-reporting integration suite #1250
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While debugging the failing tests opensearch-project/dashboards-observability#1702, it looks like the reason is that the notebook loading is flaky immediately after creation. This is due to not using the refresh logic in the
moveToTestNotebook
method in the second test suite, it was only present in the first. After looking over the usage of this method, I decided to move the refresh logic straight tomakeTestNotebook
and deletedmoveToTestNotebook
since its only use seemed to be to force this refresh.Needs backport to 2.x / 2.14.
Issues Resolved
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.