Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use moveToTestNotebook during notebooks-reporting integration suite #1250

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Use moveToTestNotebook during notebooks-reporting integration suite #1250

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79865ba
Use moveToTestNotebook during reporting integration suite
Swiddis Apr 29, 2024
a6bcb35
Move refresh logic out of movetonotebook and delete old method
Swiddis Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 8 additions & 20 deletions cypress/integration/plugins/observability-dashboards/6_notebooks.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,14 @@ const moveToNotebookHome = () => {
cy.visit(`${BASE_PATH}/app/observability-notebooks#/`);
};

const moveToTestNotebook = (notebookName) => {
cy.visit(`${BASE_PATH}/app/observability-notebooks#/`, {
timeout: delayTime * 3,
});
const makeTestNotebook = () => {
let notebookName = testNotebookName();

moveToNotebookHome();
cy.get('a[data-test-subj="createNotebookPrimaryBtn"]').click();
cy.get('input[data-test-subj="custom-input-modal-input"]').focus();
cy.get('input[data-test-subj="custom-input-modal-input"]').type(notebookName);
cy.get('button[data-test-subj="custom-input-modal-confirm-button"]').click();

// Force refresh the observablity index and reload page to load notebooks.
cy.request({
Expand All @@ -46,21 +50,6 @@ const moveToTestNotebook = (notebookName) => {
});
cy.reload();

cy.get('.euiTableCellContent')
.contains(notebookName, {
timeout: delayTime * 3,
})
.click();
};

const makeTestNotebook = () => {
let notebookName = testNotebookName();

moveToNotebookHome();
cy.get('a[data-test-subj="createNotebookPrimaryBtn"]').click();
cy.get('input[data-test-subj="custom-input-modal-input"]').focus();
cy.get('input[data-test-subj="custom-input-modal-input"]').type(notebookName);
cy.get('button[data-test-subj="custom-input-modal-confirm-button"]').click();
cy.get('h1[data-test-subj="notebookTitle"]')
.contains(notebookName)
.should('exist');
Expand Down Expand Up @@ -107,7 +96,6 @@ const deleteNotebook = (notebookName) => {
describe('Testing notebook actions', () => {
beforeEach(() => {
let notebookName = makeTestNotebook();
moveToTestNotebook(notebookName);
cy.wrap({ name: notebookName }).as('notebook');
});

Expand Down
Loading