-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k-NN guide and samples #586
Conversation
Signed-off-by: Thomas Farr <tsfarr@amazon.com>
- [Create a client using `ApacheHttpClient5Transport`](#create-a-client-using-apachehttpclient5transport) | ||
- [Create a client using `RestClientTransport` (deprecated)](#create-a-client-using-restclienttransport-deprecated) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
mainClass.set("org.opensearch.client.samples.Main") | ||
} | ||
|
||
tasks.named<JavaExec>("run") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not needed :-) Shouldn't the property be picked up if defined?
|
||
package org.opensearch.client.samples; | ||
|
||
public class RandUtil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably knn
package is better place, I suspect we would have more samples added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Vacha Shah <vachshah@amazon.com>
* Add k-NN guide and samples (#586) Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Vacha Shah <vachshah@amazon.com> * Reorganizing user guide and adding working samples (#610) * Reorganizing user guide and moving code snippets to guides Signed-off-by: Vacha Shah <vachshah@amazon.com> * Adding working samples for the client Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Vacha Shah <vachshah@amazon.com> * Fixing compile errors for ApacheHttpClient5Transport Signed-off-by: Vacha Shah <vachshah@amazon.com> --------- Signed-off-by: Thomas Farr <tsfarr@amazon.com> Signed-off-by: Vacha Shah <vachshah@amazon.com> Co-authored-by: Thomas Farr <tsfarr@amazon.com>
Description
Documents how to perform approximate k-NN searches and adds complete running samples for the different k-NN queries.
Based off @dblock's work in opensearch-project/opensearch-py#449
Issues Resolved
Resolves #578
Resolves #558
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.