Added k-nn user guide and samples. #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested review from
VachaShah,
harshavamsi,
axeoman,
deztructor and
Shephalimittal
as code owners
Codecov Report
@@ Coverage Diff @@
## main #449 +/- ##
==========================================
+ Coverage 71.42% 71.49% +0.06%
==========================================
Files 81 81
Lines 7668 7668
==========================================
+ Hits 5477 5482 +5
+ Misses 2191 2186 -5 |
|
@vamshin ++ take a look pls? |
Signed-off-by: dblock <dblock@amazon.com>
Signed-off-by: dblock <dblock@amazon.com>
navneet1v
reviewed
Jul 24, 2023
| } | ||
| } | ||
|
|
||
| results = client.search(index=index_name, body=search_query) |
There was a problem hiding this comment.
can we add that if we disable the _source field than it helps in reducing the latency of the search.
There was a problem hiding this comment.
we could, but feels like that's a very narrow use-case where I don't actually have any additional data and only want the ID, no?
There was a problem hiding this comment.
I would say we can have section which is how to use the api in production for best performance. Hence I was thinking we should mention it. Reason is this is very valid for k-NN.
navneet1v
reviewed
Jul 24, 2023
navneet1v
reviewed
Jul 24, 2023
Signed-off-by: dblock <dblock@amazon.com>
kkmr
approved these changes
Jul 25, 2023
Xtansia
suggested changes
Jul 26, 2023
Signed-off-by: Vacha Shah <vachshah@amazon.com>
VachaShah
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added k-nn user guide and samples.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.