Fix PutTemplateRequest deserialization #723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bfindlay <bfindlay@acm.org>
Bfindlay
requested review from
reta,
Bukhtawar,
dblock,
szczepanczykd,
madhusudhankonda,
saratvemulapalli and
VachaShah
as code owners
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
dblock
reviewed
Nov 13, 2023
java-client/src/test/java/org/opensearch/client/opensearch/core/PutTemplateRequestTest.java
Outdated
Show resolved
Hide resolved
dblock
reviewed
Nov 13, 2023
java-client/src/test/java/org/opensearch/client/opensearch/core/PutTemplateRequestTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
Signed-off-by: bfindlay <bfindlay@acm.org>
|
@dblock Comments addressed 👍 |
reta
approved these changes
Nov 15, 2023
dblock
approved these changes
Nov 18, 2023
This was referenced Dec 12, 2023
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-723-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3ec3cae6a0c1723c7e86acf8f967750ef806d4c7
# Push it to GitHub
git push --set-upstream origin backport/backport-723-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/backport-2.xThen, create a pull request where the |
VachaShah
pushed a commit
to VachaShah/opensearch-java
that referenced
this pull request
Feb 7, 2024
* fix PutTemplateRequest deserialization Signed-off-by: bfindlay <bfindlay@acm.org> * update changelog Signed-off-by: bfindlay <bfindlay@acm.org> * fix changelog PR number Signed-off-by: bfindlay <bfindlay@acm.org> * update for pr review Signed-off-by: bfindlay <bfindlay@acm.org> * update unit test for pr Signed-off-by: bfindlay <bfindlay@acm.org> * apply spotless check Signed-off-by: bfindlay <bfindlay@acm.org> --------- Signed-off-by: bfindlay <bfindlay@acm.org>
VachaShah
pushed a commit
to VachaShah/opensearch-java
that referenced
this pull request
Feb 8, 2024
* fix PutTemplateRequest deserialization Signed-off-by: bfindlay <bfindlay@acm.org> * update changelog Signed-off-by: bfindlay <bfindlay@acm.org> * fix changelog PR number Signed-off-by: bfindlay <bfindlay@acm.org> * update for pr review Signed-off-by: bfindlay <bfindlay@acm.org> * update unit test for pr Signed-off-by: bfindlay <bfindlay@acm.org> * apply spotless check Signed-off-by: bfindlay <bfindlay@acm.org> --------- Signed-off-by: bfindlay <bfindlay@acm.org> Signed-off-by: Vacha Shah <vachshah@amazon.com>
reta
pushed a commit
that referenced
this pull request
Feb 8, 2024
* fix PutTemplateRequest deserialization * update changelog * fix changelog PR number * update for pr review * update unit test for pr * apply spotless check --------- Signed-off-by: bfindlay <bfindlay@acm.org> Signed-off-by: Vacha Shah <vachshah@amazon.com> Co-authored-by: Brett Findlay <brett@dawnpatroltv.com>
|
Hi @reta @VachaShah I see the backport job failed, does this mean that the fix was not released? |
Sadly yeah, we missed it but @VachaShah did manual backport a few days ago. I think we could make another release this week, sorry about that @Bfindlay |
|
@reta Thanks for the update, would be great if you can keep me in the loop on the release as this is a blocker for us. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Link to issue 417
This PR adds in the missing deserialization steps to the PutTemplateRequest _DESERIALIZER which would result in the error
Missing required property 'PutTemplateRequest.name'if you tried to deserialize a request object.Issues Resolved
#417
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.